-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
when Pr pipeline is disabled, PR does not actually go through the pr pipeline, but the PR result is shown as "pass", so pr reviewer would misunderstand the pr is ok to be merged, which might cause "false pass" issue.
enhancement would be: when pr pipeline is disabled, give PR result a default "fail" in PR check result.
Steps to reproduce it:
- set up any PR pipeline which is triggered by webhook in a github repo
- disable this PR pipeline
- when PR created in github repo, PR does not actually go through the pr pipeline, but the PR result is shown as "pass"
[JENKINS-71201] webhook intergration enhancement with jenkins?- when pr pipeline is disabled, give PR result a default fail
Haojue
added a comment -
hi markewaite ,
Sorry for late reply! Steps
- set up any PR pipeline which is triggered by webhook in a github repo
- disable this PR pipeline
- when PR created in github repo, PR does not actually go through the pr pipeline, but the PR result is shown as "pass"
Haojue
added a comment -
hi markewaite ,
Sorry for late reply! Steps
set up any PR pipeline which is triggered by webhook in a github repo
disable this PR pipeline
when PR created in github repo, PR does not actually go through the pr pipeline, but the PR result is shown as "pass"
Thanks haojuewang for providing a few steps, but those steps are not enough for someone else to duplicate the issue.
In an open source project like Jenkins, an issue report needs to be detailed enough that it persuades someone to donate their time to investigate it. Your description does not provide the details that are requested in "How to report an issue". Your description does not provide step by step directions that others can use to duplicate the issue.
I am not a user of the webhook step plugin, so I am unlikely to investigate the issue in any case, but other users or plugin maintainers will be more interested if you provide more details as recommended in "How to report an issue".
haojuewang this issue report does not seem to have any relationship to the https://plugins.jenkins.io/webhook-step/ plugin that is assigned as its component. Can you provide enough details so that others can duplicate the scenario? See "How to report an issue" for detailed instructions.