Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71238

New login page breaks login-theme-plugin (regression in 2.404)

    • 2.418. 2.414.2

      Hi,

      Not sure if it's something that must be fixed on core or on the plugin (I took co-maintenance of it recently).

      Using the login-theme-plugin: 34.v952c1007b_d92 on latest weekly break layout.

      Footer looks ok but probably head and header must be moved to the right side pane ?

       

          [JENKINS-71238] New login page breaks login-theme-plugin (regression in 2.404)

          Based on a quick look, the plugin needs to adapt the new design, which luckily is available on an API level by now.

          Alexander Brandes added a comment - Based on a quick look, the plugin needs to adapt the new design, which luckily is available on an API level by now.

          Is there an instruction somewhere available on how to change the logo or login text for the new design?

          Patryk Walerianczyk added a comment - Is there an instruction somewhere available on how to change the logo or login text for the new design?

          Hi haker146

          I didn't take a look at this issue, but also I'm not sure where to start.

          I might try to fix it for the next LTS. New design is only available on weekly for now.

          Regards,

          Valentin Delaye added a comment - Hi haker146 I didn't take a look at this issue, but also I'm not sure where to start. I might try to fix it for the next LTS. New design is only available on weekly for now. Regards,

          Basil Crow added a comment -

          Basil Crow added a comment - janfaracik FYI

          Jan Faracik added a comment -

          Hey, happy to take a look into this

          Jan Faracik added a comment - Hey, happy to take a look into this

          Thanks! janfaracik happy to review and merge when ready

          Valentin Delaye added a comment - Thanks! janfaracik happy to review and merge when ready

          Jan Faracik added a comment -

          What's the expected behaviour for `simple-header`? Do you want it to replace the current header 'Sign in to Jenkins' or append to it?

          Jan Faracik added a comment - What's the expected behaviour for `simple-header`? Do you want it to replace the current header 'Sign in to Jenkins' or append to it?

          Natively I would say replace. If possible as soon as possible of the old behaviour

          Valentin Delaye added a comment - Natively I would say replace. If possible as soon as possible of the old behaviour

          Jan Faracik added a comment -

          Jan Faracik added a comment - Opened a PR for Jenkins here https://github.com/jenkinsci/jenkins/pull/8341

            janfaracik Jan Faracik
            jonesbusy Valentin Delaye
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: