Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71784

In process script approval is triggering for just saving the "System" page in "Manage Jenkins"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • email-ext-plugin
    • None

      Blank in process script approval requests appearing when saving configurations in Manage Jenkins-System.

      Reproduction Steps

      • Spin up the latest controller in CBCI
      • Go to Manage Jenkins-> System and save the page.
      • Go to in process script approval and you should see a request to approve or deny a script. But the script textbox is blank.
      • See attached screenshot for an example.

       

      Expected outcome

      • No script is sent for approval after just saving the System Config page

       

      More info about the issue:

      The issue comes from https://github.com/jenkinsci/email-ext-plugin/blob/06a409c9078bc12785ae1661cf3d8e50d7b34579/src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java#L711

      which is called when saving the System Config page and then it is calling the method create() in ApprovalContext https://github.com/jenkinsci/script-security-plugin/blob/ecf66020eb7d5960a576cb0d3ffd0180de62a518/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ApprovalContext.java#L55

      Therefore, when disabling the email-ext plugin, the issue is no longer reproduced.

            slide_o_mix Alex Earl
            cloudbees_security_members CloudBees Security Developers
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: