-
Bug
-
Resolution: Unresolved
-
Minor
-
None
After upgrading to the 3.2 Authentication Matrix, it appears it is having a conflict with NowSecure plugin when setting up through pipeline.
Pipeline code snippet:
properties([ authorizationMatrix([group(name: 'AD Group Name', permissions: ['Job/Build', 'Job/Cancel', 'Job/Discover', 'Job/Read', 'Job/Workspace']) ]), ])
This is the error we are getting:
WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions[Pipeline] End of PipelineAlso: org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 806341b0-06b8-4711-86d6-cef16b1b082b org.jenkinsci.plugins.workflow.steps.MissingContextVariableException: Required context class hudson.FilePath is missing Perhaps you forgot to surround the code with a step that provides this, such as: node at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:90) at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:71) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) Finished: FAILURE
If I leave the pipeline as this:
properties([ authorizationMatrix([ ]), ])
The Jenkins pipeline will run with no issues.
[JENKINS-71984] Matrix Authentication conflicting with NowSecure plugin after 3.2 upgrade
is there no context-specific lookup of symbols?
There is.
So my choice of "user" and "group" was a bad one, as they're likely too generic?
Those symbols sound fine to me.
I have no idea offhand why the properties step syntax shown above would cause MissingContextVariableException, if in fact that does happen; these things seem unrelated. Is there a minimal reproducible test case?
Is there a minimal reproducible test case?
I can reproduce this by installing workflow-aggregator, matrix-auth, and nowsecure-auto-security-test on 2.414.1, configuring Project-bases security as authorization strategy, with Authenticated Users getting Overall/Administer, then creating a Pipeline with
properties([ authorizationMatrix([ group(name: 'foo', permissions: ['Job/Build', 'Job/Cancel', 'Job/Discover', 'Job/Read', 'Job/Workspace']) ]) ])
it fails with the provided error when run.
Disabling the nowsecure-auto-security-test plugin, restarting, and re-running, the build passes and has the expected result.
The system log has some more potentially interesting messages:
2023-09-13 10:57:40.884+0000 [id=235] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:57:40.885+0000 [id=235] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@4150963a java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) … 2023-09-13 10:57:40.891+0000 [id=235] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:57:40.892+0000 [id=235] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@4a7aa9e5 java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) … 2023-09-13 10:57:40.963+0000 [id=235] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:57:40.964+0000 [id=235] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@350daca9 java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) … 2023-09-13 10:58:52.560+0000 [id=243] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:58:52.560+0000 [id=243] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@436e42d9 java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) … 2023-09-13 10:58:52.563+0000 [id=243] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:58:52.563+0000 [id=243] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@8c0bd3b java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) … 2023-09-13 10:58:52.579+0000 [id=243] WARNING o.j.p.s.d.DescribableModel#instantiate: WARNING: Unknown parameter(s) found for class type 'com.nowsecure.auto.jenkins.plugin.NSAutoPlugin': name,permissions 2023-09-13 10:58:52.579+0000 [id=243] WARNING o.j.p.s.d.DescribableParameter#uncoerce: failed to uncoerce com.nowsecure.auto.jenkins.plugin.NSAutoPlugin@5ebc3784 java.lang.UnsupportedOperationException: no public field ‘validateDnsUrlConnection’ (or getter method) found in class com.nowsecure.auto.jenkins.plugin.NSAutoPlugin at org.jenkinsci.plugins.structs.describable.DescribableParameter.getValue(DescribableParameter.java:161) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2_(DescribableModel.java:752) at org.jenkinsci.plugins.structs.describable.DescribableParameter.uncoerce(DescribableParameter.java:196) at org.jenkinsci.plugins.structs.describable.DescribableParameter.inspect(DescribableParameter.java:142) at org.jenkinsci.plugins.structs.describable.DescribableModel.uninstantiate2(DescribableModel.java:655) at org.jenkinsci.plugins.workflow.actions.ArgumentsAction.resolve(ArgumentsAction.java:306) …
Sounds like there is an auxiliary robustness bug for structs: presence of bad models in the system should not generally block usage of unrelated plugins.
https://github.com/jenkinsci/nowsecure-auto-security-test-plugin/blob/2a17d0f259db01d92088ec35b45acb1534eae427/src/main/java/com/nowsecure/auto/jenkins/plugin/NSAutoPlugin.java#L499 looks like the other plugin's maintainers don't know what this annotation does, and it should be fixed in their plugin. I'm rejecting this for now for matrix-auth.
CC jglick; is there no context-specific lookup of symbols? So my choice of "user" and "group" was a bad one, as they're likely too generic? (I thought I had tested this by adapting the sample plugin to have a symbol conflict beforehand, and it worked correctly, but don't remember the details.)