Labels view not refreshed when labels are added to a node (causing some time installer failure for ephemeral agents)

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • 2616.v07df00c08d42

      Hi,

      Took me a while to understand why tools were not installed on running agent even if the labels were set on the node.

      I happen that the https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/tools/ToolInstaller.java#L87 doesn't consider assigned labels (Typically the ones created by LabelFinder extensions). Like https://github.com/jenkinsci/platformlabeler-plugin/blob/master/src/main/java/org/jvnet/hudson/plugins/platformlabeler/PlatformLabeler.java#L40

      It's specially true of ephemeral agent and tool directive installation. Dynamic labels are assigned "too late" on the build.

      I propose to change it to (not tested)

      public boolean appliesTo(Node node) {
         Label l = Jenkins.get().getLabel(label);
         return l == null || node.getAssignedLabels().contains(l);
      }
      

       

      Any thought ?

        1. label.PNG
          label.PNG
          6 kB
        2. label2.PNG
          label2.PNG
          25 kB

            Assignee:
            Valentin Delaye
            Reporter:
            Valentin Delaye
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: