Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72711

Build History page no longer uses animated icons for builds in progress (regression in 2.434)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Jenkins : 2.445
      Material Theme Plugin (if relevant) : Version0.5.2-rc100.6121925fe229
    • 2.446, 2.440.2

      Since I upgraded to Jenins 2.445, ongoing builds show up as completed builds (no spinner around the [check mark] icon) in the Build History view (/view/all/builds) which causes confusion for users.

        1. jenknis-ui-issue.mp4
          1.21 MB
        2. screenshot-1.png
          screenshot-1.png
          398 kB
        3. screenshot-2.png
          screenshot-2.png
          114 kB

          [JENKINS-72711] Build History page no longer uses animated icons for builds in progress (regression in 2.434)

          Kevin added a comment -

          @ danielbeck On a clean install of Jenkins 2.445 (with recommended plugins) I can still reproduce this issue.

          The first time a job is ran it does display the "The project has never been built." icon and when it terminates it displays "The last build was successful." However when I run the job again instead of displaying "The last build was successful. A new build is in progress." icon it displays "The last build was successful.".

           

          The behavior is not reproducible from the job's Build History side panel. It seems to be only reproducible in "Build History of Jenkins" view.

          jenknis-ui-issue.mp4

          Kevin added a comment - @ danielbeck On a clean install of Jenkins 2.445 (with recommended plugins) I can still reproduce this issue. The first time a job is ran it does display the "The project has never been built." icon and when it terminates it displays "The last build was successful." However when I run the job again instead of displaying "The last build was successful. A new build is in progress." icon it displays "The last build was successful.".   The behavior is not reproducible from the job's Build History side panel. It seems to be only reproducible in "Build History of Jenkins" view. jenknis-ui-issue.mp4

          Daniel Beck added a comment -

          The behavior is not reproducible from the job's Build History side panel. It seems to be only reproducible in "Build History of Jenkins" view.

          Thanks for the clarification, I missed that distinction in the initial report.

          Daniel Beck added a comment - The behavior is not reproducible from the job's Build History side panel. It seems to be only reproducible in "Build History of Jenkins" view. Thanks for the clarification, I missed that distinction in the initial report.

          Daniel Beck added a comment -

          Manually bisected to 2.434, looking at the changes it's https://github.com/jenkinsci/jenkins/pull/8705 – confirmed by testing the squashed commit and its parent.

          Daniel Beck added a comment - Manually bisected to 2.434, looking at the changes it's https://github.com/jenkinsci/jenkins/pull/8705 – confirmed by testing the squashed commit and its parent.

          Daniel Beck added a comment -

          The same problem applies to buildTimeTrend (the "trend" link in a job's build history).

          Daniel Beck added a comment - The same problem applies to buildTimeTrend (the "trend" link in a job's build history).

          Rishav added a comment -

          Hi danielbeck ,

          I would like to work on this issue for my first contribution to Jenkins. I have setup the project and was able to reproduce the issue on latest version of master branch. I'll be working on it. Any information regarding where the status icons are located or which files are associated with the issue, would be great!

          Rishav added a comment - Hi danielbeck , I would like to work on this issue for my first contribution to Jenkins. I have setup the project and was able to reproduce the issue on latest version of master branch. I'll be working on it. Any information regarding where the status icons are located or which files are associated with the issue, would be great!

          Daniel Beck added a comment -

          devrish Thanks for your interest in contributing, but I had already started on this one before your comment and just saw it now.

          In this case, https://github.com/jenkinsci/jenkins/pull/8705#discussion_r1416281388 pointed me in the right direction.

          Daniel Beck added a comment - devrish Thanks for your interest in contributing, but I had already started on this one before your comment and just saw it now. In this case, https://github.com/jenkinsci/jenkins/pull/8705#discussion_r1416281388 pointed me in the right direction.

          Rishav added a comment -

          Ok, Thanks!

          Rishav added a comment - Ok, Thanks!

          Mark Waite added a comment - - edited

          devrish refer to friendly issues for those issues that are more likely to be good for a new contributor.

          Mark Waite added a comment - - edited devrish refer to friendly issues for those issues that are more likely to be good for a new contributor.

          efo plo added a comment - - edited

          danielbeck Don't know if related, but the spinning icons look off center anytime I'm not on 100% magnification (Safari/Mac),

          Above 100% the rotation is within the circle but not happening around the circle center:

          Under 100% the rotation is outside the circle so most of time no spinning is seen at all:

          It's not happening only in "Icon Legend" screen but on any screen having the animation.

          Let me know if I should open a new issue. Thanks!

          efo plo added a comment - - edited danielbeck Don't know if related, but the spinning icons look off center anytime I'm not on 100% magnification (Safari/Mac), Above 100% the rotation is within the circle but not happening around the circle center: Under 100% the rotation is outside the circle so most of time no spinning is seen at all: It's not happening only in "Icon Legend" screen but on any screen having the animation. Let me know if I should open a new issue. Thanks!

          Daniel Beck added a comment -

          eplodn1 Please open a separate issue. Make sure to mention whether this is specific to these views, or whether it also affects, e.g., list views or build history views.

          Daniel Beck added a comment - eplodn1 Please open a separate issue. Make sure to mention whether this is specific to these views, or whether it also affects, e.g., list views or build history views.

            danielbeck Daniel Beck
            ryuu Kevin
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: