Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7285

Allow the combination filter to accept parameter values

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: matrix-project-plugin
    • Labels:
      None
    • Environment:
      Seen on Windows 2008R2, running Hudson 1.371. Pretty sure it applies to any OS.
    • Similar Issues:

      Description

      It would be nice if the Combination Filter of a multi-configuration/matrix job could be specified via a parameter, or to have the contents of a parameter inserted into a part of an existing Combination Filter. The typical $PARAM notation could be used.

      We have a large matrix of configuration, taking several hours to run. If one configuration fails, it would be nice to go back and test just that configuration. Hudson-5623 (http://issues.jenkins-ci.org/browse/JENKINS-5623) addresses this same issue. But if that particular issue is too difficult to implement, a configuration Combination Filter would work for us.

      We could use a separate up-stream job to get the information from the user about which configuration to run again, then pass it to the matrix job as a parameter that could be used in the Combination Filter to directly target that one configuration.

        Attachments

          Activity

          Hide
          olivergondza Oliver Gondža added a comment -

          This feature was broken again in 1.536 (https://github.com/jenkinsci/jenkins/commit/5b639ae0339ae0507119807e1841d8253d4fbd93). Combination filter with parameters seems always evaluate to true.

          Show
          olivergondza Oliver Gondža added a comment - This feature was broken again in 1.536 ( https://github.com/jenkinsci/jenkins/commit/5b639ae0339ae0507119807e1841d8253d4fbd93 ). Combination filter with parameters seems always evaluate to true.
          Show
          olivergondza Oliver Gondža added a comment - - edited https://github.com/jenkinsci/jenkins/pull/1015
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java
          core/src/main/java/hudson/matrix/FilterScript.java
          core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java
          http://jenkins-ci.org/commit/jenkins/d7c016b881a82be939401e4e0a31f85e09e008e4
          Log:
          [FIXED JENKINS-7285] Fix regression from 1.536

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java core/src/main/java/hudson/matrix/FilterScript.java core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java http://jenkins-ci.org/commit/jenkins/d7c016b881a82be939401e4e0a31f85e09e008e4 Log: [FIXED JENKINS-7285] Fix regression from 1.536
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java
          core/src/main/java/hudson/matrix/FilterScript.java
          core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java
          http://jenkins-ci.org/commit/jenkins/58ee9395cfddabc08af3a323b308847bccf3fc61
          Log:
          Merge pull request #1015 from olivergondza/fix-7285

          [FIXED JENKINS-7285] Fix regression from 1.536

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java core/src/main/java/hudson/matrix/FilterScript.java core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java http://jenkins-ci.org/commit/jenkins/58ee9395cfddabc08af3a323b308847bccf3fc61 Log: Merge pull request #1015 from olivergondza/fix-7285 [FIXED JENKINS-7285] Fix regression from 1.536
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3055
          [FIXED JENKINS-7285] Fix regression from 1.536 (Revision d7c016b881a82be939401e4e0a31f85e09e008e4)

          Result = SUCCESS
          ogondza : d7c016b881a82be939401e4e0a31f85e09e008e4
          Files :

          • core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java
          • core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java
          • core/src/main/java/hudson/matrix/FilterScript.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3055 [FIXED JENKINS-7285] Fix regression from 1.536 (Revision d7c016b881a82be939401e4e0a31f85e09e008e4) Result = SUCCESS ogondza : d7c016b881a82be939401e4e0a31f85e09e008e4 Files : core/src/test/java/hudson/matrix/CombinationFilterUsingBuildParamsTest.java core/src/main/java/hudson/matrix/DefaultMatrixExecutionStrategyImpl.java core/src/main/java/hudson/matrix/FilterScript.java

            People

            Assignee:
            olivergondza Oliver Gondža
            Reporter:
            jswager jswager
            Votes:
            15 Vote for this issue
            Watchers:
            18 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: