Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72976

Extra logging added to console log on Maven builds and prevent Error-Prone parsing

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • maven-plugin
    • jenkins 2.440.2
      Maven Integration plugin 3.23
      Warnings Plugin 11.2.2
    • 3.24

      We are running (since years) our jenkins installation with an master on Windows server and build agent nodes on Linux. As already reported as JENKINS-55390 the output of the console log can not be parsed by the warnings plugin due to be prefixed by 'garbage extra logging' like
      [pool-1-thread-2 for channel id=140013] WARNING org.apache.maven.plugin.compiler.CompilerMojo - /opt/buildsystem/younameit/workspace/projectname/artifact/src/main/java/ag/itc/TestClass.java:[56,36] [MissingOverride] getThings implements method in AnInterface; expected @Override (see ...
      I found the comment/patch from sgabriel on JENKINS-19396 to be correct:

      "This issue still occur when running master on windows and slaves on linux" and "this can be easily corrected"

      I applied the provided patch (from pull request https://github.com/jenkinsci/maven-plugin/pull/191)  to the source of Maven Integration 3.23 and patched our installation.

      Now the cosole log looks pretty ...
      [WARNING] /opt/buildsystem/bob/workspace/projectname/artifact/src/main/java/ag/itcTestClass.java:[56,36] [MissingOverride] getThings implements method in AnInterface; expected @Override (see ...
       

      ... and the Error-Prone parser works as expected

      It would be nice if the patch/pull request from JENKINS-19396 could be finally integrated in the next release of the Maven Integration.

          [JENKINS-72976] Extra logging added to console log on Maven builds and prevent Error-Prone parsing

          Marco Rothe created issue -
          Marco Rothe made changes -
          Link New: This issue is caused by JENKINS-19396 [ JENKINS-19396 ]
          Marco Rothe made changes -
          Link New: This issue is related to JENKINS-55390 [ JENKINS-55390 ]

          Mark Waite added a comment -

          I've created a pull request that includes the changes from pull request 191 and several others and have confirmed that the problem reported in JENKINS-19396 is fixed by that change.

          The pull request will generate an incremental build of the plugin on ci.jenkins.io that you can install on your controller to confirm the fix works. Please report y our results from testing that pre-release build so that the plugin maintainers can see your results in addition to my results. They are much more likely to be persuaded to merge the pull requests when multiple users tell them that their issue is resolved by the change.

          Mark Waite added a comment - I've created a pull request that includes the changes from pull request 191 and several others and have confirmed that the problem reported in JENKINS-19396 is fixed by that change. The pull request will generate an incremental build of the plugin on ci.jenkins.io that you can install on your controller to confirm the fix works. Please report y our results from testing that pre-release build so that the plugin maintainers can see your results in addition to my results. They are much more likely to be persuaded to merge the pull requests when multiple users tell them that their issue is resolved by the change.
          Mark Waite made changes -
          Remote Link New: This issue links to "PR-323 that includes fix and several other changes (Web Link)" [ 29616 ]
          Mark Waite made changes -
          Component/s Original: warnings-ng-plugin [ 24526 ]

          Marco Rothe added a comment -

          I've tested the pre-release build (https://ci.jenkins.io/job/Plugins/job/maven-plugin/view/change-requests/job/PR-323/) resulting from your pull request PR-323 (https://github.com/jenkinsci/maven-plugin/pull/323/checks?check_run_id=23511915255) in our environment (One Windows controller, 2 Linux agents) and can confirm, that the job output is not cluttered with "[pool-1-thread- ... " anymore.

          So I hope, that the plugin maintainers will merge your PR for an next release. Thank your very much.

           

          Marco Rothe added a comment - I've tested the pre-release build ( https://ci.jenkins.io/job/Plugins/job/maven-plugin/view/change-requests/job/PR-323/) resulting from your pull request PR-323 ( https://github.com/jenkinsci/maven-plugin/pull/323/checks?check_run_id=23511915255) in our environment (One Windows controller, 2 Linux agents) and can confirm, that the job output is not cluttered with "[pool-1-thread- ... " anymore. So I hope, that the plugin maintainers will merge your PR for an next release. Thank your very much.  
          Ulli Hafner made changes -
          Assignee Original: Ulli Hafner [ drulli ]
          Labels New: help-wanted
          Basil Crow made changes -
          Released As New: 3.24
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

            Unassigned Unassigned
            marco_rothe Marco Rothe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: