Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72985

primary branch in multi-branch project no longer visually distinct (regression in 2.242)

      (core as I believe the styling is coming from there)

      In a multibranch project list view the primary branch name (often master or main for git repositories) is supposed to be visually distinct in the ListView.

      Since (unknown) the visual difference is hardly noticeable (if at all).

      in the above (from https://ci.jenkins.io/job/Core/job/jenkins/ )master is supposed to be visually distinct.
      the Source code shows that the name of the branch is wrapped in a <strong> tag however this appears to have little / no visual difference, possibly because of the change of font?

      Steps to Reproduce

      Navigate to https://ci.jenkins.io/job/Core/job/jenkins/
      Expect that the `master` branch is visually distinct in the listView from all other branches

      Actual Results

      The master branch looks almost indistinguishable from all other branches

          [JENKINS-72985] primary branch in multi-branch project no longer visually distinct (regression in 2.242)

          Daniel Beck added a comment - - edited

          https://github.com/jenkinsci/jenkins/pull/4808 looks promising as a potential culprit.

          With DOM editing I confirmed that wrapping the a in strong works as expected in 2.241, but not 2.242.

          Daniel Beck added a comment - - edited https://github.com/jenkinsci/jenkins/pull/4808 looks promising as a potential culprit. With DOM editing I confirmed that wrapping the a in strong works as expected in 2.241, but not 2.242.

          Daniel Beck added a comment - - edited

          The simpler fix is probably just switching tag nesting order in https://github.com/jenkinsci/branch-api-plugin/blob/66d6a8a932a136e9747c07ffcd210cbc5217b5f9/src/main/resources/jenkins/branch/ItemColumn/column.jelly#L38-L42, or going with a new CSS class on the a?

          Daniel Beck added a comment - - edited The simpler fix is probably just switching tag nesting order in https://github.com/jenkinsci/branch-api-plugin/blob/66d6a8a932a136e9747c07ffcd210cbc5217b5f9/src/main/resources/jenkins/branch/ItemColumn/column.jelly#L38-L42 , or going with a new CSS class on the a ?

          Jan Faracik added a comment -

          Jan Faracik added a comment - Primary branch is now bolder, https://github.com/janfaracik/branch-api-plugin/blob/4a3ebec991083aabf359bea5fd37b13f4d095724/src/main/resources/jenkins/branch/ItemColumn/column.jelly fixed it by correcting `jenkins-table_link` to `jenkins-table__link`.   https://ci.jenkins.io/job/Core/job/jenkins/

            janfaracik Jan Faracik
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: