Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72998

GuiceExtensionFinder does not correctly pick up new GuiceExtensionAnnotation

    • 2.454

      Created from from from https://github.com/jenkinsci/acceptance-test-harness/issues/1526

      When a plugin that has an OptionalExtension from the variant plugin is installed at the same time as the variant plugin its OptionalExtensions are not evaluated and do not become active post the installation.

      It is expected that installing the variant plugin at the same time as any plugin that uses it should cause those extensions to be evaluated.

      Because The variant plugin is itself an extension of GuiceExtensionAnnotation the ExtensionList of this type is not refreshed until after GuiceFinder has been refresh()}}ed, causing the {{OptionalExtensionProcessor from the variant plugin not to be initially loaded.

          [JENKINS-72998] GuiceExtensionFinder does not correctly pick up new GuiceExtensionAnnotation

          James Nord created issue -
          James Nord made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: James Nord [ teilo ]
          James Nord made changes -
          Description Original: placeholder from https://github.com/jenkinsci/acceptance-test-harness/issues/1526

          TL;DR until I populate this tomorrow.

          if a plugin that contributes a {{GuiceExtensionAnnotation}} is installed at the same time as a plugin that uses the new Annotation to make itself "discoverable" then the newly installed extension is not actually discovered.
          New: Created from from from https://github.com/jenkinsci/acceptance-test-harness/issues/1526

          When a plugin that has an {{OptionalExtension}} from the {{variant}} plugin is installed at the same time as the {{variant}} plugin its {{OptionalExtensions}} are not evaluated and do not become active post the installation.

          It is expected that installing the {{variant}} plugin at the same time as any plugin that uses it should cause those extensions to be evaluated.

          Because The {{variant}} plugin is itself an extension of {{GuiceExtensionAnnotation}} the ExtensionList of this type is not refreshed until after {{GuiceFinder}} has been {{refresh()}}ed, causing the {{OptionalExtensionProcessor}} from the variant plugin not to be initially loaded.
          James Nord made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          James Nord made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          James Nord made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          James Nord made changes -
          Remote Link New: This issue links to "Jenkins core PR#9157 (Web Link)" [ 29625 ]
          James Nord made changes -
          Labels New: lts-candidate
          Alexander Brandes made changes -
          Released As New: 2.454
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]
          Alexander Brandes made changes -
          Labels Original: lts-candidate New: 2.452.1-fixed

            teilo James Nord
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: