When a Jetty 12 Jenkins test harness is used (i.e., one built from the prototype branch of jenkins-test-harness), the following tests fail:

      • jenkins.plugins.http_request.HttpRequestStepTest
      • jenkins.plugins.http_request.HttpRequestTest

      Ideally a change could be found that can be delivered against the current release of Jetty 10 while also being forward compatible with Jetty 12. If not, then the PR will have to remain in draft until we release JTH with Jetty 12 support. Either way, we should prepare the PR in advance.

          [JENKINS-73136] Adapt HTTP Request for Jetty 12 (EE 8)

          Basil Crow added a comment -

          To work on this, start by adding the following (draft) changes to pom.xml, as in https://github.com/jenkinsci/github-plugin/pull/380/files:

          <!-- TODO JENKINS-73130 https://ci.jenkins.io/job/Core/job/jenkins/job/prototype/ -->
          <jenkins.version>(latest from above link)</jenkins.version>
          <!-- TODO JENKINS-73339 until in parent POM -->
          <jenkins-test-harness.version>2230.v4fa_477b_634f4</jenkins-test-harness.version>
          <maven.compiler.release>17</maven.compiler.release>
          

          This will compile and run against Jetty 12 EE 8, which will yield a slew of compilation errors. Fixing those compilation errors and getting all tests passing is the purpose of this task.

          Basil Crow added a comment - To work on this, start by adding the following (draft) changes to pom.xml , as in https://github.com/jenkinsci/github-plugin/pull/380/files: <!-- TODO JENKINS-73130 https://ci.jenkins.io/job/Core/job/jenkins/job/prototype/ --> <jenkins.version> (latest from above link) </jenkins.version> <!-- TODO JENKINS-73339 until in parent POM --> <jenkins-test-harness.version> 2230.v4fa_477b_634f4 </jenkins-test-harness.version> <maven.compiler.release> 17 </maven.compiler.release> This will compile and run against Jetty 12 EE 8, which will yield a slew of compilation errors. Fixing those compilation errors and getting all tests passing is the purpose of this task.

            borisyaoa Boris Yao
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: