Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73225

Jenkins 2.452.1 update broke links to jobs for matrix-project

      Hi,

        After updating Jenkins to version 2.254.1 and matrix project plugin version 830.v7ea_da_561b_a_34, the job build hyperlinks are not working . When I move the mouse to the link then it shows the status of the build and does not allow to click on it to go to the build. See the attached pic.

      Is it a known issue? Is there any work around?

       

      Thanks,

      --Shahzad

          [JENKINS-73225] Jenkins 2.452.1 update broke links to jobs for matrix-project

          Alberto added a comment -

          Another problem we have, that is unfortunately long-standing, is that the icon for skipped combinations is the same as the combinations that ran. I am talking about when opening a specific build, not from the job page.

          We used to have green/red opaque for passed/failed combinations that ran in this build, green/red "faded" or partly transparent for combinations that didn't run in this build but ran in some previous build, and a grey icon for combinations that were never run. Jenkins moved away from that a while back, now it's impossible to distinguish combinations that were successful because they ran in this build ("Success") versus combinations that were skipped in this build but were successful in some previous build ("Success - skipped") , because they all have the same green tick symbol. Same thing happens for failed combinations. Why not assigning the "not run" icon to skipped combinations in the build view of the matrix?

          In any case, we were able to get the old icons back using parts of the neo-light theme css, and that worked okay. The reason why I am bringing that up here is that with the new update of either Jenkins or the matrix plugin now we don't get the old icons back anymore, making it practically impossible to understand the matrix results because skipped and run combinations look the same. If it's not possible to have a "faded" equivalent of the red/green icons, could we at least use the "not run" icon for skipped combinations? It would make more sense.

          Alberto added a comment - Another problem we have, that is unfortunately long-standing, is that the icon for skipped combinations is the same as the combinations that ran. I am talking about when opening a specific build, not from the job page. We used to have green/red opaque for passed/failed combinations that ran in this build, green/red "faded" or partly transparent for combinations that didn't run in this build but ran in some previous build, and a grey icon for combinations that were never run. Jenkins moved away from that a while back, now it's impossible to distinguish combinations that were successful because they ran in this build ("Success") versus combinations that were skipped in this build but were successful in some previous build ("Success - skipped") , because they all have the same green tick symbol. Same thing happens for failed combinations. Why not assigning the "not run" icon to skipped combinations in the build view of the matrix? In any case, we were able to get the old icons back using parts of the neo-light theme css, and that worked okay. The reason why I am bringing that up here is that with the new update of either Jenkins or the matrix plugin now we don't get the old icons back anymore, making it practically impossible to understand the matrix results because skipped and run combinations look the same. If it's not possible to have a "faded" equivalent of the red/green icons, could we at least use the "not run" icon for skipped combinations? It would make more sense.

          Alberto added a comment -

          Just to clarify, I have completely removed the custom theme now, just to make sure it's not the cause of the weird display of the matrix. With or without the theme it makes no difference, it always looks like in the screenshots I sent.

          Alberto added a comment - Just to clarify, I have completely removed the custom theme now, just to make sure it's not the cause of the weird display of the matrix. With or without the theme it makes no difference, it always looks like in the screenshots I sent.

          Tim Jacomb added a comment -

          From your previous example how do you get a success skipped one? Do you add a combination filter and if so how? (I'm not a user of this plugin so clear instructions will help)

          Tim Jacomb added a comment - From your previous example how do you get a success skipped one? Do you add a combination filter and if so how? (I'm not a user of this plugin so clear instructions will help)

          Tim Jacomb added a comment -

          I've created a PR for the table spacing: https://github.com/jenkinsci/matrix-project-plugin/pull/201

          Doesn't this sort of matrix add a lot of load to your instance? Saving the job took minutes for me and restarting Jenkins was really slow, I've had to delete the job so my test instance restarts in a reasonable time

          Tim Jacomb added a comment - I've created a PR for the table spacing: https://github.com/jenkinsci/matrix-project-plugin/pull/201 Doesn't this sort of matrix add a lot of load to your instance? Saving the job took minutes for me and restarting Jenkins was really slow, I've had to delete the job so my test instance restarts in a reasonable time

          config.xml

           

          I have attached a simple multi-project configuration which should reproduce the issue. Basically use need two or more "User-defined Axis" in your configuration matrix.

           

          Cheers, --Shahzad

          Shahzad MUZAFFAR added a comment - config.xml   I have attached a simple multi-project configuration which should reproduce the issue. Basically use need two or more "User-defined Axis" in your configuration matrix.   Cheers, --Shahzad

          Alberto added a comment -

          Yes, this particular matrix adds huge load, but we are okay with it for the flexibility that provides. I am sure we could create a smaller matrix that would still exhibit the same bad formatting, but I wanted to make sure you would see what we see.

          Yes, there is a Combination Filter field that can be used to "sparsify" the matrix and only run a subset of the combinations. Depending on how you set it up, the filter can react to inputs to the job so that you have a sort of dynamic filtering. It's a great way to only test subsets when the whole table is not needed. To keep things simple, you can set the combination filter to:

          Axis6=="4p"

          It will only run the odd rows of the matrix, and if you have run the full matrix before you will see that the even rows still looks like they ran but in reality they are all skipped combinations (you can see by hovering with the mouse). To see combinations marked as "not run" you must not have any record of that combination running, even from previous builds. Just delete all the builds other than the last one and you will see that the even rows are now shown as "not run".

          I hope this helps, let me know if you need more guidance.

          Alberto added a comment - Yes, this particular matrix adds huge load, but we are okay with it for the flexibility that provides. I am sure we could create a smaller matrix that would still exhibit the same bad formatting, but I wanted to make sure you would see what we see. Yes, there is a Combination Filter field that can be used to "sparsify" the matrix and only run a subset of the combinations. Depending on how you set it up, the filter can react to inputs to the job so that you have a sort of dynamic filtering. It's a great way to only test subsets when the whole table is not needed. To keep things simple, you can set the combination filter to: Axis6=="4p" It will only run the odd rows of the matrix, and if you have run the full matrix before you will see that the even rows still looks like they ran but in reality they are all skipped combinations (you can see by hovering with the mouse). To see combinations marked as "not run" you must not have any record of that combination running, even from previous builds. Just delete all the builds other than the last one and you will see that the even rows are now shown as "not run". I hope this helps, let me know if you need more guidance.

          Hi,

            I confirm that new version of matrix-project `831.v084e85a_b_4ea_d` has fixed the issue. icons are now clickable.

            We also have a large multidimensional with many no configured cells. In previous versions of matrix-project, un-configured cells in the matrix did not have any text but now we see "Not configured". This make the page size very wide, can we disable the "Not configured" text?

           

          Thanks,

          --Shahzad

           

          Shahzad MUZAFFAR added a comment - Hi,   I confirm that new version of matrix-project ` 831.v084e85a_b_4ea_d ` has fixed the issue. icons are now clickable.   We also have a large multidimensional with many no configured cells. In previous versions of matrix-project, un-configured cells in the matrix did not have any text but now we see "Not configured". This make the page size very wide, can we disable the "Not configured" text?   Thanks, --Shahzad  

          Tim Jacomb added a comment -

          Tim Jacomb added a comment - Try https://github.com/jenkinsci/matrix-project-plugin/releases/tag/832.va_66e270d2946 please

          Thanks timja , 832.va_66e270d2946 looks much better. 

          Feel free to close this ticket.

           

          Cheers, --Shahzad 

          Shahzad MUZAFFAR added a comment - Thanks timja , 832.va_66e270d2946 looks much better.  Feel free to close this ticket.   Cheers, --Shahzad 

          Alberto added a comment - - edited

          Layout improved a lot, but icons still have inconsistent alignment for some reason

          Alberto added a comment - - edited Layout improved a lot, but icons still have inconsistent alignment for some reason

            timja Tim Jacomb
            smuzaffar Shahzad MUZAFFAR
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: