-
Improvement
-
Resolution: Fixed
-
Minor
-
None
The protoLint parser currently lacks the following features
- The broken rule is missing. You cannot group, sort or filter by rule.
- Severity is hard coded to Severity.WARNING_NORMAL. ProtoLint now supports different severities which should also be displayed in jenkins.
- In the report the filename of every failure is relative to the working dir of protolint executable. In case you call protolint multiple times in your build process (e.g. in different maven modules with the maven module as working dir) you will have multiple reports with filenames relatives to different directories. It is difficult to get this properly integrated and displayed in jenkins via warnings-ng-plugin. You could infer the basedir from the report file path but this is a bit itschy. I think adding a base dir property to the report or putting absolute filename in the report is a better idea.
I created an protolint issue (https://github.com/yoheimuta/protolint/issues/414) and created a pull request (https://github.com/yoheimuta/protolint/pull/415).
I will also create a corresponding pull request for the required adaptions to the protoLint parser here as well.
- links to
[JENKINS-73363] ProtoLint Parser Enhancements
Feel free to go ahead. When you change the file format then it makes more senes to create a new parser. Then we can create a composite parser that runs with both parsers. Otherwise existing users will get into problems.
Created pull request: https://github.com/jenkinsci/analysis-model/pull/1075
Implementation note:
ProtoLint currently supports different report formats. The ProtoLint parser currently reads the plain text format. I would propose to switch and parse the JSON format.