Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73473

"Build Review" page should be updated to include "update"

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • p4-plugin
    • None
    • Jenkins 2.452.3
      P4-Plugin 1.15.1

      1. I create myself a new multi-branch project, enter in client view mappings, etc.
      2. I enter the branch specific build, then click the "Build Review" tab on the left-hand side
      3. The page "Manual Configuration for Build" appears
      4. I have the following fields: review, change, status, pass, fail and p4.label

      With the new swarm servers and configuration, the preferred way to trigger a swarm review build is via the "update" and give it a callback URL to the swarm server. That part seems to be missing (I can't manually enter it on this page, and thus will need to do this via curl if needed be).

      Also, a nit on the documentation here. The "caveat" is that we can't really use any build-parameters without default values. That's fine, but if you plan to write the code for a light-weight checkout using the scm pipeline step, I these would need to be exposed as build-parameters (b/c without them being parameterized how are you going to ensure you have e.g. change set when you build it outside of the Build Review page??). I guess the assumption is that those parameters feed into the jenkin's p4-plugin and as long as you do the default checkout, you don't need to set them ...

      Please add "update" to the manual build review page

            Unassigned Unassigned
            enaess Eivind
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: