Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73568

FIPS tests in git plugin fail with Jenkins 2.462.1 release candidate

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • git-plugin
    • None
    • Jenkins 2.462.1-rc35045.7a_306482f65c
      Git plugin pre-release (from master branch)

      The git plugin master branch now includes two FIPS tests that check for specific conditions. That's a nice addition. Unfortunately, those tests seem to fail when the Jenkins version is more recent.

      I see the failure when I run the git plugin tests with the Jenkins 2.462.1 release candidate:

      mvn clean -Dtest=FIPS* -Djenkins.version=2.462.1-rc35045.7a_306482f65c verify
      [ERROR] hudson.plugins.git.FIPSModeUrlCheckTest.testGitSCMSourceCheck -- Time elapsed: 0.125 s <<< ERROR!
      org.jvnet.hudson.reactor.ReactorException: java.lang.Error: java.lang.reflect.InvocationTargetException
              at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:290)
              at jenkins.InitReactorRunner.run(InitReactorRunner.java:49)
              at jenkins.model.Jenkins.executeReactor(Jenkins.java:1210)
              at jenkins.model.Jenkins.<init>(Jenkins.java:997)
              at hudson.model.Hudson.<init>(Hudson.java:86)
              at org.jvnet.hudson.test.JenkinsRule.newHudson(JenkinsRule.java:746)
              at org.jvnet.hudson.test.JenkinsRule.before(JenkinsRule.java:408)
              at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:649)
              at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
              at java.base/java.lang.Thread.run(Thread.java:840)
      Caused by: java.lang.Error: java.lang.reflect.InvocationTargetException
              at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:115)
              at hudson.init.TaskMethodFinder$TaskImpl.run(TaskMethodFinder.java:185)
              at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:305)
              at jenkins.model.Jenkins$5.runTask(Jenkins.java:1175)
              at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:221)
              at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:120)
              at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
              at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
              at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
              ... 1 more
      Caused by: java.lang.reflect.InvocationTargetException
              at java.base/java.lang.reflect.Method.invoke(Method.java:569)
              at hudson.init.TaskMethodFinder.invoke(TaskMethodFinder.java:109)
              ... 9 more
      Caused by: java.lang.IllegalStateException: The eddsa-api plugin is not FIPS compliant and can not be used in a Jenkins configured to run in FIPS-140 mode
              at PluginClassLoader for eddsa-api//io.jenkins.plugins.eddsa_api.FIPSComplianceCheck.preventUsageInFipsMode(FIPSComplianceCheck.java:15)
              ... 11 more
      

      I'd like to release a new version of the git plugin soon, but we need to find a way to allow those tests to pass with the Jenkins 2.462.1 release in addition to the Jenkins versions that are already being tested.

          [JENKINS-73568] FIPS tests in git plugin fail with Jenkins 2.462.1 release candidate

          Mark Waite added a comment -

          Temporary workaround merged in order to allow a test of the master branch with plugin BOM

          Mark Waite added a comment - Temporary workaround merged in order to allow a test of the master branch with plugin BOM

          Olivier Lamy added a comment -

          I will propose another PR which keep those tests running even with newer versions

          Olivier Lamy added a comment - I will propose another PR which keep those tests running even with newer versions

          Mark Waite added a comment -

          Thanks! I've confirmed that the tests based on RealJenkinsRule are passing in a draft pull request to the plugin BOM. There is a failure in the plugin BOM that will need more investigation, but it is unrelated to the tests in the git plugin as far as I can tell.

          The failure message that I'll be investigating is:

          $ LINE=2.440.x PLUGINS=pipeline-model-definition  TEST=InjectedTest bash local-test.sh
          
          Caused by: java.io.IOException: Failed to load: Git plugin (git 5.3.0-rc5283.29a_5456289b_2)
           - Update required: Matrix Project Plugin (matrix-project 822.824.v14451b_c0fd42) to be updated to 832.va_66e270d2946 or higher
                  at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:988)
                  at hudson.PluginManager$2$1$1.run(PluginManager.java:552)
          
          [ERROR] Failures:
          [ERROR]   InjectedTest.testPluginActive While testing pipeline-model-definition, git failed to start
          

          Mark Waite added a comment - Thanks! I've confirmed that the tests based on RealJenkinsRule are passing in a draft pull request to the plugin BOM. There is a failure in the plugin BOM that will need more investigation, but it is unrelated to the tests in the git plugin as far as I can tell. The failure message that I'll be investigating is: $ LINE=2.440.x PLUGINS=pipeline-model-definition TEST=InjectedTest bash local-test.sh Caused by: java.io.IOException: Failed to load: Git plugin (git 5.3.0-rc5283.29a_5456289b_2) - Update required: Matrix Project Plugin (matrix-project 822.824.v14451b_c0fd42) to be updated to 832.va_66e270d2946 or higher at hudson.PluginWrapper.resolvePluginDependencies(PluginWrapper.java:988) at hudson.PluginManager$2$1$1.run(PluginManager.java:552) [ERROR] Failures: [ERROR] InjectedTest.testPluginActive While testing pipeline-model-definition, git failed to start

            olamy Olivier Lamy
            markewaite Mark Waite
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: