Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74008

[warnings-ng] Extract JavaScript block in SourceDetail/index.jelly

        [JENKINS-74008] [warnings-ng] Extract JavaScript block in SourceDetail/index.jelly

        Yaroslav Afenkin added a comment - - edited

        I suspect this whole view may be unused. Instead https://github.com/jenkinsci/prism-api-plugin/blob/3325f6ab11459f58448f6770e456e8afe3beebb4/src/main/resources/io/jenkins/plugins/prism/SourceCodeViewModel/index.jelly is used. Or perhaps these are separate from each other, I'm unsure.

        drulli, I would appreciate your input here, please let know if I'm wrong.

        I've checked the class name, and it looks like it might be related to the analysis-core plugin (https://github.com/jenkinsci/analysis-core-plugin/blob/07ea7c8ec8d3802cf07f221b24fcbf363111973d/src/main/java/hudson/plugins/analysis/views/SourceDetail.java#L41), the distribution of which has been suspended as per https://github.com/jenkins-infra/helpdesk/issues/2089.

        Yaroslav Afenkin added a comment - - edited I suspect this whole view may be unused. Instead https://github.com/jenkinsci/prism-api-plugin/blob/3325f6ab11459f58448f6770e456e8afe3beebb4/src/main/resources/io/jenkins/plugins/prism/SourceCodeViewModel/index.jelly is used. Or perhaps these are separate from each other, I'm unsure. drulli , I would appreciate your input here, please let know if I'm wrong. I've checked the class name, and it looks like it might be related to the analysis-core plugin ( https://github.com/jenkinsci/analysis-core-plugin/blob/07ea7c8ec8d3802cf07f221b24fcbf363111973d/src/main/java/hudson/plugins/analysis/views/SourceDetail.java#L41), the distribution of which has been suspended as per https://github.com/jenkins-infra/helpdesk/issues/2089 .

        Basil Crow added a comment -

        Perhaps one way to start the conversation would be a PR to remove the dead code. Then, if accepted, this ticket can be closed. If not accepted, the conversation should be illuminating.

        Basil Crow added a comment - Perhaps one way to start the conversation would be a PR to remove the dead code. Then, if accepted, this ticket can be closed. If not accepted, the conversation should be illuminating.

        Basil Crow added a comment -

        Basil Crow added a comment - Fixed in jenkinsci/warnings-ng-plugin#1884 . Released in v11.12.0 .

          yafenkin Yaroslav Afenkin
          yafenkin Yaroslav Afenkin
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

            Created:
            Updated:
            Resolved: