Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74431

[electricflow] Extract inline script block and event handlers in org/jenkinsci/plugins/electricflow/ElectricFlowRunProcedure/config.jelly

XMLWordPrintable

      Problems

      == Inline Script Block
      Line: 67
      ----
      <script>
              fillProcedureParameters();
      
              function deleteProcedureParameterRows() {
                  var paramRows = document.querySelectorAll("._ef_rp_row");
                  [].forEach.call(paramRows, function (row) {
                      row.parentNode.removeChild(row);
                  });
              }
      
              function fillProcedureParameters() {
                  deleteProcedureParameterRows();
      
                  if (!document.getElementById('ef_rp_parameters')) {
                      return;
                  }
      
                  var option = document.getElementById('ef_rp_parameters').options[0];
                  var param = '{}';
                  if (option) {
                      param = option.value;
                  }
                  var json = JSON.parse(param);
      
                  var table = document.querySelector("[descriptorid='electricFlowRunProcedure'] table");
                  if (table == null) {
                      table = getElementByXpath("//select[@checkdependson='validationTrigger']/ancestor::table[@name]");
                  }
      
                  if (json) {
      
                      if (json.procedure) {
                          var parameters;
                          try {
                              parameters = JSON.parse(json.procedure.parameters);
                          }
                          catch (error) {
                              parameters = json.procedure.parameters;
                          }
      
                          if (table == null) {
                              if (parameters.length) {
                                  var el = document.createElement("div");
                                  el.innerHTML = "&lt;br&gt;&lt;b&gt;Procedure Parameters&lt;/b&gt;";
                                  el.className = "_ef_rp_row";
                                  var div = document.getElementById("ef_rp_procedureName");
                                  div = cbcd_insertAfter(div, el);
                                  parameters.forEach(function (elem) {
                                      var el_param = document.createElement("div");
                                      el_param.className = "_ef_rp_parameters _ef_rp_row";
                                      div = cbcd_insertAfter(div, el_param);
                                      addParameterRowForRunProcedure(el_param, elem.actualParameterName, elem.value, false, false);
                                  });
                              }
                          } else {
                              var row1 = table.insertRow(table.rows.length - 2);
                              row1.className = "_ef_rp_row";
                              if (parameters.length) {
                                  row1.appendChild(createTitleForRunProcedure("Procedure Parameters"));
                                  parameters.forEach(function (elem) {
                                      var row = table.insertRow(table.rows.length - 2);
                                      row.className = "_ef_rp_parameters _ef_rp_row";
                                      addParameterRowForRunProcedure(row, elem.actualParameterName, elem.value, false, true);
                                  });
                              }
                          }
                      }
                  }
              }
      
              function cbcd_insertAfter(referenceNode, newNode) {
                  return referenceNode.parentNode.insertBefore(newNode, referenceNode.nextSibling);
              }
      
              function updateProcedureJson() {
                  var procedureName = document.getElementById("ef_rp_procedureName").value;
                  var json = JSON.parse('{"procedure":{"procedureName":"' + procedureName + '", "parameters":[]}}');
      
                  var parameters = document.querySelectorAll("._ef_rp_parameters");
      
                  [].forEach.call(parameters, function (elem) {
                      json.procedure.parameters.push({
                          'actualParameterName': elem.querySelector(".setting-name").textContent,
                          'value': elem.querySelector(".setting-input").value
                      })
                  });
      
      
                  document.getElementById('ef_rp_parameters').options[0].value = JSON.stringify(json);
                  document.getElementById('ef_rp_parameters').options[0].textContent = JSON.stringify(json);
              }
      
              function createTitleForRunProcedure(title) {
                  var td = document.createElement('td');
                  td.colSpan = 4;
                  var div = document.createElement('div');
                  div.className = "section-header";
                  div.textContent = title;
                  td.appendChild(div);
                  return td;
              }
      
              function addParameterRowForRunProcedure(row, label, value, isCheckbox, isTable) {
                  var td1 = document.createElement(isTable ? 'td' : 'div');
                  td1.className = 'setting-leftspace';
                  td1.textContent = '';
                  row.appendChild(td1);
      
                  var td2 = document.createElement(isTable ? 'td' : 'div');
                  td2.className = 'setting-name';
                  td2.textContent = label;
                  row.appendChild(td2);
      
                  var td3 = document.createElement(isTable ? 'td' : 'div');
                  td3.className = 'setting-main';
                  var input1 = document.createElement('input');
                  input1.name = 'parameterName';
                  if (isCheckbox) {
                      input1.type = "checkbox";
                      if (value === "true") {
                          input1.checked = value;
                      }
                      input1.style = "width: auto;";
                  }
                  input1.value = value;
                  input1.onchange = updateProcedureJson;
                  input1.className = 'setting-input';
                  td3.appendChild(input1);
                  row.appendChild(td3);
      
                  var td4 = document.createElement(isTable ? 'td' : 'div');
                  td4.className = 'setting-no-help';
                  row.appendChild(td4);
              }
      
              function triggerExtraValidationForRunProcedure() {
                  document.getElementById("ef_rp_validationTrigger").click();
              }
      
              function getElementByXpath(path) {
                  return document.evaluate(path, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null).singleNodeValue;
              }
          </script>
      ----
      
      == Inline Event Handler
      Line: 13
      ----
      <f:select onchange="deleteProcedureParameterRows()"/>
      ----
      
      == Inline Event Handler
      Line: 18
      ----
      <f:select onchange="deleteProcedureParameterRows()"/>
      ----
      
      == Inline Event Handler
      Line: 21
      ----
      <f:select id="ef_rp_procedureName" onchange="deleteProcedureParameterRows()"/>
      ----
      
      == Inline Event Handler
      Line: 24
      ----
      <f:select id="ef_rp_parameters" onchange="fillProcedureParameters()" style="display:none;"/>
      ----
      
      == Inline Event Handler
      Line: 56
      ----
      <button type="button" onclick="triggerExtraValidationForRunProcedure();">
      ----
      

      Solutions

      https://www.jenkins.io/doc/developer/security/csp/#inline-javascript-blocks
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

            shlomo_dahan Shlomo
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: