It seems this error is due to the buildsByBranchName Hashmap in the hudson.plugins.git.util.BuildData action gets in a state where a key is null:

println(Hudson.getInstance().getItem("EXPERIMENTAL_Gerrit_Trigger_2").getBuildByNumber(13).getAction(hudson.plugins.git.util.BuildData).buildsByBranchName);

null:Build #13 of Revision 0f566fdae8a0a3fb06780a976ac41bc97b138383 (null)

Hudson.getInstance().getItem("EXPERIMENTAL_Gerrit_Trigger_2").getBuildByNumber(13).save();

java.lang.RuntimeException: Failed to serialize hudson.model.Actionable#actions for class hudson.model.FreeStyleBuild
at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:167)
at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:135)

If I clear buildsByBranchName, everything is OK:

Hudson.getInstance().getItem("EXPERIMENTAL_Gerrit_Trigger_2").getBuildByNumber(13).getAction(hudson.plugins.git.util.BuildData).buildsByBranchName.clear();
Hudson.getInstance().getItem("EXPERIMENTAL_Gerrit_Trigger_2").getBuildByNumber(13).save();

<SUCCESS>

The error in http://issues.jenkins-ci.org/browse/JENKINS-7330 seems also to depend on changes in the serialization logic in 1.374, making Hudson suddenly not accepting a null-string. So I guess they are indeed connected. Maybe we can achieve a similar patch for the GIT-plugin?

Ok - looks like changing from HashMap to TreeMap would fix that, but it'll need to translate past builds at upgrade time. Let me write up a patch and send you a link to the hpi to test.

Integrated in plugins_hudson-git-plugin #24
JENKINS-7446 First attempt at getting rid of null keys in buildsByBranchName.

Andrew Bayer :
Files :

• src/main/java/hudson/plugins/git/util/BuildData.java

Actually, even simpler - just a readResolve to switch null keys to "" keys and then some checks to make sure we didn't add new null keys. You can grab the hpi at http://ci.hudson-labs.org/job/plugins_hudson-git-plugin/24/org.jvnet.hudson.plugins$git/

Great!
Will do some tests first thing tomorrow morning.

The patch work great! Thanks, abayer! However, the GIT build action shows an empty bullet point. Is this supposed to happen? (Not sure if it is related to the patch)

Screen attached.

File attached.

Lemme see if I can figure that out - I'm guessing that's a side effect of the "" key rather than null key.

Got it! It was exactly that - I've fixed it now for both BuildData displays - check for the next build after #24 at http://ci.hudson-labs.org/job/plugins_hudson-git-plugin/lastSuccessfulBuild/

Resolved in 1.1.