Fix CSP finding on NodesController#doMonitoring placeholder page

XMLWordPrintable

    • Type: Task
    • Resolution: Unresolved
    • Priority: Minor
    • Component/s: monitoring-plugin
    • None

      https://github.com/jenkinsci/monitoring-plugin/blob/78438d70b775219dee5f770bd3bdd7038a8f5598/src/main/java/net/bull/javamelody/NodesController.java#L162 is inline JS that would break with https://github.com/jenkinsci/jenkins/pull/11269

      However, this page is currently broken:

      Forcing during debugging does not set a content-type header, so raw HTML is displayed at least in mvn hpi:run.

      In a normal (Docker) deployment, running

      Jenkins.get().pluginManager.getPlugin('monitoring').plugin.filter.nodesCollector.lastJavaInformationsList.clear()
      System.setProperty('javamelody.nodes-monitoring-disabled', "true") 

      and then accessing e.g. http://localhost:8080/monitoring/nodes?part=graph&graph=buildsMeanTimes directly, will download the file.

       

            Assignee:
            Daniel Beck
            Reporter:
            Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: