• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • Hudson 1.367 running on a CentOS 5.2 OS inside a Tomcat 6.0.18 container connected to Apache 2.2.3 using mod_jk

      Not sure if it was intentionally done this way or not, but sidebar mailto: links do not appear to work for me.

      When I enter

      mailto:user@company.com

      in the "Link URL" text box, the link appears to be interpreted as a relative link and is rendered as

      http://hudsonserver.company.com/hudson/mailto:user@company.com

      in the actual link in the sidebar.

      Super awesome bonus points awarded for implementing mailto: links in a robot-unfriendly way. One possible way might be to obfuscate mailto: address and store it into a javascript variable or array and deobfuscate with Javascript function when link is clicked so that the email addresses cannot be scraped by a robot for public-facing sites. There are probably many other ways to approach this. I don't particularly need this functionality since my Hudson instance is internally facing only, but I thought it might be a "nice to have" for others.

      Thanks for a great plugin!

          [JENKINS-7725] Support mailto: links

          Doug Borg added a comment -

          Fixing links with "

          
          

          "

          Doug Borg added a comment - Fixing links with " "

          Doug Borg added a comment -

          I have a work-around in place for this issue which may be helpful for others. I link to a page containing the following html:

          <html>
                  <head>
                          <meta HTTP-EQUIV="REFRESH" content="0; url=mailto:user@company.com" />
                  </head>
          </html>
          

          This may partially solve the robot-unfriendly issue as well. I still think it would be helpful for the sidebar-links plugin to support mailto: out of the box though.

          Doug Borg added a comment - I have a work-around in place for this issue which may be helpful for others. I link to a page containing the following html: <html> <head> <meta HTTP-EQUIV= "REFRESH" content= "0; url=mailto:user@company.com" /> </head> </html> This may partially solve the robot-unfriendly issue as well. I still think it would be helpful for the sidebar-links plugin to support mailto: out of the box though.

          Marcus Better added a comment -

          Please make it support any URIs, even private or platform-specific URI schemes. It is not hard to check if the input is a URI, and use it unmodified in that case.

          Marcus Better added a comment - Please make it support any URIs, even private or platform-specific URI schemes. It is not hard to check if the input is a URI, and use it unmodified in that case.

          Alan Harder added a comment -

          sidebar-link plugin simply gives Jenkins the link you specify. mailto: does not work because the code in core to identify an absolute url assumes // will be after the : (see https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/Functions.java#L1326).. assigning issue to core.

          Alan Harder added a comment - sidebar-link plugin simply gives Jenkins the link you specify. mailto: does not work because the code in core to identify an absolute url assumes // will be after the : (see https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/Functions.java#L1326 ).. assigning issue to core.

          OHTAKE Tomohiro added a comment - I have sent a pull request. https://github.com/jenkinsci/jenkins/pull/266

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/9887593d10610587df66cf894e3e1656a0710556
          Log:
          changelog entry for JENKINS-7725

          Compare: https://github.com/jenkinsci/jenkins/compare/a834807...9887593

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/9887593d10610587df66cf894e3e1656a0710556 Log: changelog entry for JENKINS-7725 Compare: https://github.com/jenkinsci/jenkins/compare/a834807...9887593

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1252
          [FIXED JENKINS-7725] mailto: links should be absolute URIs
          changelog entry for JENKINS-7725

          ohtake.tomohiro : 47f70c0f595864274993401300924347b9307641
          Files :

          • core/src/test/java/hudson/FunctionsTest.java
          • core/src/main/java/hudson/Functions.java

          Christoph Kutzinski : 9887593d10610587df66cf894e3e1656a0710556
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #1252 [FIXED JENKINS-7725] mailto: links should be absolute URIs changelog entry for JENKINS-7725 ohtake.tomohiro : 47f70c0f595864274993401300924347b9307641 Files : core/src/test/java/hudson/FunctionsTest.java core/src/main/java/hudson/Functions.java Christoph Kutzinski : 9887593d10610587df66cf894e3e1656a0710556 Files : changelog.html

          Oleg Nenashev added a comment -

          Fixed in jenkins-1.438

          Oleg Nenashev added a comment - Fixed in jenkins-1.438

            Unassigned Unassigned
            dougborg Doug Borg
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: