Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7961

Monitoring external jobs doesn't work with CSRF protection enabled.

    XMLWordPrintable

Details

    Description

      Monitoring an external job (described at http://wiki.jenkins-ci.org/display/JENKINS/Monitoring+external+jobs) doesn't work if the Hudson instance has CSRF protection enabled, because the cli doesn't retrieve a crumb before attempting to submit the result. An example solution is described in one of the blue boxes at <http://wiki.jenkins-ci.org/display/JENKINS/Subversion+Plugin>. I'll attach a patch that uses this trick to fix the problem.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          davidreiss davidreiss created issue -
          davidreiss davidreiss made changes -
          Field Original Value New Value
          Attachment hudson-external-crumb.patch [ 19913 ]
          mindless Alan Harder made changes -
          Assignee mindless [ mindless ]
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/Main.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/36678
          Log:
          [FIXED JENKINS-7961] support CSRF protection when submitting results
          of external job; patch from davidreiss with 1 minor addition.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/Main.java trunk/www/changelog.html http://jenkins-ci.org/commit/36678 Log: [FIXED JENKINS-7961] support CSRF protection when submitting results of external job; patch from davidreiss with 1 minor addition.
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          dogfood dogfood added a comment -

          Integrated in hudson_main_trunk #383
          [FIXED JENKINS-7961] support CSRF protection when submitting results
          of external job; patch from davidreiss with 1 minor addition.

          mindless :
          Files :

          • /trunk/www/changelog.html
          • /trunk/hudson/main/core/src/main/java/hudson/Main.java
          dogfood dogfood added a comment - Integrated in hudson_main_trunk #383 [FIXED JENKINS-7961] support CSRF protection when submitting results of external job; patch from davidreiss with 1 minor addition. mindless : Files : /trunk/www/changelog.html /trunk/hudson/main/core/src/main/java/hudson/Main.java
          jglick Jesse Glick made changes -
          Component/s external-monitor-job [ 17123 ]
          Component/s core [ 15593 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 138064 ] JNJira + In-Review [ 187821 ]

          People

            mindless Alan Harder
            davidreiss davidreiss
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: