Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8358

A disabled project is always DISABLED even is the project is building

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      When a project is disabled, still it can execute a build.
      In the eXtreme Feedback panel it is shown as not building.

      The reason:
      hudson.model.AbstractProject.getIconColor()
      public BallColor getIconColor()
      {
      if (isDisabled())

      { return BallColor.DISABLED; }

      return super.getIconColor();
      }

      This can be changed to:

      BallColor normalColor = super.getIconColor();
      if(isDisabled())
      {
      if(normalColor.isAnimated())

      { return BallColor.DISABLED_ANIME; }

      return BallColor.DISABLED;
      }
      return normalColor;

      We use disable project to let a project finish his job and then take action on that job and prevent a next build is started.
      The eXtreme feedback panel does not help us right now to see if the job is finished.

          [JENKINS-8358] A disabled project is always DISABLED even is the project is building

          Daniel Beck added a comment -

          Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1249

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/916340750e5b1588248a92e7d6730c62e5978552
          Log:
          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/916340750e5b1588248a92e7d6730c62e5978552 Log: [FIX JENKINS-8358] Use DISABLED_ANIME icon while building

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/d5fc738e636f74856b95ddb26417a0c2ae020dfa
          Log:
          Merge pull request #1249 from daniel-beck/JENKINS-8358

          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building

          Compare: https://github.com/jenkinsci/jenkins/compare/c5158d228b9f...d5fc738e636f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/d5fc738e636f74856b95ddb26417a0c2ae020dfa Log: Merge pull request #1249 from daniel-beck/ JENKINS-8358 [FIX JENKINS-8358] Use DISABLED_ANIME icon while building Compare: https://github.com/jenkinsci/jenkins/compare/c5158d228b9f...d5fc738e636f

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3419
          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building (Revision 916340750e5b1588248a92e7d6730c62e5978552)

          Result = SUCCESS
          daniel-beck : 916340750e5b1588248a92e7d6730c62e5978552
          Files :

          • core/src/main/java/hudson/model/AbstractProject.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3419 [FIX JENKINS-8358] Use DISABLED_ANIME icon while building (Revision 916340750e5b1588248a92e7d6730c62e5978552) Result = SUCCESS daniel-beck : 916340750e5b1588248a92e7d6730c62e5978552 Files : core/src/main/java/hudson/model/AbstractProject.java

          Daniel Beck added a comment -

          Fixed in 1.567

          Daniel Beck added a comment - Fixed in 1.567

          Cees Bos added a comment -

          Thanks!

          Cees Bos added a comment - Thanks!

            danielbeck Daniel Beck
            cbos Cees Bos
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: