Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8358

A disabled project is always DISABLED even is the project is building

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      When a project is disabled, still it can execute a build.
      In the eXtreme Feedback panel it is shown as not building.

      The reason:
      hudson.model.AbstractProject.getIconColor()
      public BallColor getIconColor()
      {
      if (isDisabled())

      { return BallColor.DISABLED; }

      return super.getIconColor();
      }

      This can be changed to:

      BallColor normalColor = super.getIconColor();
      if(isDisabled())
      {
      if(normalColor.isAnimated())

      { return BallColor.DISABLED_ANIME; }

      return BallColor.DISABLED;
      }
      return normalColor;

      We use disable project to let a project finish his job and then take action on that job and prevent a next build is started.
      The eXtreme feedback panel does not help us right now to see if the job is finished.

        Attachments

          Activity

          Show
          danielbeck Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1249
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/916340750e5b1588248a92e7d6730c62e5978552
          Log:
          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/916340750e5b1588248a92e7d6730c62e5978552 Log: [FIX JENKINS-8358] Use DISABLED_ANIME icon while building
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/d5fc738e636f74856b95ddb26417a0c2ae020dfa
          Log:
          Merge pull request #1249 from daniel-beck/JENKINS-8358

          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building

          Compare: https://github.com/jenkinsci/jenkins/compare/c5158d228b9f...d5fc738e636f

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/d5fc738e636f74856b95ddb26417a0c2ae020dfa Log: Merge pull request #1249 from daniel-beck/ JENKINS-8358 [FIX JENKINS-8358] Use DISABLED_ANIME icon while building Compare: https://github.com/jenkinsci/jenkins/compare/c5158d228b9f...d5fc738e636f
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3419
          [FIX JENKINS-8358] Use DISABLED_ANIME icon while building (Revision 916340750e5b1588248a92e7d6730c62e5978552)

          Result = SUCCESS
          daniel-beck : 916340750e5b1588248a92e7d6730c62e5978552
          Files :

          • core/src/main/java/hudson/model/AbstractProject.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3419 [FIX JENKINS-8358] Use DISABLED_ANIME icon while building (Revision 916340750e5b1588248a92e7d6730c62e5978552) Result = SUCCESS daniel-beck : 916340750e5b1588248a92e7d6730c62e5978552 Files : core/src/main/java/hudson/model/AbstractProject.java
          Hide
          danielbeck Daniel Beck added a comment -

          Fixed in 1.567

          Show
          danielbeck Daniel Beck added a comment - Fixed in 1.567
          Hide
          cbos Cees Bos added a comment -

          Thanks!

          Show
          cbos Cees Bos added a comment - Thanks!

            People

            Assignee:
            danielbeck Daniel Beck
            Reporter:
            cbos Cees Bos
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: