Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9009

Slave name with a quote breaks matrix build label axis

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If a slave has a name with a single quote ('), the label axis option for a matrix build fails to render (blank panel).

        Attachments

          Activity

          Hide
          seanhoughton seanhoughton added a comment -

          Verified. I had a bunch of nodes named like "Sean's Workstation" and removing the apostrophe fixes the missing panel. I would bump up the priority given that this makes matrix builds non-functional and there is no hint as to how to fix it. I've been avoiding matrix builds for almost a year because I thought they were broken.

          Show
          seanhoughton seanhoughton added a comment - Verified. I had a bunch of nodes named like "Sean's Workstation" and removing the apostrophe fixes the missing panel. I would bump up the priority given that this makes matrix builds non-functional and there is no hint as to how to fix it. I've been avoiding matrix builds for almost a year because I thought they were broken.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/Functions.java
          core/src/main/java/hudson/matrix/LabelAxis.java
          core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
          test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
          http://jenkins-ci.org/commit/jenkins/f46e44bbafb6de5c1757f63b8e3447a4743686ec
          Log:
          [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build
          label axis

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/Functions.java core/src/main/java/hudson/matrix/LabelAxis.java core/src/main/resources/hudson/matrix/LabelAxis/config.jelly test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy http://jenkins-ci.org/commit/jenkins/f46e44bbafb6de5c1757f63b8e3447a4743686ec Log: [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build label axis
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #659
          [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build

          Kohsuke Kawaguchi : f46e44bbafb6de5c1757f63b8e3447a4743686ec
          Files :

          • core/src/main/java/hudson/Functions.java
          • test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
          • core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
          • core/src/main/java/hudson/matrix/LabelAxis.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #659 [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build Kohsuke Kawaguchi : f46e44bbafb6de5c1757f63b8e3447a4743686ec Files : core/src/main/java/hudson/Functions.java test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy core/src/main/resources/hudson/matrix/LabelAxis/config.jelly core/src/main/java/hudson/matrix/LabelAxis.java changelog.html
          Hide
          jkeeling John Keeling added a comment - - edited

          I have confirmed that none of my slave names include single or double quote characters, and yet i still have an empty matrix build label axis. I'm not convinced that I've run into a defect, yet, and am hoping somebody provide me some suggestions for debugging this issue further.

          my environment:
          Windows 7
          Jenkins v1.4.15
          seeing problem on IE 8 & Firefox 4.0.1

          Show
          jkeeling John Keeling added a comment - - edited I have confirmed that none of my slave names include single or double quote characters, and yet i still have an empty matrix build label axis. I'm not convinced that I've run into a defect, yet, and am hoping somebody provide me some suggestions for debugging this issue further. my environment: Windows 7 Jenkins v1.4.15 seeing problem on IE 8 & Firefox 4.0.1
          Hide
          jkeeling John Keeling added a comment - - edited

          .

          Show
          jkeeling John Keeling added a comment - - edited .
          Hide
          jkeeling John Keeling added a comment -


          just confirmed that the problem does not occur in Jenkins v1.409.

          Show
          jkeeling John Keeling added a comment - just confirmed that the problem does not occur in Jenkins v1.409.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/Functions.java
          core/src/main/java/hudson/matrix/LabelAxis.java
          core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
          test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
          http://jenkins-ci.org/commit/jenkins/f46e44bbafb6de5c1757f63b8e3447a4743686ec
          Log:
          [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build
          label axis

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/Functions.java core/src/main/java/hudson/matrix/LabelAxis.java core/src/main/resources/hudson/matrix/LabelAxis/config.jelly test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy http://jenkins-ci.org/commit/jenkins/f46e44bbafb6de5c1757f63b8e3447a4743686ec Log: [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build label axis
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/matrix/LabelAxis.java
          core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
          test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
          http://jenkins-ci.org/commit/matrix-project-plugin/eb607367cdf55bd9612b51f799e89845d15c8791
          Log:
          [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build
          label axis

          Originally-Committed-As: f46e44bbafb6de5c1757f63b8e3447a4743686ec

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/matrix/LabelAxis.java core/src/main/resources/hudson/matrix/LabelAxis/config.jelly test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy http://jenkins-ci.org/commit/matrix-project-plugin/eb607367cdf55bd9612b51f799e89845d15c8791 Log: [FIXED JENKINS-9009] Fixed a bug in handling ' and " in matrix build label axis Originally-Committed-As: f46e44bbafb6de5c1757f63b8e3447a4743686ec

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            dmeibusch dmeibusch
            Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: