Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9397

TarArchiver and ZipArchiver don't preserve file permissions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      This is definitely true for zips, and I think it's true for tars as well - when we're creating tarballs and zipfiles, we're not actually looking at the permissions/unix mode on the files and directories going into them. As a result, the tars/zips we've created have no useful permissions set. This is particularly annoying with the clone workspace SCM plugin, where files may need to be executable for the downstream to work properly.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09
            Log:
            [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09 Log: [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/util/IOUtils.java
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            core/src/test/java/hudson/util/io/TarArchiverTest.java
            http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78
            Log:
            [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/util/IOUtils.java core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java core/src/test/java/hudson/util/io/TarArchiverTest.java http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78 Log: [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee
            Log:
            JENKINS-9397 recording the change

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee Log: JENKINS-9397 recording the change
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #696
            [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.
            [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.
            JENKINS-9397 recording the change

            Kohsuke Kawaguchi : 00485b3188236f17b4962790945ae3218de98d09
            Files :

            • core/src/main/java/hudson/util/io/Archiver.java
            • core/src/main/java/hudson/util/io/ZipArchiver.java
            • core/src/main/java/hudson/util/io/TarArchiver.java

            Kohsuke Kawaguchi : 6577d788b91a19791b6684ddeccbc50c9c563a78
            Files :

            • core/src/test/java/hudson/util/io/TarArchiverTest.java
            • core/src/main/java/hudson/util/IOUtils.java
            • core/src/main/java/hudson/util/io/ZipArchiver.java
            • core/src/main/java/hudson/FilePath.java
            • core/src/main/java/hudson/util/io/Archiver.java
            • core/src/main/java/hudson/util/io/TarArchiver.java

            Kohsuke Kawaguchi : ad92ad461159ea3320da15f9d7030cdd12d83cee
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #696 [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived. [FIXED JENKINS-9397] fixed a bug in the implementation, added tests. JENKINS-9397 recording the change Kohsuke Kawaguchi : 00485b3188236f17b4962790945ae3218de98d09 Files : core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/ZipArchiver.java core/src/main/java/hudson/util/io/TarArchiver.java Kohsuke Kawaguchi : 6577d788b91a19791b6684ddeccbc50c9c563a78 Files : core/src/test/java/hudson/util/io/TarArchiverTest.java core/src/main/java/hudson/util/IOUtils.java core/src/main/java/hudson/util/io/ZipArchiver.java core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java Kohsuke Kawaguchi : ad92ad461159ea3320da15f9d7030cdd12d83cee Files : changelog.html
            Hide
            owenmehegan Owen Mehegan added a comment - - edited

            I don't think this is fixed. I upgraded to 1.410 of Jenkins and 0.3 of the Clone Workspace plugin, but executable permissions on my files are still stripped after they are cloned.

            I set up a super simple test of this:
            1. Build 1 creates a file, runs chmod a+x on it, runs 'ls -l' so I can verify the file's perms in the console log, then archives the workspace and calls Build 2.
            2. Build 2 uses the Clone Workspace SCM option and pulls in the archived files, then runs an 'ls -l' on them.

            Before:

            -rwxr-xr-x 1 br br 0 2011-05-03 22:59 owen_test

            After:

            -rw-r--r-- 1 br br 0 2011-05-03 22:59 owen_test
            Show
            owenmehegan Owen Mehegan added a comment - - edited I don't think this is fixed. I upgraded to 1.410 of Jenkins and 0.3 of the Clone Workspace plugin, but executable permissions on my files are still stripped after they are cloned. I set up a super simple test of this: 1. Build 1 creates a file, runs chmod a+x on it, runs 'ls -l' so I can verify the file's perms in the console log, then archives the workspace and calls Build 2. 2. Build 2 uses the Clone Workspace SCM option and pulls in the archived files, then runs an 'ls -l' on them. Before: -rwxr-xr-x 1 br br 0 2011-05-03 22:59 owen_test After: -rw-r--r-- 1 br br 0 2011-05-03 22:59 owen_test
            Hide
            sogabe sogabe added a comment -

            See JENKINS-9577 about clone workspace plugin.

            Show
            sogabe sogabe added a comment - See JENKINS-9577 about clone workspace plugin.
            Hide
            dreamtime Angela Johansson added a comment - - edited

            Sorry, commented the wrong bug
            After this fix, I still have problems with both the Copy Artifact plugin AND the Clone Workspace plugin but I guess it's not related to the Archiver any more.

            Show
            dreamtime Angela Johansson added a comment - - edited Sorry, commented the wrong bug After this fix, I still have problems with both the Copy Artifact plugin AND the Clone Workspace plugin but I guess it's not related to the Archiver any more.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09
            Log:
            [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09 Log: [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/util/IOUtils.java
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            core/src/test/java/hudson/util/io/TarArchiverTest.java
            http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78
            Log:
            [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/util/IOUtils.java core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java core/src/test/java/hudson/util/io/TarArchiverTest.java http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78 Log: [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee
            Log:
            JENKINS-9397 recording the change

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee Log: JENKINS-9397 recording the change
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09
            Log:
            [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java http://jenkins-ci.org/commit/jenkins/00485b3188236f17b4962790945ae3218de98d09 Log: [FIXED JENKINS-9397] Added convenience method to hudson.util.io.Archiver to get the Unix mode (if appropriate) for a file, and modified TarArchiver and ZipArchiver to utilise this to get and set the Unix mode for files whent they're being archived.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/util/IOUtils.java
            core/src/main/java/hudson/util/io/Archiver.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/io/ZipArchiver.java
            core/src/test/java/hudson/util/io/TarArchiverTest.java
            http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78
            Log:
            [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/util/IOUtils.java core/src/main/java/hudson/util/io/Archiver.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/io/ZipArchiver.java core/src/test/java/hudson/util/io/TarArchiverTest.java http://jenkins-ci.org/commit/jenkins/6577d788b91a19791b6684ddeccbc50c9c563a78 Log: [FIXED JENKINS-9397] fixed a bug in the implementation, added tests.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee
            Log:
            JENKINS-9397 recording the change

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/ad92ad461159ea3320da15f9d7030cdd12d83cee Log: JENKINS-9397 recording the change
            Hide
            bbaja42 Barisa Obradovic added a comment -

            I've cloned the current version of the jenkins to https://github.com/bbaja42/jenkins.

            Junit test for this bug fails the build,

            Failed tests: permission(hudson.util.io.TarArchiverTest): expected:<33261> but was:<33206>
            testCopyToWithPermission(hudson.FilePathTest): expected:<33060> but was:<33206>
            testSymlink(hudson.UtilTest): expected:<012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567> but was:<null>

            mvn -version

            Apache Maven 3.0.4
            Maven home: /usr/share/maven
            Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
            Java home: /usr/lib/jvm/java-6-openjdk-i386/jre
            Default locale: en_US, platform encoding: UTF-8
            OS name: "linux", version: "3.2.0-31-generic-pae", arch: "i386", family: "unix"

            Show
            bbaja42 Barisa Obradovic added a comment - I've cloned the current version of the jenkins to https://github.com/bbaja42/jenkins . Junit test for this bug fails the build, Failed tests: permission(hudson.util.io.TarArchiverTest): expected:<33261> but was:<33206> testCopyToWithPermission(hudson.FilePathTest): expected:<33060> but was:<33206> testSymlink(hudson.UtilTest): expected:<012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567> but was:<null> mvn -version Apache Maven 3.0.4 Maven home: /usr/share/maven Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: /usr/lib/jvm/java-6-openjdk-i386/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "3.2.0-31-generic-pae", arch: "i386", family: "unix"
            Hide
            aarondmarasco_vsi Aaron D. Marasco added a comment - - edited

            (Linking JENKINS-13128)
            This is still an issue years later. Commenting here in the hopes of the people involved in fixing this one will see; that ticket remains unassigned.

            Show
            aarondmarasco_vsi Aaron D. Marasco added a comment - - edited (Linking JENKINS-13128 ) This is still an issue years later. Commenting here in the hopes of the people involved in fixing this one will see; that ticket remains unassigned.
            Hide
            ostancik Ondrej Stancik added a comment -

            I think, that the issue is merely in copying the artifacts from slave to master node (even when copying from master to master). I found a method `hudson.Util.CopyFile()`, which - as I believe - is responsible for physical transfer of the artifact files. It uses `org.apache.tools.ant.taskdefs.Copy` external class to do the job.

            This class seems to copy all the files without preserving their permissions (I guess so from a quick analysis of the code). So, the files are created with master's default permissions, and subsequently archived.

            There is another ticket which seems to be related to this issue: JENKINS-13128

            Show
            ostancik Ondrej Stancik added a comment - I think, that the issue is merely in copying the artifacts from slave to master node (even when copying from master to master). I found a method `hudson.Util.CopyFile()`, which - as I believe - is responsible for physical transfer of the artifact files. It uses `org.apache.tools.ant.taskdefs.Copy` external class to do the job. This class seems to copy all the files without preserving their permissions (I guess so from a quick analysis of the code). So, the files are created with master's default permissions, and subsequently archived. There is another ticket which seems to be related to this issue:  JENKINS-13128 . 

              People

              Assignee:
              abayer Andrew Bayer
              Reporter:
              abayer Andrew Bayer
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: