Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9681

NIS / PAM authentication should use AbstractPasswordBasedSecurityRealm (PAMSecurityRealm should extend it)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: cli
    • Labels:
      None
    • Similar Issues:

      Description

      PAMSecurityRealm extends SecurityRealm.
      PAMSecurityRealm should extend AbstractPasswordBasedSecurityRealm instead.

      This is necessary for CLI to work with PAM authentication scheme.

      see also JENKINS-7995.

        Attachments

          Issue Links

            Activity

            Hide
            iantopanto1 Ian Roberts added a comment -

            I have tried to do "PAMSecurityRealm extends AbstractPasswordBasedSecurityRealm"

            But this is not working, can anyone give me any pointers on how to fix this? thanks

            [INFO] — maven-stapler-plugin:1.15:apt-compile (default-apt-compile) @ jenkins-core —
            [INFO] Compiling 9 source files to /home/ir/jenkins/core/target/classes
            [INFO] ------------------------------------------------------------------------
            [INFO] Reactor Summary:
            [INFO]
            [INFO] Jenkins main module ............................... SUCCESS [1.897s]
            [INFO] Jenkins remoting layer ............................ SUCCESS [22.850s]
            [INFO] Jenkins CLI ....................................... SUCCESS [2.623s]
            [INFO] Jenkins core ...................................... FAILURE [12.679s]
            [INFO] Maven Integration plugin .......................... SKIPPED
            [INFO] Jenkins war ....................................... SKIPPED
            [INFO] Test harness for Jenkins and plugins .............. SKIPPED
            [INFO] Jenkins UI sample plugin .......................... SKIPPED
            [INFO] ------------------------------------------------------------------------
            [INFO] BUILD FAILURE
            [INFO] ------------------------------------------------------------------------
            [INFO] Total time: 43.491s
            [INFO] Finished at: Fri Jul 01 16:19:50 BST 2011
            [INFO] Final Memory: 28M/292M
            [INFO] ------------------------------------------------------------------------
            [ERROR] Failed to execute goal org.kohsuke.stapler:maven-stapler-plugin:1.15:apt-compile (default-apt-compile) on project jenkins-core: Compilation failure
            [ERROR] /home/ir/jenkins/core/src/main/java/hudson/security/PAMSecurityRealm.java:[69,7] hudson.security.PAMSecurityRealm is not abstract and does not override abstract method loadUserByUsername(java.lang.String) in hudson.security.AbstractPasswordBasedSecurityRealm
            [ERROR] -> [Help 1]

            Show
            iantopanto1 Ian Roberts added a comment - I have tried to do "PAMSecurityRealm extends AbstractPasswordBasedSecurityRealm" But this is not working, can anyone give me any pointers on how to fix this? thanks [INFO] — maven-stapler-plugin:1.15:apt-compile (default-apt-compile) @ jenkins-core — [INFO] Compiling 9 source files to /home/ir/jenkins/core/target/classes [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Jenkins main module ............................... SUCCESS [1.897s] [INFO] Jenkins remoting layer ............................ SUCCESS [22.850s] [INFO] Jenkins CLI ....................................... SUCCESS [2.623s] [INFO] Jenkins core ...................................... FAILURE [12.679s] [INFO] Maven Integration plugin .......................... SKIPPED [INFO] Jenkins war ....................................... SKIPPED [INFO] Test harness for Jenkins and plugins .............. SKIPPED [INFO] Jenkins UI sample plugin .......................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 43.491s [INFO] Finished at: Fri Jul 01 16:19:50 BST 2011 [INFO] Final Memory: 28M/292M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.kohsuke.stapler:maven-stapler-plugin:1.15:apt-compile (default-apt-compile) on project jenkins-core: Compilation failure [ERROR] /home/ir/jenkins/core/src/main/java/hudson/security/PAMSecurityRealm.java: [69,7] hudson.security.PAMSecurityRealm is not abstract and does not override abstract method loadUserByUsername(java.lang.String) in hudson.security.AbstractPasswordBasedSecurityRealm [ERROR] -> [Help 1]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/security/PAMSecurityRealm.java
            war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy
            http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a
            Log:
            [FIXED JENKINS-9681] PAM now supports CLI auth

            ... by extending from AbstractPasswordBasedSecurityRealm.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/security/PAMSecurityRealm.java war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a Log: [FIXED JENKINS-9681] PAM now supports CLI auth ... by extending from AbstractPasswordBasedSecurityRealm.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #945
            [FIXED JENKINS-9681] PAM now supports CLI auth

            Kohsuke Kawaguchi : 6a75fe64e69c9f53757603fc849c16099dfc483a
            Files :

            • changelog.html
            • war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy
            • core/src/main/java/hudson/security/PAMSecurityRealm.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #945 [FIXED JENKINS-9681] PAM now supports CLI auth Kohsuke Kawaguchi : 6a75fe64e69c9f53757603fc849c16099dfc483a Files : changelog.html war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy core/src/main/java/hudson/security/PAMSecurityRealm.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/security/PAMSecurityRealm.java
            war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy
            http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a
            Log:
            [FIXED JENKINS-9681] PAM now supports CLI auth

            ... by extending from AbstractPasswordBasedSecurityRealm.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/security/PAMSecurityRealm.java war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a Log: [FIXED JENKINS-9681] PAM now supports CLI auth ... by extending from AbstractPasswordBasedSecurityRealm.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/security/PAMSecurityRealm.java
            war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy
            http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a
            Log:
            [FIXED JENKINS-9681] PAM now supports CLI auth

            ... by extending from AbstractPasswordBasedSecurityRealm.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/security/PAMSecurityRealm.java war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy http://jenkins-ci.org/commit/jenkins/6a75fe64e69c9f53757603fc849c16099dfc483a Log: [FIXED JENKINS-9681] PAM now supports CLI auth ... by extending from AbstractPasswordBasedSecurityRealm.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/security/PAMSecurityRealm.java
            war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy
            http://jenkins-ci.org/commit/pam-auth-plugin/e6c2debacd061b4480868ee925b34f7189e4dd7f
            Log:
            [FIXED JENKINS-9681] PAM now supports CLI auth

            ... by extending from AbstractPasswordBasedSecurityRealm.

            Originally-Committed-As: 6a75fe64e69c9f53757603fc849c16099dfc483a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/security/PAMSecurityRealm.java war/src/main/webapp/WEB-INF/security/PAMSecurityRealm.groovy http://jenkins-ci.org/commit/pam-auth-plugin/e6c2debacd061b4480868ee925b34f7189e4dd7f Log: [FIXED JENKINS-9681] PAM now supports CLI auth ... by extending from AbstractPasswordBasedSecurityRealm. Originally-Committed-As: 6a75fe64e69c9f53757603fc849c16099dfc483a

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              dnozay Damien Nozay
              Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: