Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10544

"shelve project" button missing on some projects

    XMLWordPrintable

Details

    Description

      With the Shelve Plugin version 1.2, on many Jenkins versions, we have seen the "Shelve Project" button missing on some projects.

      We haven't been able to see any pattern. Most of our projects are matrix builds, and we've seen this issue on some matrix projects but not others.

      I don't know what to look for or what other info we might provide to help investigate this issue – ask for anything and I'll do my best to provide it.

      Attachments

        Issue Links

          Activity

            We dug through the log file (catalina.out) and didn't see anything interesting that might be relevant :/

            peterp Peter Pawlowski added a comment - We dug through the log file (catalina.out) and didn't see anything interesting that might be relevant :/

            Well I just found our first clue!

            I noticed that the "shelve project" button does in fact appear, but it does so on the wrong page. It appears on each of the matrix platforms, instead of the project page.

            That is, it does not show up here:

            .../view/job/foo-product/

            but it does show up here:

            .../view/job/foo-product/label=windows-64.build/

            peterp Peter Pawlowski added a comment - Well I just found our first clue! I noticed that the "shelve project" button does in fact appear, but it does so on the wrong page. It appears on each of the matrix platforms, instead of the project page. That is, it does not show up here: .../view/job/foo-product/ but it does show up here: .../view/job/foo-product/label=windows-64.build/

            Jenkins ver. 1.423, plugin ver. 1.3

            The same problem on our Jenkins installation: the 'Shelved Projects' link is not shown in some projects.

            The interesting thing happens when a new project created as copy of the project missing the 'Shelved Projects' link:
            on the first open Configure page the 'Shelved Projects' link is present, but it disappears on next page after 'Save' button is pressed.

            See attached config.xml as a sample of such problem project.

            salmira Tetiana Tvardovska added a comment - Jenkins ver. 1.423, plugin ver. 1.3 The same problem on our Jenkins installation: the 'Shelved Projects' link is not shown in some projects. The interesting thing happens when a new project created as copy of the project missing the 'Shelved Projects' link: on the first open Configure page the 'Shelved Projects' link is present, but it disappears on next page after 'Save' button is pressed. See attached config.xml as a sample of such problem project.

            I recently unshelved some projects.

            Now I'm done with them & want to pack them back up, but none of them has a Shelve Project link anymore

            ganncamp G. Ann Campbell added a comment - I recently unshelved some projects. Now I'm done with them & want to pack them back up, but none of them has a Shelve Project link anymore

            A recent Jenkins restart restored the 'Shelve' buttons. So it appears that the piece that runs at startup also needs to be invoked @unshelve.

            I'm guessing that the 'shelve' action is removed onShelve. So the other option m.ight be to just not do that

            ganncamp G. Ann Campbell added a comment - A recent Jenkins restart restored the 'Shelve' buttons. So it appears that the piece that runs at startup also needs to be invoked @unshelve. I'm guessing that the 'shelve' action is removed onShelve. So the other option m.ight be to just not do that
            mattyt mattyt added a comment -

            I have noticed a similar (same?) problem to that reported. Here are the specifics in case there's useful information:

            We're running Jenkins v1.442 and tried installing and running the shelve plugin (v1.3) without a restart. The "Shelve Project" link didn't appear on any of the job pages though "Shelved Projects" was visible on the main page.

            Restarting Jenkins fixed the issue; all jobs now have the "Shelve Project" option.

            mattyt mattyt added a comment - I have noticed a similar (same?) problem to that reported. Here are the specifics in case there's useful information: We're running Jenkins v1.442 and tried installing and running the shelve plugin (v1.3) without a restart. The "Shelve Project" link didn't appear on any of the job pages though "Shelved Projects" was visible on the main page. Restarting Jenkins fixed the issue; all jobs now have the "Shelve Project" option.
            starlatch star latch added a comment -

            Looks like when a job is created using "Copy existing job", the properties are not copied with it. The newly created job is missing this property which allows it to be shelved. I made following change in the job and restarted Jenkins and can now see the Shelve button. (I know the workaround sucks). Don't know if this is a defect in the plugin or core/create job functionality.

            — SNIP —
            <properties>
            <org.jvnet.hudson.plugins.shelveproject.ShelveProjectProperty/>
            </properties>
            — SNIP —

            starlatch star latch added a comment - Looks like when a job is created using "Copy existing job", the properties are not copied with it. The newly created job is missing this property which allows it to be shelved. I made following change in the job and restarted Jenkins and can now see the Shelve button. (I know the workaround sucks). Don't know if this is a defect in the plugin or core/create job functionality. — SNIP — <properties> <org.jvnet.hudson.plugins.shelveproject.ShelveProjectProperty/> </properties> — SNIP —
            dzorin Dmitry Zorin added a comment -

            It looks like the job configuration loses the ShelveProjectProperty while being saved by the user, i.e. by clicking the "Save" button. If the system changes the job configuration for its own needs the property becomes restored and the "Shelve project" link appears again... up to the next saving by user.

            BTW, does anybody work on this plugin yet?

            dzorin Dmitry Zorin added a comment - It looks like the job configuration loses the ShelveProjectProperty while being saved by the user, i.e. by clicking the "Save" button. If the system changes the job configuration for its own needs the property becomes restored and the "Shelve project" link appears again... up to the next saving by user. BTW, does anybody work on this plugin yet?
            kmleinen Kyle Leinen added a comment -

            I am also seeing this on my Jenkins instance (v1.460) running RHEL. Is anyone looking into this?

            kmleinen Kyle Leinen added a comment - I am also seeing this on my Jenkins instance (v1.460) running RHEL. Is anyone looking into this?

            We are also seeing this with Jenkins 1.464 on Windows 7. Seems to happen for new projects, perhaps the ones created by the Copy From option. Our fix is to restart the Jenkins service, then we can shelve.

            bcrooker Britain Crooker added a comment - We are also seeing this with Jenkins 1.464 on Windows 7. Seems to happen for new projects, perhaps the ones created by the Copy From option. Our fix is to restart the Jenkins service, then we can shelve.

            Experienced the same issue with Jenkins 1.514 and Shelve Projects 1.3. Restarting Jenkins restored the Shelve Project button.

            chalford Charlie Halford added a comment - Experienced the same issue with Jenkins 1.514 and Shelve Projects 1.3. Restarting Jenkins restored the Shelve Project button.
            olenz Olaf Lenz added a comment -

            Same here, Jenkins 1.529, Shelve Projects 1.4.4. Restarting helped.

            olenz Olaf Lenz added a comment - Same here, Jenkins 1.529, Shelve Projects 1.4.4. Restarting helped.

            Code changed in jenkins
            User: maselvaraj
            Path:
            src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java
            src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java
            http://jenkins-ci.org/commit/shelve-project-plugin-plugin/ffecd58cef0007b9ac495ba7cdc850ae11a91eb6
            Log:
            Fix to persist Shelve project property whenever the job is updated
            this fix would resolve JENKINS-10544

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: maselvaraj Path: src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java http://jenkins-ci.org/commit/shelve-project-plugin-plugin/ffecd58cef0007b9ac495ba7cdc850ae11a91eb6 Log: Fix to persist Shelve project property whenever the job is updated this fix would resolve JENKINS-10544

            Code changed in jenkins
            User: Ben Patterson
            Path:
            src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java
            src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java
            http://jenkins-ci.org/commit/shelve-project-plugin-plugin/ea6afb8d682ca8c0c78a7a8213e661fb73e5cf00
            Log:
            Merge pull request #3 from maselvaraj/master

            JENKINS-10544 Persist ShelveProject property whenever the job is updated

            Compare: https://github.com/jenkinsci/shelve-project-plugin-plugin/compare/2df406a4ee7c...ea6afb8d682c

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ben Patterson Path: src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java http://jenkins-ci.org/commit/shelve-project-plugin-plugin/ea6afb8d682ca8c0c78a7a8213e661fb73e5cf00 Log: Merge pull request #3 from maselvaraj/master JENKINS-10544 Persist ShelveProject property whenever the job is updated Compare: https://github.com/jenkinsci/shelve-project-plugin-plugin/compare/2df406a4ee7c...ea6afb8d682c
            bpatterson ben patterson added a comment -

            maselvaraj's pull request corrects this problem. It'll be included in the next rev of this plugin.

            bpatterson ben patterson added a comment - maselvaraj's pull request corrects this problem. It'll be included in the next rev of this plugin.

            Code changed in jenkins
            User: maselvaraj
            Path:
            src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java
            src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java
            http://jenkins-ci.org/commit/shelve-project-plugin-plugin/7258a6071c624ee432795b3a9e62ce3475422ddb
            Log:
            Fix to persist Shelve project property whenever the job is updated
            this fix would resolve JENKINS-10544

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: maselvaraj Path: src/main/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImpl.java src/test/java/org/jvnet/hudson/plugins/shelveproject/ItemListenerImplTest.java http://jenkins-ci.org/commit/shelve-project-plugin-plugin/7258a6071c624ee432795b3a9e62ce3475422ddb Log: Fix to persist Shelve project property whenever the job is updated this fix would resolve JENKINS-10544
            bpatterson ben patterson added a comment -

            Fixed in release v 1.5

            bpatterson ben patterson added a comment - Fixed in release v 1.5
            rd31419 Ras Dama added a comment -

            I just installed Shelve Project(V1.5) plugin and this option is still missing.

            rd31419 Ras Dama added a comment - I just installed Shelve Project(V1.5) plugin and this option is still missing.
            rd31419 Ras Dama added a comment -

            I just installed Shelve Project(V1.5) plugin and this option is still missing.

            rd31419 Ras Dama added a comment - I just installed Shelve Project(V1.5) plugin and this option is still missing.
            pierrebtz Pierre Beitz added a comment -

            Fix made to JENKINS-39239 should fix this issue. I'll close as fixed, please reopen if you encounter the issue for a version <= 2.1 of the plugin

            pierrebtz Pierre Beitz added a comment - Fix made to JENKINS-39239 should fix this issue. I'll close as fixed, please reopen if you encounter the issue for a version <= 2.1 of the plugin

            I am facing this error now. I have installed the plugin today and I don't see the shelve project option for any job. I have 2.1 version installed and Jenkins 2.129.

            jigel_raja Deepak Puligundla added a comment - I am facing this error now. I have installed the plugin today and I don't see the shelve project option for any job. I have 2.1 version installed and Jenkins 2.129.
            pierrebtz Pierre Beitz added a comment - - edited

            jigel_raja: Can you please provide more details, what is the type of job not displaying the shelve option?

            pierrebtz Pierre Beitz added a comment - - edited jigel_raja : Can you please provide more details, what is the type of job not displaying the shelve option?

            pierrebtz all of them are pipelines. None of them have the shelve option on their pages. I created a freestyle projet and it also doesn't have the option.

            jigel_raja Deepak Puligundla added a comment - pierrebtz all of them are pipelines. None of them have the shelve option on their pages. I created a freestyle projet and it also doesn't have the option.
            pierrebtz Pierre Beitz added a comment -

            jigel_raja : Pipeline us expected as the plugin doesn't support them yet, I hope I'll have some time to add support soon!

            Freestyle on the other hand is clearly a bug, can you please send a screenshot of the freestyle job page.
            If you just upgraded the plugin, did you restart your Jenkins instance?

            pierrebtz Pierre Beitz added a comment - jigel_raja : Pipeline us expected as the plugin doesn't support them yet, I hope I'll have some time to add support soon! Freestyle on the other hand is clearly a bug, can you please send a screenshot of the freestyle job page. If you just upgraded the plugin, did you restart your Jenkins instance?
            pierrebtz Pierre Beitz added a comment -

            jigel_raja were you able to reproduce the issue on a Freestyle job?

            pierrebtz Pierre Beitz added a comment - jigel_raja were you able to reproduce the issue on a Freestyle job?
            pierrebtz Pierre Beitz added a comment -

            jigel_raja I'll close as not reproduced, please reopen if you have a test case.

            pierrebtz Pierre Beitz added a comment - jigel_raja I'll close as not reproduced, please reopen if you have a test case.

            People

              pierrebtz Pierre Beitz
              peterp Peter Pawlowski
              Votes:
              15 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: