Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11333

Make fingerprinting configurable in Maven projects

    XMLWordPrintable

Details

    Description

      Currently, in a Maven Project, fingerprints are generated for all build artifacts (created and used).

      In a freestyle project, you can manually select files to be fingerprinted using the Fingerprinter publisher.

      This needs to be possible for Maven Projects, too.

      Consider for example a Maven project that uses post-build steps to create additional artifacts. You can archive them (without them being fingerprinted), but you cannot choose to fingerprint them.

      Looking at hudson.tasks.Fingerprinter, I see no reason why this publisher should not be available for configuration.

      If you enter the publisher by hand into the config.xml of a job, it works (until you reconfig that job, of course), so this seems to be a display issue. One small drawback: two fingerprintActions are included.

      Tasks:

      • make Fingerprinter available for Maven projects
      • prevent Fingerprinter from always creating a new FingerprintAction (i.e. let it check for any existing FingerprintActions (like MavenFingerprinter does))

      the second part is trivial, I can create a pull request for that.

      Attachments

        1. FreeStylePublishers.png
          11 kB
          Stephan Pauxberger
        2. MavenJobPublishers.png
          5 kB
          Stephan Pauxberger

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-17606 Copy Artifact's fingerprinting creates second hudson.tasks.Fingerprinter_-FingerprintAction section with just the artifacts copied

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-18615 Add option do disable fingerprinting for maven jobs

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19712 [Fingerprint] Excessive Heap consumption during "Waiting for Jenkins to finish collecting data"

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-11814 Maven artifact fingerprints are computed and recorded twice

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            jglick Jesse Glick added a comment -

            The fix to Fingerprinter was already done in JENKINS-17606.

            jglick Jesse Glick added a comment - The fix to Fingerprinter was already done in JENKINS-17606 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/maven/MavenModule.java
            src/main/java/hudson/maven/MavenModuleSet.java
            src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java
            src/main/java/hudson/maven/reporters/MavenFingerprinter.java
            src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
            src/main/webapp/fingerprintingDisabled.html
            src/test/java/hudson/maven/MavenModuleSetTest.java
            http://jenkins-ci.org/commit/maven-plugin/33c52c897e893029631615cc5bebacd15d535454
            Log:
            [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModule.java src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java src/main/java/hudson/maven/reporters/MavenFingerprinter.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly src/main/webapp/fingerprintingDisabled.html src/test/java/hudson/maven/MavenModuleSetTest.java http://jenkins-ci.org/commit/maven-plugin/33c52c897e893029631615cc5bebacd15d535454 Log: [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/maven/MavenModule.java
            src/main/java/hudson/maven/MavenModuleSet.java
            src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java
            src/main/java/hudson/maven/reporters/MavenFingerprinter.java
            src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
            src/main/webapp/fingerprintingDisabled.html
            src/test/java/hudson/maven/MavenModuleSetTest.java
            http://jenkins-ci.org/commit/maven-plugin/728878bed3c854dcc5c63aec1b7b12e3a133da51
            Log:
            [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.
            Conflicts:
            src/main/java/hudson/maven/MavenModuleSet.java
            src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModule.java src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java src/main/java/hudson/maven/reporters/MavenFingerprinter.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly src/main/webapp/fingerprintingDisabled.html src/test/java/hudson/maven/MavenModuleSetTest.java http://jenkins-ci.org/commit/maven-plugin/728878bed3c854dcc5c63aec1b7b12e3a133da51 Log: [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired. Conflicts: src/main/java/hudson/maven/MavenModuleSet.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
            benken_parasoft Joseph Benken added a comment -

            Does this address https://issues.jenkins-ci.org/browse/JENKINS-18615? Is there a target version for this enhancement?

            benken_parasoft Joseph Benken added a comment - Does this address https://issues.jenkins-ci.org/browse/JENKINS-18615? Is there a target version for this enhancement?
            jglick Jesse Glick added a comment -

            @benken_parasoft yes and it has been released.

            jglick Jesse Glick added a comment - @benken_parasoft yes and it has been released.

            People

              jglick Jesse Glick
              paux Stephan Pauxberger
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: