Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12748

Scriptler remote catalog breaks when script name contains certain characters

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • scriptler-plugin
    • None

      The scriptler remote catalog breaks when trying to get a script with a "/" in its metadata name. e.g., for "Disable/Enable Jobs Matching Pattern", you get http://localhost:8080/scriptler/downloadScript?id=disableEnableJobsMatchingPattern.groovy&name=Disable/Enable%20Jobs%20Matching%20Pattern&catalog=gh, with Scriptler trying to put the "/" in the output filename.

          [JENKINS-12748] Scriptler remote catalog breaks when script name contains certain characters

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: imod
          Path:
          src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java
          src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java
          src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java
          src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java
          src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java
          src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java
          src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java
          src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java
          src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly
          src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly
          http://jenkins-ci.org/commit/scriptler-plugin/37223a7490c0bad7e839ad8d2720627e30d3ee79
          Log:
          [FIXED JENKINS-12748] differentiate between name and id

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly http://jenkins-ci.org/commit/scriptler-plugin/37223a7490c0bad7e839ad8d2720627e30d3ee79 Log: [FIXED JENKINS-12748] differentiate between name and id

          dogfood added a comment -

          Integrated in plugins_scriptler #40
          [FIXED JENKINS-12748] differentiate between name and id (Revision 37223a7490c0bad7e839ad8d2720627e30d3ee79)

          Result = SUCCESS
          imod :
          Files :

          • src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly
          • src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java
          • src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly
          • src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java
          • src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties
          • src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java
          • src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly
          • src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java
          • src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly
          • src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java

          dogfood added a comment - Integrated in plugins_scriptler #40 [FIXED JENKINS-12748] differentiate between name and id (Revision 37223a7490c0bad7e839ad8d2720627e30d3ee79) Result = SUCCESS imod : Files : src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptlerConfiguration.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.jelly src/main/java/org/jenkinsci/plugins/scriptler/util/ScriptHelper.java src/main/java/org/jenkinsci/plugins/scriptler/util/ByNameSorter.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/catalog.jelly src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/scriptsettings.jelly src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java src/main/java/org/jenkinsci/plugins/scriptler/ScriptlerManagment.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/edit.properties src/main/java/org/jenkinsci/plugins/scriptler/util/ByIdSorter.java src/main/java/org/jenkinsci/plugins/scriptler/config/NamedResource.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/index.jelly src/main/java/org/jenkinsci/plugins/scriptler/config/ScriptSet.java src/main/resources/org/jenkinsci/plugins/scriptler/ScriptlerManagment/runscript.jelly src/main/java/org/jenkinsci/plugins/scriptler/ScritplerPluginImpl.java

          Dominik Bartholdi added a comment -

          fixed in 2.1

          Dominik Bartholdi added a comment - fixed in 2.1

            domi Dominik Bartholdi
            abayer Andrew Bayer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: