Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13790

Subversion externals fail

    XMLWordPrintable

Details

    Description

      Updates on a repository with svn:externals property set fail with the following:
      AssertionError: appears to be using unpatched svnkit at jar:xxx/SVNEvent.class

      The issue is present with the latest 1.40 release.
      The issue is not preset with the 1.39 release.

      Attachments

        Issue Links

          Activity

            nvc Nick Vancauwenberghe added a comment - I hit... AssertionError: appears to be using unpatched svnkit at jar: file:/D:/Jenkins/plugins/subversion/WEB-INF/lib/svnkit-1.7.4-jenkins-3.jar!/org/tmatesoft/svn/core/wc/SVNEvent.class

            Hi Nick, the problem is, that the "patched" svnkit is already in use, but the "patches" for subversion 1.7 are still missing.
            May be you could write to the mailing list, because here seems none of the plugin developers to listen.

            climblinne Jan Linnenkohl added a comment - Hi Nick, the problem is, that the "patched" svnkit is already in use, but the "patches" for subversion 1.7 are still missing. May be you could write to the mailing list, because here seems none of the plugin developers to listen.
            tmpalmer Tom Palmer added a comment -

            I have a fix for this within my fork of the plugin on github. It uses the native support within SVNKit to determine the URLs for the svn:externals that the project contains. Because it natively hooks into SVNKit it works regardless of the SVN version you wish to use in your working copies. The pull request is https://github.com/jenkinsci/subversion-plugin/pull/30.

            tmpalmer Tom Palmer added a comment - I have a fix for this within my fork of the plugin on github. It uses the native support within SVNKit to determine the URLs for the svn:externals that the project contains. Because it natively hooks into SVNKit it works regardless of the SVN version you wish to use in your working copies. The pull request is https://github.com/jenkinsci/subversion-plugin/pull/30 .
            gkm4d Griffin Myers added a comment -

            Many thanks to Tom Palmer for his fix. I've manually built the SVN plugin with his mods (followed instructions here: https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-BuildingaPlugin) and svn:externals polling functionality seems to be restored. I've tested this with multiple Jenkins projects with wc 1.7 with many, many directory externals without any issues. The only thing I haven't tested are file externals, which I know were also problematic with recent official releases of the plugin.

            gkm4d Griffin Myers added a comment - Many thanks to Tom Palmer for his fix. I've manually built the SVN plugin with his mods (followed instructions here: https://wiki.jenkins-ci.org/display/JENKINS/Plugin+tutorial#Plugintutorial-BuildingaPlugin ) and svn:externals polling functionality seems to be restored. I've tested this with multiple Jenkins projects with wc 1.7 with many, many directory externals without any issues. The only thing I haven't tested are file externals, which I know were also problematic with recent official releases of the plugin.

            Code changed in jenkins
            User: Tom Palmer
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            src/main/java/hudson/scm/subversion/CheckoutUpdater.java
            src/main/java/hudson/scm/subversion/SubversionUpdateEventHandler.java
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/1e685c2e58160f8353d52ba92a6066a39f107443
            Log:
            [FIXED JENKINS-13790] Use the native SVNKit ISVNExternalsHandler to pick up the svn:externals URLs.

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/b20cf6430106...1e685c2e5816

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Palmer Path: src/main/java/hudson/scm/SubversionSCM.java src/main/java/hudson/scm/subversion/CheckoutUpdater.java src/main/java/hudson/scm/subversion/SubversionUpdateEventHandler.java src/main/java/hudson/scm/subversion/UpdateUpdater.java http://jenkins-ci.org/commit/subversion-plugin/1e685c2e58160f8353d52ba92a6066a39f107443 Log: [FIXED JENKINS-13790] Use the native SVNKit ISVNExternalsHandler to pick up the svn:externals URLs. Compare: https://github.com/jenkinsci/subversion-plugin/compare/b20cf6430106...1e685c2e5816

            People

              kohsuke Kohsuke Kawaguchi
              chikigai chikigai
              Votes:
              49 Vote for this issue
              Watchers:
              58 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: