Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15666

Label.getTiedJobs ignores non-top-level jobs

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • 1.466.x, CloudBees Folders plugin

    Description

      If a job is defined in a folder and tied to a slave or label then it does not show up in the “Projects tied to” report for either /computer/* or /label/*. A job with the same configuration in the root folder does show up in these reports.

      The reason is that Label.getTiedJobs calls Jenkins.getItems() which will ignore the contents of folders; should be using getAllItems(AbstractProject.class).

      (This call is potentially slow so not a great idea to call synchronously from a Jelly view; better to use ProgressiveRendering. Not as big of an issue as e.g. /asynchPeople for which builds, not just projects, are loaded.)

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-17451 "projects tied to slave" shows unrelated maven module jobs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/Label.java
            core/src/main/resources/hudson/model/Computer/index.jelly
            core/src/main/resources/hudson/model/Label/index.jelly
            core/src/main/resources/hudson/views/JobColumn/column.jelly
            core/src/main/resources/lib/hudson/projectView.jelly
            http://jenkins-ci.org/commit/jenkins/08459c328f014a97d969fa35d9d76bb8c7bc8c33
            Log:
            [FIXED JENKINS-15666] Label.getTiedJobs ignores non-top-level jobs.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Label.java core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Label/index.jelly core/src/main/resources/hudson/views/JobColumn/column.jelly core/src/main/resources/lib/hudson/projectView.jelly http://jenkins-ci.org/commit/jenkins/08459c328f014a97d969fa35d9d76bb8c7bc8c33 Log: [FIXED JENKINS-15666] Label.getTiedJobs ignores non-top-level jobs.
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2045
            [FIXED JENKINS-15666] Label.getTiedJobs ignores non-top-level jobs. (Revision 08459c328f014a97d969fa35d9d76bb8c7bc8c33)

            Result = UNSTABLE
            Jesse Glick : 08459c328f014a97d969fa35d9d76bb8c7bc8c33
            Files :

            • core/src/main/resources/hudson/views/JobColumn/column.jelly
            • core/src/main/resources/lib/hudson/projectView.jelly
            • core/src/main/java/hudson/model/Label.java
            • core/src/main/resources/hudson/model/Computer/index.jelly
            • changelog.html
            • core/src/main/resources/hudson/model/Label/index.jelly
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2045 [FIXED JENKINS-15666] Label.getTiedJobs ignores non-top-level jobs. (Revision 08459c328f014a97d969fa35d9d76bb8c7bc8c33) Result = UNSTABLE Jesse Glick : 08459c328f014a97d969fa35d9d76bb8c7bc8c33 Files : core/src/main/resources/hudson/views/JobColumn/column.jelly core/src/main/resources/lib/hudson/projectView.jelly core/src/main/java/hudson/model/Label.java core/src/main/resources/hudson/model/Computer/index.jelly changelog.html core/src/main/resources/hudson/model/Label/index.jelly
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/Label.java
            http://jenkins-ci.org/commit/jenkins/73bf0e5b4f1c038101e284ee8adfb56b0760addc
            Log:
            Revert "[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only."

            This reverts commit 3a6de84f6746d54dd0f3048312db067c835ee727.
            (Regressed JENKINS-15666.)
            Conflicts:

            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/73bf0e5b4f1c038101e284ee8adfb56b0760addc Log: Revert " [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only." This reverts commit 3a6de84f6746d54dd0f3048312db067c835ee727. (Regressed JENKINS-15666 .) Conflicts: changelog.html

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: