Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17451

"projects tied to slave" shows unrelated maven module jobs

      In the slave status page, there is a list of jobs called "Projects tied to <slave name>". That list should only show jobs that are explicitely tied to this slave.

      For me it als shows lots of modules of maven style jobs that have nothing to do with that particular slave whatsoever. Only the module part of the job is shown here, not the top level maven job it belongs to.

      So far I have found no pattern which jobs are shown where. I suspected it to be the last used slave, but it is not.

          [JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs

          Jesse Glick added a comment -

          This breaks JENKINS-15666; it was intentional to show items in folders.

          Jesse Glick added a comment - This breaks JENKINS-15666 ; it was intentional to show items in folders.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Label.java
          http://jenkins-ci.org/commit/jenkins/73bf0e5b4f1c038101e284ee8adfb56b0760addc
          Log:
          Revert "[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only."

          This reverts commit 3a6de84f6746d54dd0f3048312db067c835ee727.
          (Regressed JENKINS-15666.)
          Conflicts:

          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/73bf0e5b4f1c038101e284ee8adfb56b0760addc Log: Revert " [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only." This reverts commit 3a6de84f6746d54dd0f3048312db067c835ee727. (Regressed JENKINS-15666 .) Conflicts: changelog.html

          Marc Günther added a comment -

          Isn't the problem that getAssignedLabel() of a MavenModule returns the last slave that the parent was build on (contrary to my observation above, which must have been mistaken)?

          Marc Günther added a comment - Isn't the problem that getAssignedLabel() of a MavenModule returns the last slave that the parent was build on (contrary to my observation above, which must have been mistaken)?

          Jesse Glick added a comment -

          Well probably we just do not want to display a MavenModule here under any conditions, since (AFAIK) it is not possible to tie an individual module to a label, only to a module set.

          Jesse Glick added a comment - Well probably we just do not want to display a MavenModule here under any conditions, since (AFAIK) it is not possible to tie an individual module to a label, only to a module set.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2445
          Revert "[FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only." (Revision 73bf0e5b4f1c038101e284ee8adfb56b0760addc)

          Result = SUCCESS
          Jesse Glick : 73bf0e5b4f1c038101e284ee8adfb56b0760addc
          Files :

          • changelog.html
          • core/src/main/java/hudson/model/Label.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2445 Revert " [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only." (Revision 73bf0e5b4f1c038101e284ee8adfb56b0760addc) Result = SUCCESS Jesse Glick : 73bf0e5b4f1c038101e284ee8adfb56b0760addc Files : changelog.html core/src/main/java/hudson/model/Label.java

          Code changed in jenkins
          User: Vincent Latombe
          Path:
          core/src/main/java/hudson/model/Label.java
          http://jenkins-ci.org/commit/jenkins/9cb0d11f5adde14d07527838132af9774074c846
          Log:
          [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven
          module jobs. shows TopLevelItem only.

          Restricts displayed projects to TopLevelItem only.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent Latombe Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/9cb0d11f5adde14d07527838132af9774074c846 Log: [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only. Restricts displayed projects to TopLevelItem only.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/Label.java
          http://jenkins-ci.org/commit/jenkins/b64d3dbfb76e7498e58dcedc4e6434ab7288a3f3
          Log:
          Merge pull request #802 from Vlatombe/JENKINS-17451

          [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven

          Compare: https://github.com/jenkinsci/jenkins/compare/cc2a91bdbdb2...b64d3dbfb76e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/b64d3dbfb76e7498e58dcedc4e6434ab7288a3f3 Log: Merge pull request #802 from Vlatombe/ JENKINS-17451 [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven Compare: https://github.com/jenkinsci/jenkins/compare/cc2a91bdbdb2...b64d3dbfb76e

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/609c4f8df07e8df6531bafaa0e07b6a69dd68420
          Log:
          JENKINS-17451 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/609c4f8df07e8df6531bafaa0e07b6a69dd68420 Log: JENKINS-17451 Noting.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2594
          [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven (Revision 9cb0d11f5adde14d07527838132af9774074c846)
          JENKINS-17451 Noting. (Revision 609c4f8df07e8df6531bafaa0e07b6a69dd68420)

          Result = SUCCESS
          Vincent Latombe : 9cb0d11f5adde14d07527838132af9774074c846
          Files :

          • core/src/main/java/hudson/model/Label.java

          Jesse Glick : 609c4f8df07e8df6531bafaa0e07b6a69dd68420
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2594 [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven (Revision 9cb0d11f5adde14d07527838132af9774074c846) JENKINS-17451 Noting. (Revision 609c4f8df07e8df6531bafaa0e07b6a69dd68420) Result = SUCCESS Vincent Latombe : 9cb0d11f5adde14d07527838132af9774074c846 Files : core/src/main/java/hudson/model/Label.java Jesse Glick : 609c4f8df07e8df6531bafaa0e07b6a69dd68420 Files : changelog.html

          Code changed in jenkins
          User: Vincent Latombe
          Path:
          core/src/main/java/hudson/model/Label.java
          http://jenkins-ci.org/commit/jenkins/a01c6c5d4c7b54106f31c7746849979b0776e206
          Log:
          [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven
          module jobs. shows TopLevelItem only.

          Restricts displayed projects to TopLevelItem only.
          (cherry picked from commit 9cb0d11f5adde14d07527838132af9774074c846)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent Latombe Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/a01c6c5d4c7b54106f31c7746849979b0776e206 Log: [FIXED JENKINS-17451] "projects tied to slave" shows unrelated maven module jobs. shows TopLevelItem only. Restricts displayed projects to TopLevelItem only. (cherry picked from commit 9cb0d11f5adde14d07527838132af9774074c846)

            sogabe sogabe
            marc_guenther Marc Günther
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: