Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15976

Provided maven settings.xml in maven builder is lost

      I wanted to use the "Config File Provider plugin" to specify and reuse a maven settings.xml (Maven builder -> Settings file -> provided settings.xml). Everything seemed to work ok until i reopened the project's configuration page and stored the project: Now the specified settings.xml was lost! I made a copy of the project's config.xml before and compared it. The "settingsConfigId" element became empty, everytime i saved the project. It is only stored when i explicitly set the "provided settings" to use.

      This is very awkward, especially because the "Settings file" part is not seen right away when you open the project's configuration page.

          [JENKINS-15976] Provided maven settings.xml in maven builder is lost

          Markus Stein added a comment -

          Here's the same problem. I can reproduce it too, on Jenkins 1.522 with config-file-provider 2.5.1.
          Setting "provided global settings" then choose settings item.

          After save and open job again, it's lost.

          Markus Stein added a comment - Here's the same problem. I can reproduce it too, on Jenkins 1.522 with config-file-provider 2.5.1. Setting "provided global settings" then choose settings item. After save and open job again, it's lost.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2717
          [FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization. (Revision 40f3b095aae871589b296e455dfad04f368c3dc3)
          [FIXED JENKINS-15976] update changelog (Revision 5a3d877164e37554fa93eb9c5f011b6001d23956)

          Result = SUCCESS
          bastian.gloeckle : 40f3b095aae871589b296e455dfad04f368c3dc3
          Files :

          • core/src/main/java/hudson/tasks/Maven.java

          imod : 5a3d877164e37554fa93eb9c5f011b6001d23956
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2717 [FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization. (Revision 40f3b095aae871589b296e455dfad04f368c3dc3) [FIXED JENKINS-15976] update changelog (Revision 5a3d877164e37554fa93eb9c5f011b6001d23956) Result = SUCCESS bastian.gloeckle : 40f3b095aae871589b296e455dfad04f368c3dc3 Files : core/src/main/java/hudson/tasks/Maven.java imod : 5a3d877164e37554fa93eb9c5f011b6001d23956 Files : changelog.html

          Ryan Campbell added a comment -

          40f3b095a claims to have fixed this issue, but was not automatically done for some reason.

          Ryan Campbell added a comment - 40f3b095a claims to have fixed this issue, but was not automatically done for some reason.

          Code changed in jenkins
          User: Glöckle Bastian
          Path:
          core/src/main/java/hudson/tasks/Maven.java
          http://jenkins-ci.org/commit/jenkins/40f3b095aae871589b296e455dfad04f368c3dc3
          Log:
          [FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Glöckle Bastian Path: core/src/main/java/hudson/tasks/Maven.java http://jenkins-ci.org/commit/jenkins/40f3b095aae871589b296e455dfad04f368c3dc3 Log: [FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization.

          Code changed in jenkins
          User: imod
          Path:
          core/src/main/java/hudson/tasks/Maven.java
          http://jenkins-ci.org/commit/jenkins/e034d632ec8ff6dfc80bb065f57fce9279547814
          Log:
          Merge branch 'JENKINS-15976' of https://github.com/bgloeckle/jenkins into bgloeckle-JENKINS-15976

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: core/src/main/java/hudson/tasks/Maven.java http://jenkins-ci.org/commit/jenkins/e034d632ec8ff6dfc80bb065f57fce9279547814 Log: Merge branch ' JENKINS-15976 ' of https://github.com/bgloeckle/jenkins into bgloeckle- JENKINS-15976

          Code changed in jenkins
          User: imod
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/5a3d877164e37554fa93eb9c5f011b6001d23956
          Log:
          [FIXED JENKINS-15976] update changelog

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: changelog.html http://jenkins-ci.org/commit/jenkins/5a3d877164e37554fa93eb9c5f011b6001d23956 Log: [FIXED JENKINS-15976] update changelog

          Sorry I've to reopen this again

          We're currently waiting for this change to be integrated into an official release.
          The changelog of 1.525 says that it was integrated, but when inspecting the git log, the commit was not integrated in the release: See the list of commits available on master but not on jenkins-1.525 tag: https://github.com/jenkinsci/jenkins/compare/jenkins-1.525...master (search for "JENKINS-15976"). Or you can have a look at the code of the Maven class that was built in the release: https://github.com/jenkinsci/jenkins/blob/jenkins-1.525/core/src/main/java/hudson/tasks/Maven.java (line 437f does not contain my changes).
          I think the changelog for 1.525 should be adjusted. I'd really love to see the changes appear in one of the next releases

          Bastian Glöckle added a comment - Sorry I've to reopen this again We're currently waiting for this change to be integrated into an official release. The changelog of 1.525 says that it was integrated, but when inspecting the git log, the commit was not integrated in the release: See the list of commits available on master but not on jenkins-1.525 tag: https://github.com/jenkinsci/jenkins/compare/jenkins-1.525...master (search for " JENKINS-15976 "). Or you can have a look at the code of the Maven class that was built in the release: https://github.com/jenkinsci/jenkins/blob/jenkins-1.525/core/src/main/java/hudson/tasks/Maven.java (line 437f does not contain my changes). I think the changelog for 1.525 should be adjusted. I'd really love to see the changes appear in one of the next releases

          some stuff got lost in the last RC, but the code is changed and will be in the next release

          changelog is sdjusted

          Dominik Bartholdi added a comment - some stuff got lost in the last RC, but the code is changed and will be in the next release changelog is sdjusted

          Hi,
          I've added LTS as this bug effects current LTS 1.509.4
          Will the fix for this cleanly apply to current LTS? (1.509.4) or do we need to wait for LTS RC (1.532.1)?
          This particular issue is breaking several things in our setup.

          Brett Delle Grazie added a comment - Hi, I've added LTS as this bug effects current LTS 1.509.4 Will the fix for this cleanly apply to current LTS? (1.509.4) or do we need to wait for LTS RC (1.532.1)? This particular issue is breaking several things in our setup.

          I don't think there is gonna be another 1.509.* release, so yes you'll have to wait for 1.532.1

          Dominik Bartholdi added a comment - I don't think there is gonna be another 1.509.* release, so yes you'll have to wait for 1.532.1

            domi Dominik Bartholdi
            mhoofe Markus Hoofe
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: