[JENKINS-16376] BuildStepMonitor.BUILD makes concurrent builds wait, could be changed to BuildStepMonitor.NONE?

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: email-ext-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show
URL:
https://github.com/jenkinsci/email-ext-plugin/pull/79

We perform many concurrent builds in one job and are using the email-ext plugin. Sometimes and older build takes longer time to finish and then the new jobs just waits to be finished because BuildStepMonitor.BUILD is configured in the plugin.

Could this one line be changed?

is duplicated by

JENKINS-21246 email-ext serialises concurrent builds waiting for checkpoint

Resolved

is related to

JENKINS-20867 Sending mail blocks on prior build

Resolved

JENKINS-9913 Not obvious why some post-build tasks enforce serial behavior even when builds are concurrent

Resolved

JENKINS-21145 Several concurrent builds waits for each other

Resolved

JENKINS-24450 JacocoPublisher serializes concurrent builds waiting for checkpoint

Closed

Alex Earl added a comment - 2013-11-05 20:49

Not really, if you would like to submit a pull request for review, please do so.

Alex Earl added a comment - 2013-11-05 20:49 Not really, if you would like to submit a pull request for review, please do so.

Jesse Glick added a comment - 2013-11-05 22:21

Pull #79.

Jesse Glick added a comment - 2013-11-05 22:21 Pull #79.

Alex Earl added a comment - 2013-11-05 22:58

I'll review this as soon as possible and merge it.

Alex Earl added a comment - 2013-11-05 22:58 I'll review this as soon as possible and merge it.

SCM/JIRA link daemon added a comment - 2013-11-06 13:33

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
src/main/java/hudson/plugins/emailext/plugins/content/AbstractChangesSinceContent.java
src/main/java/hudson/plugins/emailext/plugins/content/BuildStatusContent.java
src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java
src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastSuccessfulBuildContent.java
src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastUnstableBuildContent.java
src/main/java/hudson/plugins/emailext/plugins/trigger/BuildingTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/FixedTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/NthFailureTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/StatusChangedTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java
src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java
src/main/resources/hudson/plugins/emailext/Messages.properties
src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherTest.java
http://jenkins-ci.org/commit/email-ext-plugin/6fb41818d63ca0067171f8c01fcdbed196335b44
Log:
[FIXED JENKINS-16376] Never wait for previous builds to complete just to get a more precise status.
If and when we need to know the status of a previous build but it is still running,
simply print a warning to the (current build’s) log and proceed as if the previous build did not exist.

SCM/JIRA link daemon added a comment - 2013-11-06 13:33 Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/plugins/content/AbstractChangesSinceContent.java src/main/java/hudson/plugins/emailext/plugins/content/BuildStatusContent.java src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastBuildContent.java src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastSuccessfulBuildContent.java src/main/java/hudson/plugins/emailext/plugins/content/ChangesSinceLastUnstableBuildContent.java src/main/java/hudson/plugins/emailext/plugins/trigger/BuildingTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FixedTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/FixedUnhealthyTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/NthFailureTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/RegressionTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StatusChangedTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java src/main/resources/hudson/plugins/emailext/Messages.properties src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherTest.java http://jenkins-ci.org/commit/email-ext-plugin/6fb41818d63ca0067171f8c01fcdbed196335b44 Log: [FIXED JENKINS-16376] Never wait for previous builds to complete just to get a more precise status. If and when we need to know the status of a previous build but it is still running, simply print a warning to the (current build’s) log and proceed as if the previous build did not exist.

Greg Temchenko added a comment - 2013-12-05 07:06

When do you plan the next release? This is the highly anticipated feature.

Greg Temchenko added a comment - 2013-12-05 07:06 When do you plan the next release? This is the highly anticipated feature.

m_broida added a comment - 2014-07-22 19:10

This is not fixed in 1.542.
We're waiting for this fix before we upgrade.
Changelog does not show this issue (or any of the duplicated/related issues) have ever been incorporated/released.
When will this fix be incorporated?

m_broida added a comment - 2014-07-22 19:10 This is not fixed in 1.542. We're waiting for this fix before we upgrade. Changelog does not show this issue (or any of the duplicated/related issues) have ever been incorporated/released. When will this fix be incorporated?

Alex Earl added a comment - 2014-07-22 19:31

What do you mean 1.542? This is a bug against email-ext, not core. Email-ext does not have a version 1.542.

Alex Earl added a comment - 2014-07-22 19:31 What do you mean 1.542? This is a bug against email-ext, not core. Email-ext does not have a version 1.542.

m_broida added a comment - 2014-07-22 21:25

Sorry. I reached this issue from a different issue and thought it was still against Jenkins itself.
I meant Jenkins version 1.542.

I see from the email-ext changelog that version 2.37 has this fix in it.
We're using 2.36, so an update should fix this for us. Thanks!

m_broida added a comment - 2014-07-22 21:25 Sorry. I reached this issue from a different issue and thought it was still against Jenkins itself. I meant Jenkins version 1.542. I see from the email-ext changelog that version 2.37 has this fix in it. We're using 2.36, so an update should fix this for us. Thanks!

Sandeep Dhingra added a comment - 2014-12-11 22:22

We need this to be change for performance publisher plugin too. Can I contribute?

https://github.com/jenkinsci/performance-plugin/search?utf8=%E2%9C%93&q=BuildStepMonitor+getRequiredMonitorService

Thanks

Sandeep Dhingra added a comment - 2014-12-11 22:22 We need this to be change for performance publisher plugin too. Can I contribute? https://github.com/jenkinsci/performance-plugin/search?utf8=%E2%9C%93&q=BuildStepMonitor+getRequiredMonitorService Thanks

Alex Earl added a comment - 2014-12-11 22:41

Please open a new issue for the performance plugin. This issue is for email-ext.

Alex Earl added a comment - 2014-12-11 22:41 Please open a new issue for the performance plugin. This issue is for email-ext.

Assignee:: Jesse Glick

Reporter:: Fredrik Jonsson

Votes:: 4 Vote for this issue

Watchers:: 18 Start watching this issue

Created:: 2013-01-16 14:06

Updated:: 2014-12-11 22:41

Resolved:: 2013-11-06 13:33

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Alex Earl added a comment - 2013-11-05 20:49

Expand comment: Alex Earl added a comment - 2013-11-05 20:49

Collapse comment: Jesse Glick added a comment - 2013-11-05 22:21

Expand comment: Jesse Glick added a comment - 2013-11-05 22:21

Collapse comment: Alex Earl added a comment - 2013-11-05 22:58

Expand comment: Alex Earl added a comment - 2013-11-05 22:58

Collapse comment: SCM/JIRA link daemon added a comment - 2013-11-06 13:33

Expand comment: SCM/JIRA link daemon added a comment - 2013-11-06 13:33

Collapse comment: Greg Temchenko added a comment - 2013-12-05 07:06

Expand comment: Greg Temchenko added a comment - 2013-12-05 07:06

Collapse comment: m_broida added a comment - 2014-07-22 19:10

Expand comment: m_broida added a comment - 2014-07-22 19:10

Collapse comment: Alex Earl added a comment - 2014-07-22 19:31

Expand comment: Alex Earl added a comment - 2014-07-22 19:31

Collapse comment: m_broida added a comment - 2014-07-22 21:25

Expand comment: m_broida added a comment - 2014-07-22 21:25

Collapse comment: Sandeep Dhingra added a comment - 2014-12-11 22:22

Expand comment: Sandeep Dhingra added a comment - 2014-12-11 22:22

Collapse comment: Alex Earl added a comment - 2014-12-11 22:41

Expand comment: Alex Earl added a comment - 2014-12-11 22:41

People

Dates