Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16659

TriggerBuilder builds based on parameter value should be listed as downstream builds

      This is similar to issue JENKINS-11082, issue JENKINS-9263, issue JENKINS-5184.

      The only difference is how the "Projects to build" value is set.

      In my case I build an environment variable "$TO_TRIGGER" dynamically and simply put it in the text box, "parameterized trigger" does the job of expanding it to the job names well. The only problem is that although the projects are triggered and in the console log it is listed as if they were triggered successfully, see log:
      Waiting for the completion of trigger1
      trigger1 trigger1----#2 completed. Result was SUCCESS
      Build step 'Trigger/call builds on other projects' changed build result to SUCCESS
      Finished: SUCCESS

      They still don't appear as downstream builds, nor do they upstream build appear as upstream build in the downstream build.

          [JENKINS-16659] TriggerBuilder builds based on parameter value should be listed as downstream builds

          cjo9900 added a comment -

          The pull request[1] from wolfs will fix this at the build level, and list them on the build page, for the triggered downstream builds.
          And the triggered builds will have started by Upstream cause linking to the correct build.

          However the project page will not be able to display these links as the parameters do not exist so cannot be evaluated, which is why there are not shown in the upstream/downstream list.

          [1] https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19

          cjo9900 added a comment - The pull request [1] from wolfs will fix this at the build level, and list them on the build page, for the triggered downstream builds. And the triggered builds will have started by Upstream cause linking to the correct build. However the project page will not be able to display these links as the parameters do not exist so cannot be evaluated, which is why there are not shown in the upstream/downstream list. [1] https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19

          I can't apply the pull request to the master. It looks like all the changes are already merged. Is it possible or am I doing it wrong?

          I'm cloning the repo with:
          git clone https://github.com/jenkinsci/parameterized-trigger-plugin.git

          Then applying the patch using (using --whitespace=fix because of whitespace errors):
          curl https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19.patch | git am --whitespace=fix

          Trying to use the master didn't resolve the issue though.

          Benjamin Kemper added a comment - I can't apply the pull request to the master. It looks like all the changes are already merged. Is it possible or am I doing it wrong? I'm cloning the repo with: git clone https://github.com/jenkinsci/parameterized-trigger-plugin.git Then applying the patch using (using --whitespace=fix because of whitespace errors): curl https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19.patch | git am --whitespace=fix Trying to use the master didn't resolve the issue though.

          cjo9900 added a comment -

          Seeing as you can clone the master repo,
          there is a pre-merged branch available named 2.17-RC

          you should be able to swap to use that using

          git checkout -b 2.17-RC remotes/origin/2.17-RC
          

          then do a mvn clean install.

          Note: this is under testing so make sure you backup any critical jenkins data first and look at the commit log for it to see if any of the other pull requests cause you issues.

          Otherwise have you tried following the merge commands in the pull request itself.

          create a branch
          pull branch from src repo
          merge into current branch.

          and for pull 19 this is

          git checkout -b wolfs-without-deps master
          git pull git://github.com/wolfs/parameterized-trigger-plugin.git without-deps
          

          This will then give you a branch with these changes.

          and if you then want that branch merged into master

          git checkout master
          git merge wolfs-without-deps
          git push origin master
          

          cjo9900 added a comment - Seeing as you can clone the master repo, there is a pre-merged branch available named 2.17-RC you should be able to swap to use that using git checkout -b 2.17-RC remotes/origin/2.17-RC then do a mvn clean install. Note: this is under testing so make sure you backup any critical jenkins data first and look at the commit log for it to see if any of the other pull requests cause you issues. Otherwise have you tried following the merge commands in the pull request itself. create a branch pull branch from src repo merge into current branch. and for pull 19 this is git checkout -b wolfs-without-deps master git pull git: //github.com/wolfs/parameterized-trigger-plugin.git without-deps This will then give you a branch with these changes. and if you then want that branch merged into master git checkout master git merge wolfs-without-deps git push origin master

          Thanks!

          I've used the RC and it did the trick. When is it expected to be released?

          Benjamin Kemper added a comment - Thanks! I've used the RC and it did the trick. When is it expected to be released?

          Fixed in 2.17-RC.

          Benjamin Kemper added a comment - Fixed in 2.17-RC.

            huybrechts huybrechts
            benjamin_kemper Benjamin Kemper
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: