Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5184

No up/downstream indication when using Parameterized Build Trigger plugin

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • None
    • Hudson 1.338
      Parameterized Trigger Plugin 2.0

      (Copy of mail from Tim Arant on Hudson User list)

      I have noticed some issues related to Up-Stream and Down-Stream projects.

      Build other projects

      When this option is checked and a Down-Stream project is supplied, hyper-links appear on each related Project page that there is an Up-Stream or Down-Stream project associated with the Project being viewed,

      Trigger parameterized build on other projects

      When this option is checked and a Down-Stream project is supplied, no hyper-links appear on each related Project page. I realize that this is part of the Trigger plug-in, but it would be nice if this plug-in simply modified the existing "Build other projects" and allowed parameter definition, or, have this plug-in create the hyper-link relationships.

          [JENKINS-5184] No up/downstream indication when using Parameterized Build Trigger plugin

          Alan Harder added a comment -

          Update in Hudson core completed and will be in Hudson 1.341 (JENKINS-5236). I have local changes ready to make use of this in parameterized trigger plugin, and will commit once 1.341 is out. I set it up so it will take advantage of this feature if you have 1.341 or higher, but the plugin will still work with 1.319 or higher.

          Alan Harder added a comment - Update in Hudson core completed and will be in Hudson 1.341 ( JENKINS-5236 ). I have local changes ready to make use of this in parameterized trigger plugin, and will commit once 1.341 is out. I set it up so it will take advantage of this feature if you have 1.341 or higher, but the plugin will still work with 1.319 or higher.

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/plugins/parameterized-trigger/pom.xml
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/AbstractBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/CurrentBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/ParameterizedDependency.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/SubversionRevisionBuildParameters.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/CurrentBuildParametersTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DefaultParametersTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DontBuildTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/PredefinedPropertiesBuildTriggerConfigTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/ResultConditionTest.java
          trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/SubversionRevisionBuildTriggerConfigTest.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=25910
          Log:
          [FIXED JENKINS-5184] Use new DependencyGraph.Dependency API in Hudson core (1.341+)
          to declare downstream projects and invoke them with appropriate parameters.
          Plugin now builds against 1.341, but it is coded to only use the new API when
          present, so minimum Hudson version for this plugin is now 1.319.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/plugins/parameterized-trigger/pom.xml trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/AbstractBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/CurrentBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/ParameterizedDependency.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/PredefinedBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/main/java/hudson/plugins/parameterizedtrigger/SubversionRevisionBuildParameters.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/CurrentBuildParametersTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DefaultParametersTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/DontBuildTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/PredefinedPropertiesBuildTriggerConfigTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/ResultConditionTest.java trunk/hudson/plugins/parameterized-trigger/src/test/java/hudson/plugins/parameterizedtrigger/test/SubversionRevisionBuildTriggerConfigTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=25910 Log: [FIXED JENKINS-5184] Use new DependencyGraph.Dependency API in Hudson core (1.341+) to declare downstream projects and invoke them with appropriate parameters. Plugin now builds against 1.341, but it is coded to only use the new API when present, so minimum Hudson version for this plugin is now 1.319.

          Eric Smalling added a comment -

          Still seeing this behavior on v1.381 and the following project setup:
          Maven 2 based project "Foo_Build", trigging a chain of Free-Style projects named "Foo_Test_something" with the param'd trigger plugin v2.4

          Eric Smalling added a comment - Still seeing this behavior on v1.381 and the following project setup: Maven 2 based project "Foo_Build", trigging a chain of Free-Style projects named "Foo_Test_something" with the param'd trigger plugin v2.4

          Eric Smalling added a comment -

          On Jenkins 1.413, this is still an issue - getting very annoying as plugins like the Pipeline view depend on this.

          Eric Smalling added a comment - On Jenkins 1.413, this is still an issue - getting very annoying as plugins like the Pipeline view depend on this.

          banoss added a comment - - edited

          v2.10 of the plugin and Jenkins v1.421 this is indeed still a problem. Do we also need to re-open JENKINS-5761?

          banoss added a comment - - edited v2.10 of the plugin and Jenkins v1.421 this is indeed still a problem. Do we also need to re-open JENKINS-5761 ?

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/a23dfab2775e2ffb84d5aa73da4533e971c690cb
          Log:
          [FIXED JENKINS-11082, FIXED JENKINS-9263, FIXED JENKINS-5184] Builds
          triggered as build steps will now show up in the dependency graph.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java http://jenkins-ci.org/commit/parameterized-trigger-plugin/a23dfab2775e2ffb84d5aa73da4533e971c690cb Log: [FIXED JENKINS-11082, FIXED JENKINS-9263, FIXED JENKINS-5184] Builds triggered as build steps will now show up in the dependency graph.

          dogfood added a comment -

          Integrated in plugins_parameterized-trigger #28
          [FIXED JENKINS-11082, FIXED JENKINS-9263, FIXED JENKINS-5184] Builds

          Andrew Bayer :
          Files :

          • src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

          dogfood added a comment - Integrated in plugins_parameterized-trigger #28 [FIXED JENKINS-11082, FIXED JENKINS-9263, FIXED JENKINS-5184] Builds Andrew Bayer : Files : src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

          evernat added a comment -

          committed so resolving as fixed, please reopen if needed

          evernat added a comment - committed so resolving as fixed, please reopen if needed

          Mark MacVicar added a comment -

          This issue is still occurring for us with Parameterized Trigger Plugin 2.17 and jenkins 1.504. The Downstream Build View plugin feature is able to see all the downstream jobs, but the job status page displays:

          Downstream Builds
          project_name(none)

          Mark MacVicar added a comment - This issue is still occurring for us with Parameterized Trigger Plugin 2.17 and jenkins 1.504. The Downstream Build View plugin feature is able to see all the downstream jobs, but the job status page displays: Downstream Builds project_name(none)

          Yang Li added a comment -

          Afte applied the Jenkins upgrade from v1.480 to v1.532.3, I found the concept of Jenkins Groovy API ‘getDownstreamProject()’ defined in AbstractProject class has been changed. In v1.480, all the post-build jobs and triggered jobs(using build trigger plugin) are treated as downstream job and will be retrieved by the API. However, in v1.532.1, only jobs triggered as post-build step is treated as downstream job.

          I want to know what's the proper API to use in order to get the triggered jobs information?

          Yang Li added a comment - Afte applied the Jenkins upgrade from v1.480 to v1.532.3, I found the concept of Jenkins Groovy API ‘getDownstreamProject()’ defined in AbstractProject class has been changed. In v1.480, all the post-build jobs and triggered jobs(using build trigger plugin) are treated as downstream job and will be retrieved by the API. However, in v1.532.1, only jobs triggered as post-build step is treated as downstream job. I want to know what's the proper API to use in order to get the triggered jobs information?

            abayer Andrew Bayer
            ridesmet Ringo De Smet
            Votes:
            7 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: