Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17248

java.lang.NullPointerException in global-build-stats plug-in at startup

      Web interface just shows

      java.lang.NullPointerException
      	at com.thoughtworks.xstream.converters.ConversionException.add(ConversionException.java:65)
      	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1066)
      	at hudson.util.XStream2.unmarshal(XStream2.java:109)
      	at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1045)
      	at hudson.XmlFile.unmarshal(XmlFile.java:166)
      	at hudson.Plugin.load(Plugin.java:239)
      	at hudson.plugins.global_build_stats.GlobalBuildStatsPlugin.load(GlobalBuildStatsPlugin.java:98)
      	at hudson.plugins.global_build_stats.business.GlobalBuildStatsPluginSaver.reloadPlugin(GlobalBuildStatsPluginSaver.java:98)
      	at hudson.plugins.global_build_stats.business.GlobalBuildStatsBusiness.reloadPlugin(GlobalBuildStatsBusiness.java:382)
      	at hudson.plugins.global_build_stats.GlobalBuildStatsPlugin$GlobalBuildStatsItemListener.onLoaded(GlobalBuildStatsPlugin.java:149)
      	at jenkins.model.Jenkins.<init>(Jenkins.java:849)
      	at hudson.model.Hudson.<init>(Hudson.java:81)
      	at hudson.model.Hudson.<init>(Hudson.java:77)
      	at hudson.WebAppMain$2.run(WebAppMain.java:214)
      

          [JENKINS-17248] java.lang.NullPointerException in global-build-stats plug-in at startup

          Jesse Glick added a comment -

          By the way steps to reproduce would still be valuable here because there may be some bug in the plugin which is triggering the XStream bug and which could be solved in parallel.

          Jesse Glick added a comment - By the way steps to reproduce would still be valuable here because there may be some bug in the plugin which is triggering the XStream bug and which could be solved in parallel.

          Jesse Glick added a comment -

          Jesse Glick added a comment - Filed https://github.com/jenkinsci/global-build-stats-plugin/pull/4 for robustness.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/model/Jenkins.java
          http://jenkins-ci.org/commit/jenkins/4def416224074c611f41185bd4e2dd0b68bcba5d
          Log:
          JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/4def416224074c611f41185bd4e2dd0b68bcba5d Log: JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/d3fa3bc906c7cb88c267f36b8eba1150435f9aaf
          Log:
          JENKINS-18775 JENKINS-17248 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/d3fa3bc906c7cb88c267f36b8eba1150435f9aaf Log: JENKINS-18775 JENKINS-17248 Noting.

          Thanks Jesse

          +1 for reproductibility steps in order to see if the migration to 1.4.4-jenkins-4 is fixing the issue.

          Wondering if we shouldn't keep this issue closed until we have these reproductibility steps.

          Frédéric Camblor added a comment - Thanks Jesse +1 for reproductibility steps in order to see if the migration to 1.4.4-jenkins-4 is fixing the issue. Wondering if we shouldn't keep this issue closed until we have these reproductibility steps.

          Jesse Glick added a comment -

          Wondering if we shouldn't keep this issue closed

          Do you mean “open”? I think not, since there are now two fixes in core that should prevent the NPE from halting startup (besides the third proposed in the plugin).

          Jesse Glick added a comment - Wondering if we shouldn't keep this issue closed Do you mean “open”? I think not, since there are now two fixes in core that should prevent the NPE from halting startup (besides the third proposed in the plugin).

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2834
          JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup. (Revision 4def416224074c611f41185bd4e2dd0b68bcba5d)
          JENKINS-18775 JENKINS-17248 Noting. (Revision d3fa3bc906c7cb88c267f36b8eba1150435f9aaf)

          Result = UNSTABLE
          Jesse Glick : 4def416224074c611f41185bd4e2dd0b68bcba5d
          Files :

          • core/src/main/java/jenkins/model/Jenkins.java

          Jesse Glick : d3fa3bc906c7cb88c267f36b8eba1150435f9aaf
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2834 JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup. (Revision 4def416224074c611f41185bd4e2dd0b68bcba5d) JENKINS-18775 JENKINS-17248 Noting. (Revision d3fa3bc906c7cb88c267f36b8eba1150435f9aaf) Result = UNSTABLE Jesse Glick : 4def416224074c611f41185bd4e2dd0b68bcba5d Files : core/src/main/java/jenkins/model/Jenkins.java Jesse Glick : d3fa3bc906c7cb88c267f36b8eba1150435f9aaf Files : changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/plugins/global_build_stats/business/GlobalBuildStatsPluginSaver.java
          http://jenkins-ci.org/commit/global-build-stats-plugin/30198e54a232605143ab6018cdcdb31a40100247
          Log:
          JENKINS-17248 Robustness against NPE, unless and until root issue is diagnosed, or people start running with patched XStream.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/global_build_stats/business/GlobalBuildStatsPluginSaver.java http://jenkins-ci.org/commit/global-build-stats-plugin/30198e54a232605143ab6018cdcdb31a40100247 Log: JENKINS-17248 Robustness against NPE, unless and until root issue is diagnosed, or people start running with patched XStream.

          Code changed in jenkins
          User: Frédéric Camblor
          Path:
          src/main/java/hudson/plugins/global_build_stats/GlobalBuildStatsPlugin.java
          src/main/java/hudson/plugins/global_build_stats/business/GlobalBuildStatsPluginSaver.java
          http://jenkins-ci.org/commit/global-build-stats-plugin/dff58df2ea84b93e82c613072809b0b402a5bc89
          Log:
          Merge pull request #4 from jglick/NPE-JENKINS-17248

          JENKINS-17248 Robustness against NPE

          Compare: https://github.com/jenkinsci/global-build-stats-plugin/compare/2b4f1b35e597...dff58df2ea84

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Frédéric Camblor Path: src/main/java/hudson/plugins/global_build_stats/GlobalBuildStatsPlugin.java src/main/java/hudson/plugins/global_build_stats/business/GlobalBuildStatsPluginSaver.java http://jenkins-ci.org/commit/global-build-stats-plugin/dff58df2ea84b93e82c613072809b0b402a5bc89 Log: Merge pull request #4 from jglick/NPE- JENKINS-17248 JENKINS-17248 Robustness against NPE Compare: https://github.com/jenkinsci/global-build-stats-plugin/compare/2b4f1b35e597...dff58df2ea84

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/model/Jenkins.java
          http://jenkins-ci.org/commit/jenkins/08c189234b0599d6ec9ee81d9fd7f8b3a2bd5ff3
          Log:
          JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup.

          (cherry picked from commit 4def416224074c611f41185bd4e2dd0b68bcba5d)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/08c189234b0599d6ec9ee81d9fd7f8b3a2bd5ff3 Log: JENKINS-17248 Be robust against exceptions in ItemListener.onLoaded, since this could interrupt Jenkins startup. (cherry picked from commit 4def416224074c611f41185bd4e2dd0b68bcba5d)

            jglick Jesse Glick
            corti Matteo Corti
            Votes:
            10 Vote for this issue
            Watchers:
            21 Start watching this issue

              Created:
              Updated:
              Resolved: