-
Bug
-
Resolution: Fixed
-
Major
On tapResults page, if the output of a given test contains HTML, it renders it out onto the tapResults report wholesale and unescaped.
If the HTML is partial, it can lead to some output being outside of a result table or missing on render entirely.
To illustrate what I mean, I've included some offending TAP file content and some screenshots of the results(masking applied by me to protect some data).
# <div id="PageWrapper"> # # <div id="Header"> # <div class="Liner"> # </div><!-- end Liner --> # </div><!-- end Header --> # <div id="ContentWrapper"> # <div id="ContentColumn"> # <div class="Liner"> # # # </div><!-- end Liner --> # </div><!-- end ContentColumn --> # </div><!-- end ContentWrapper --> # # <div id="NavColumn"> # <div class="Liner"> # </div><!-- end Liner --> # </div><!-- end NavColumn --> #
[JENKINS-17878] HTML test output in tapResults not escaped
Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/org/tap4j/plugin/TapParser.java
src/main/java/org/tap4j/plugin/TapResult.java
src/main/resources/org/tap4j/plugin/tags/line.jelly
http://jenkins-ci.org/commit/tap-plugin/279e1204335f2092f6beeababf174068223b6047
Log:
JENKINS-17878 Escape HTML in test results comments
To be released tonight, probably tomorrow by noon it will be available in 1.12 via update site. Thanks!
Thanks for reporting and including the HTML snippet and screenshots Real. I'll take a look on it as soon as I find time to work on tap-plugin again.