Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18074

When copying folder, display names of contained jobs are gratuitously cleared

      DisplayNameListener.onCopied clears the display name of a job after it has been copied, which only makes sense for a copy within the same item group.

          [JENKINS-18074] When copying folder, display names of contained jobs are gratuitously cleared

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/DisplayNameListener.java
          test/src/main/java/org/jvnet/hudson/test/MockFolder.java
          test/src/test/java/hudson/model/DisplayNameTest.java
          http://jenkins-ci.org/commit/jenkins/04e2ccade6c831578bdd32b5e5982cf150f635f4
          Log:
          [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different.

          Compare: https://github.com/jenkinsci/jenkins/compare/476fe22d6ed0...04e2ccade6c8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/DisplayNameListener.java test/src/main/java/org/jvnet/hudson/test/MockFolder.java test/src/test/java/hudson/model/DisplayNameTest.java http://jenkins-ci.org/commit/jenkins/04e2ccade6c831578bdd32b5e5982cf150f635f4 Log: [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. Compare: https://github.com/jenkinsci/jenkins/compare/476fe22d6ed0...04e2ccade6c8

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2545
          [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. (Revision 04e2ccade6c831578bdd32b5e5982cf150f635f4)

          Result = UNSTABLE
          Jesse Glick : 04e2ccade6c831578bdd32b5e5982cf150f635f4
          Files :

          • core/src/main/java/hudson/model/DisplayNameListener.java
          • test/src/test/java/hudson/model/DisplayNameTest.java
          • test/src/main/java/org/jvnet/hudson/test/MockFolder.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2545 [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. (Revision 04e2ccade6c831578bdd32b5e5982cf150f635f4) Result = UNSTABLE Jesse Glick : 04e2ccade6c831578bdd32b5e5982cf150f635f4 Files : core/src/main/java/hudson/model/DisplayNameListener.java test/src/test/java/hudson/model/DisplayNameTest.java test/src/main/java/org/jvnet/hudson/test/MockFolder.java changelog.html

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/test/java/hudson/model/StubJob.java
          http://jenkins-ci.org/commit/jenkins/8aed6623900e8827b587389e6af7958f05ecab87
          Log:
          JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving.
          https://ci.jenkins-ci.org/job/jenkins_main_trunk/2545/testReport/junit/hudson.model/DisplayNameListenerTest/testOnCopied/

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/test/java/hudson/model/StubJob.java http://jenkins-ci.org/commit/jenkins/8aed6623900e8827b587389e6af7958f05ecab87 Log: JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving. https://ci.jenkins-ci.org/job/jenkins_main_trunk/2545/testReport/junit/hudson.model/DisplayNameListenerTest/testOnCopied/

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2546
          JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving. (Revision 8aed6623900e8827b587389e6af7958f05ecab87)

          Result = SUCCESS
          Jesse Glick : 8aed6623900e8827b587389e6af7958f05ecab87
          Files :

          • core/src/test/java/hudson/model/StubJob.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2546 JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving. (Revision 8aed6623900e8827b587389e6af7958f05ecab87) Result = SUCCESS Jesse Glick : 8aed6623900e8827b587389e6af7958f05ecab87 Files : core/src/test/java/hudson/model/StubJob.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/DisplayNameListener.java
          http://jenkins-ci.org/commit/jenkins/73706a45bce4bdce211f01a16bc8937f9c811bce
          Log:
          JENKINS-18074 Updated comment.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/DisplayNameListener.java http://jenkins-ci.org/commit/jenkins/73706a45bce4bdce211f01a16bc8937f9c811bce Log: JENKINS-18074 Updated comment.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2554
          JENKINS-18074 Updated comment. (Revision 73706a45bce4bdce211f01a16bc8937f9c811bce)

          Result = SUCCESS
          Jesse Glick : 73706a45bce4bdce211f01a16bc8937f9c811bce
          Files :

          • core/src/main/java/hudson/model/DisplayNameListener.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2554 JENKINS-18074 Updated comment. (Revision 73706a45bce4bdce211f01a16bc8937f9c811bce) Result = SUCCESS Jesse Glick : 73706a45bce4bdce211f01a16bc8937f9c811bce Files : core/src/main/java/hudson/model/DisplayNameListener.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/DisplayNameListener.java
          test/src/main/java/org/jvnet/hudson/test/MockFolder.java
          test/src/test/java/hudson/model/DisplayNameTest.java
          http://jenkins-ci.org/commit/jenkins/c0102e771ea5164cc896e3a7cf08df732c85a5fb
          Log:
          [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different.
          (cherry picked from commit 04e2ccade6c831578bdd32b5e5982cf150f635f4)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/DisplayNameListener.java test/src/main/java/org/jvnet/hudson/test/MockFolder.java test/src/test/java/hudson/model/DisplayNameTest.java http://jenkins-ci.org/commit/jenkins/c0102e771ea5164cc896e3a7cf08df732c85a5fb Log: [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. (cherry picked from commit 04e2ccade6c831578bdd32b5e5982cf150f635f4)

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/test/java/hudson/model/StubJob.java
          http://jenkins-ci.org/commit/jenkins/4dccb6e911a894246ae56de1452ffa2521f061d9
          Log:
          JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving.
          https://ci.jenkins-ci.org/job/jenkins_main_trunk/2545/testReport/junit/hudson.model/DisplayNameListenerTest/testOnCopied/
          (cherry picked from commit 8aed6623900e8827b587389e6af7958f05ecab87)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/test/java/hudson/model/StubJob.java http://jenkins-ci.org/commit/jenkins/4dccb6e911a894246ae56de1452ffa2521f061d9 Log: JENKINS-18074 Fixed unit test by making StubJob.getParent forgiving. https://ci.jenkins-ci.org/job/jenkins_main_trunk/2545/testReport/junit/hudson.model/DisplayNameListenerTest/testOnCopied/ (cherry picked from commit 8aed6623900e8827b587389e6af7958f05ecab87)

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/DisplayNameListener.java
          http://jenkins-ci.org/commit/jenkins/a8e3b4f8ed03d1bc7d4e0eee695710cbd5de4b19
          Log:
          JENKINS-18074 Updated comment.

          (cherry picked from commit 73706a45bce4bdce211f01a16bc8937f9c811bce)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/DisplayNameListener.java http://jenkins-ci.org/commit/jenkins/a8e3b4f8ed03d1bc7d4e0eee695710cbd5de4b19 Log: JENKINS-18074 Updated comment. (cherry picked from commit 73706a45bce4bdce211f01a16bc8937f9c811bce)

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/MockFolder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/15800d106fcfc115dfd3214f7388ad2b576f02f0
          Log:
          [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different.
          Originally-Committed-As: 04e2ccade6c831578bdd32b5e5982cf150f635f4

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/MockFolder.java http://jenkins-ci.org/commit/jenkins-test-harness/15800d106fcfc115dfd3214f7388ad2b576f02f0 Log: [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. Originally-Committed-As: 04e2ccade6c831578bdd32b5e5982cf150f635f4

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: