Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18641

People View does Not Populate (makeStaplerProxy)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Windows Server 2008, Debian 7, Ubuntu 12.04, CentOS 6.4

      On entering the "People" view on Jenkins, some page elements load while the list of people is not. Instead a message displays along the lines of:

      makeStaplerProxy('/jenkins/$stapler/bound/7544a1d9-a6f5-44ea-8a6f-ccfd839f03e9','65215ee9-8e24-4f45-96b9-4e34a01b79cf',['news']), display);

          [JENKINS-18641] People View does Not Populate (makeStaplerProxy)

          William Whittle added a comment - - edited

          I'm also seeing this on 1.525 running on CentOS 6.3 (EC2 AMI: ami-eb0b8082). I don't see the issue when running the same Jenkins build on Windows 7.

          William Whittle added a comment - - edited I'm also seeing this on 1.525 running on CentOS 6.3 (EC2 AMI: ami-eb0b8082). I don't see the issue when running the same Jenkins build on Windows 7.

          Shannon Kerr added a comment -

          Confirmed this bug is not Fixed. I am running 1.525 on Ubuntu 12.04 Server + Chrome browser:

          Includes all known “users”, including login identities which the current security realm can enumerate, as well as people mentioned in commit messages in recorded changelogs.

          makeStaplerProxy('/$stapler/bound/a7d06408-0c93-483a-8910-c36b2295fa1f','154d0cb7-97a2-4f82-abda-bd46caf6ff29',['news']), display);

          Shannon Kerr added a comment - Confirmed this bug is not Fixed. I am running 1.525 on Ubuntu 12.04 Server + Chrome browser: Includes all known “users”, including login identities which the current security realm can enumerate, as well as people mentioned in commit messages in recorded changelogs. makeStaplerProxy('/$stapler/bound/a7d06408-0c93-483a-8910-c36b2295fa1f','154d0cb7-97a2-4f82-abda-bd46caf6ff29', ['news'] ), display);

          Shannon Kerr added a comment -

          Does not appear to be fixed in 1.525.

          Shannon Kerr added a comment - Does not appear to be fixed in 1.525.

          Jesse Glick added a comment -

          I think there is nothing wrong with the fix, it is just in 1.526, not 1.525 which is in fact identical to 1.524.

          Jesse Glick added a comment - I think there is nothing wrong with the fix, it is just in 1.526, not 1.525 which is in fact identical to 1.524.

          Shannon Kerr added a comment -

          OK, thanks Jesse. When I looked at the package size for Ubuntu, I did see the 1.525 was slightly larger than 1.524, so I didn't make that connection.

          Shannon Kerr added a comment - OK, thanks Jesse. When I looked at the package size for Ubuntu, I did see the 1.525 was slightly larger than 1.524, so I didn't make that connection.

          Jesse Glick added a comment -

          The same bug applies to other users of <st:bind>. @rsandell suggests adding to layout.jelly:

          <st:adjunct assumes="org.kohsuke.stapler.framework.prototype.prototype"
                          includes="org.kohsuke.stapler.json2"/>
          

          right after the existing include of org.kohsuke.stapler.bind. Needs to be tested for effectiveness (after reverting the original fix of this issue).

          Jesse Glick added a comment - The same bug applies to other users of <st:bind> . @rsandell suggests adding to layout.jelly : <st:adjunct assumes= "org.kohsuke.stapler.framework.prototype.prototype" includes= "org.kohsuke.stapler.json2" /> right after the existing include of org.kohsuke.stapler.bind . Needs to be tested for effectiveness (after reverting the original fix of this issue).

          Actually, I think BindTag's inclusion logic is wrong.

          The idea is that we need either prototype or JQuery for <st:bind> to work correctly.

          If the current page already includes Prototype, there's no need to have "org.kohsuke.stapler.json2" adjunct, as we don't use JSON.stringify()

          In Jenkins, every page automatically gets prototype, so there's never a need for this inclusion.

          I'm going to fix this by tweaking BindTag.java.

          A test can be written by simulating an insertion of jQuery adjunct into the page, so it should be testable.

          Kohsuke Kawaguchi added a comment - Actually, I think BindTag's inclusion logic is wrong. The idea is that we need either prototype or JQuery for <st:bind> to work correctly. If the current page already includes Prototype, there's no need to have "org.kohsuke.stapler.json2" adjunct, as we don't use JSON.stringify() In Jenkins, every page automatically gets prototype, so there's never a need for this inclusion. I'm going to fix this by tweaking BindTag.java. A test can be written by simulating an insertion of jQuery adjunct into the page, so it should be testable.

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/pom.xml
          http://jenkins-ci.org/commit/jenkins/7e8bbea3336dc65a10c2fd69a20beac20bc6fca3
          Log:
          [FIXED JENKINS-18641]

          Eliminated the wrong script tag generation from <st:bind/>

          Compare: https://github.com/jenkinsci/jenkins/compare/738a1d116409...7e8bbea3336d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/7e8bbea3336dc65a10c2fd69a20beac20bc6fca3 Log: [FIXED JENKINS-18641] Eliminated the wrong script tag generation from <st:bind/> Compare: https://github.com/jenkinsci/jenkins/compare/738a1d116409...7e8bbea3336d

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2795

          Result = UNSTABLE

          dogfood added a comment - Integrated in jenkins_main_trunk #2795 Result = UNSTABLE

          Stapler 1.217 cause some regressions JENKINS-19281 and JENKINS-19168

          Philippe Jandot added a comment - Stapler 1.217 cause some regressions JENKINS-19281 and JENKINS-19168

            sogabe sogabe
            zulu12 Wilfredo Velazquez
            Votes:
            8 Vote for this issue
            Watchers:
            18 Start watching this issue

              Created:
              Updated:
              Resolved: