Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18846

New lazy loading permalinks can break job.lastStableBuild != null => job.lastSuccessfulBuild != null

      I have seen this on some Maven module builds, especially ones where only some of the modules in the pom are build, e.g. by using `-pl some-module -am`

      The MavenModuleSet will have both lastSuccessfulBuild and lastStableBuild defined.

      The individual MavenModule instances, however, will only have lastStable defined.

          [JENKINS-18846] New lazy loading permalinks can break job.lastStableBuild != null => job.lastSuccessfulBuild != null

          Jesse Glick added a comment -

          The symptom described in JENKINS-19034 seems to be a corollary of this; the fix proposed for that is retroactive, whereas the fix for this would be proactive.

          Jesse Glick added a comment - The symptom described in JENKINS-19034 seems to be a corollary of this; the fix proposed for that is retroactive, whereas the fix for this would be proactive.

          Jesse Glick added a comment -

          As far as I can tell, the actual symlinks have been incomplete or absent for Maven module builds for a long time; but this did not have a visible impact until JENKINS-16089 started using lastSuccessfulBuild to implement getLastSuccessfulBuild.

          Jesse Glick added a comment - As far as I can tell, the actual symlinks have been incomplete or absent for Maven module builds for a long time; but this did not have a visible impact until JENKINS-16089 started using lastSuccessfulBuild to implement getLastSuccessfulBuild .

          Jesse Glick added a comment -

          …and JENKINS-16023 started using other permalinks.

          Jesse Glick added a comment - …and JENKINS-16023 started using other permalinks.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/Run.java
          maven-plugin/src/main/java/hudson/maven/MavenBuild.java
          test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          http://jenkins-ci.org/commit/jenkins/a92e9da978262c6a7e4d74d3b2750319cbc748fb
          Log:
          [FIXED JENKINS-18846] Update symlinks for Maven module builds.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/a92e9da978262c6a7e4d74d3b2750319cbc748fb Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2824
          [FIXED JENKINS-18846] Update symlinks for Maven module builds. (Revision a92e9da978262c6a7e4d74d3b2750319cbc748fb)

          Result = SUCCESS
          Jesse Glick : a92e9da978262c6a7e4d74d3b2750319cbc748fb
          Files :

          • core/src/main/java/hudson/model/AbstractBuild.java
          • test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          • maven-plugin/src/main/java/hudson/maven/MavenBuild.java
          • changelog.html
          • core/src/main/java/hudson/model/Run.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2824 [FIXED JENKINS-18846] Update symlinks for Maven module builds. (Revision a92e9da978262c6a7e4d74d3b2750319cbc748fb) Result = SUCCESS Jesse Glick : a92e9da978262c6a7e4d74d3b2750319cbc748fb Files : core/src/main/java/hudson/model/AbstractBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java changelog.html core/src/main/java/hudson/model/Run.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/Run.java
          maven-plugin/src/main/java/hudson/maven/MavenBuild.java
          test/src/test/java/hudson/maven/MavenMultiModuleTest.java
          http://jenkins-ci.org/commit/jenkins/92e85f74258526def5b9fd8e10efc5575b4d80bb
          Log:
          [FIXED JENKINS-18846] Update symlinks for Maven module builds.

          (cherry picked from commit a92e9da978262c6a7e4d74d3b2750319cbc748fb)

          Conflicts:
          changelog.html
          test/src/test/java/hudson/maven/MavenMultiModuleTest.java

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/MavenBuild.java test/src/test/java/hudson/maven/MavenMultiModuleTest.java http://jenkins-ci.org/commit/jenkins/92e85f74258526def5b9fd8e10efc5575b4d80bb Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds. (cherry picked from commit a92e9da978262c6a7e4d74d3b2750319cbc748fb) Conflicts: changelog.html test/src/test/java/hudson/maven/MavenMultiModuleTest.java

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/maven/MavenBuild.java
          http://jenkins-ci.org/commit/maven-plugin/3a7e8116feced00bd2f8d1dc6cd071032e3fab0d
          Log:
          [FIXED JENKINS-18846] Update symlinks for Maven module builds.

          Originally-Committed-As: a92e9da978262c6a7e4d74d3b2750319cbc748fb

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenBuild.java http://jenkins-ci.org/commit/maven-plugin/3a7e8116feced00bd2f8d1dc6cd071032e3fab0d Log: [FIXED JENKINS-18846] Update symlinks for Maven module builds. Originally-Committed-As: a92e9da978262c6a7e4d74d3b2750319cbc748fb

            jglick Jesse Glick
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: