Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1920

Plugin Manager: Add support for proxy authentication on non-NTLM systems

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      We're running Hudson on Solaris 10. Connecting to the internet is done via MS
      ISA proxies (require NTLM authentication). Solaris doesn't support NTLM.

      So Hudson's plugin manager should support specifying the proxy's username /
      password and authentication type.

        Attachments

          Issue Links

            Activity

            Hide
            tjuerge tjuerge added a comment -

            This can be easily fixed in ProxyConfiguration by replacing

            con.setRequestProperty("Proxy-Authorization","Basic "+
            Scrambler.scramble(p.getUserName()+':'+p.getPassword()));

            with

            Authenticator.setDefault(new Authenticator() {
            public PasswordAuthentication getPasswordAuthentication()

            { ProxyConfiguration p = Hudson.getInstance().proxy; return new PasswordAuthentication(p.getUserName(), p.getPassword().toCharArray()); }

            });

            A corresponding patch file is attached.

            Show
            tjuerge tjuerge added a comment - This can be easily fixed in ProxyConfiguration by replacing con.setRequestProperty("Proxy-Authorization","Basic "+ Scrambler.scramble(p.getUserName()+':'+p.getPassword())); with Authenticator.setDefault(new Authenticator() { public PasswordAuthentication getPasswordAuthentication() { ProxyConfiguration p = Hudson.getInstance().proxy; return new PasswordAuthentication(p.getUserName(), p.getPassword().toCharArray()); } }); A corresponding patch file is attached.
            Hide
            tjuerge tjuerge added a comment -

            Created an attachment (id=765)
            Patch to fix proxy authentication in class ProxyConfiguration

            Show
            tjuerge tjuerge added a comment - Created an attachment (id=765) Patch to fix proxy authentication in class ProxyConfiguration
            Hide
            tjuerge tjuerge added a comment -

            Created an attachment (id=766)
            Removed obsolete imports from patch

            Show
            tjuerge tjuerge added a comment - Created an attachment (id=766) Removed obsolete imports from patch
            Hide
            tjuerge tjuerge added a comment -

            Created an attachment (id=767)
            Patch with help for using NTLM domain name in the proxy username

            Show
            tjuerge tjuerge added a comment - Created an attachment (id=767) Patch with help for using NTLM domain name in the proxy username
            Hide
            tjuerge tjuerge added a comment -

            patch delivered, waiting for acceptance

            Show
            tjuerge tjuerge added a comment - patch delivered, waiting for acceptance
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            This is merged into the trunk toward 1.316.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - This is merged into the trunk toward 1.316.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              tjuerge tjuerge
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: