Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1920

Plugin Manager: Add support for proxy authentication on non-NTLM systems

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Platform: All, OS: All

      We're running Hudson on Solaris 10. Connecting to the internet is done via MS
      ISA proxies (require NTLM authentication). Solaris doesn't support NTLM.

      So Hudson's plugin manager should support specifying the proxy's username /
      password and authentication type.

          [JENKINS-1920] Plugin Manager: Add support for proxy authentication on non-NTLM systems

          tjuerge added a comment -

          This can be easily fixed in ProxyConfiguration by replacing

          con.setRequestProperty("Proxy-Authorization","Basic "+
          Scrambler.scramble(p.getUserName()+':'+p.getPassword()));

          with

          Authenticator.setDefault(new Authenticator() {
          public PasswordAuthentication getPasswordAuthentication()

          { ProxyConfiguration p = Hudson.getInstance().proxy; return new PasswordAuthentication(p.getUserName(), p.getPassword().toCharArray()); }

          });

          A corresponding patch file is attached.

          tjuerge added a comment - This can be easily fixed in ProxyConfiguration by replacing con.setRequestProperty("Proxy-Authorization","Basic "+ Scrambler.scramble(p.getUserName()+':'+p.getPassword())); with Authenticator.setDefault(new Authenticator() { public PasswordAuthentication getPasswordAuthentication() { ProxyConfiguration p = Hudson.getInstance().proxy; return new PasswordAuthentication(p.getUserName(), p.getPassword().toCharArray()); } }); A corresponding patch file is attached.

          tjuerge added a comment -

          Created an attachment (id=765)
          Patch to fix proxy authentication in class ProxyConfiguration

          tjuerge added a comment - Created an attachment (id=765) Patch to fix proxy authentication in class ProxyConfiguration

          tjuerge added a comment -

          Created an attachment (id=766)
          Removed obsolete imports from patch

          tjuerge added a comment - Created an attachment (id=766) Removed obsolete imports from patch

          tjuerge added a comment -

          Created an attachment (id=767)
          Patch with help for using NTLM domain name in the proxy username

          tjuerge added a comment - Created an attachment (id=767) Patch with help for using NTLM domain name in the proxy username

          tjuerge added a comment -

          patch delivered, waiting for acceptance

          tjuerge added a comment - patch delivered, waiting for acceptance

          This is merged into the trunk toward 1.316.

          Kohsuke Kawaguchi added a comment - This is merged into the trunk toward 1.316.

            Unassigned Unassigned
            tjuerge tjuerge
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: