Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20560

Custom-tools plugin breaks path for android-emulator

    XMLWordPrintable

Details

    Description

      Created for the original issue in JENKINS-19506

      I run customtools-plugin together with android-emulator-plugin, and when jenkins launches tasks for android-emulator, they are launched without the default PATH varable.
      This means that the shell scripts that start the emulator can't find common tools as dirname, file and so on.

      Workaround is to add a custom tool that defines default paths too, but thats site-wide and when some nodes have other PATH's than other, i can only add the directories that exists on all nodes.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19506 [integration] - android-plugin + custom-tools installation fails due to NPE in ProcStarter::envs()

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-15631 When custom tool installation is on SCM checkout fails

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            View 8 older comments
            oleg_nenashev Oleg Nenashev added a comment -

            Thank you too for the testing,
            I'll add some tests and release a public version by the weekend.

            oleg_nenashev Oleg Nenashev added a comment - Thank you too for the testing, I'll add some tests and release a public version by the weekend.
            a_silgidjian Alexander Silgidjian added a comment -

            I also confirm that the patch is working.
            Thanks!

            a_silgidjian Alexander Silgidjian added a comment - I also confirm that the patch is working. Thanks!
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
            src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java
            http://jenkins-ci.org/commit/customtools-plugin/1ed68b4a65642113f4a61da08aa5f2e4da5d5b4b
            Log:
            [FIXED JENKINS-20560] - Custom-tools should not override global paths inside nested launchers

            I've also refactored retrieval of paths list.
            Related to: https://issues.jenkins-ci.org/browse/JENKINS-20560

            Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java http://jenkins-ci.org/commit/customtools-plugin/1ed68b4a65642113f4a61da08aa5f2e4da5d5b4b Log: [FIXED JENKINS-20560] - Custom-tools should not override global paths inside nested launchers I've also refactored retrieval of paths list. Related to: https://issues.jenkins-ci.org/browse/JENKINS-20560 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
            src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java
            src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java
            http://jenkins-ci.org/commit/customtools-plugin/84cac80f50b70aa1f31ba23b1a169e4a69ce7425
            Log:
            JENKINS-20560 - Don't try to override empty paths
            Caused by the initial fix of https://issues.jenkins-ci.org/browse/JENKINS-20560

            Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java http://jenkins-ci.org/commit/customtools-plugin/84cac80f50b70aa1f31ba23b1a169e4a69ce7425 Log: JENKINS-20560 - Don't try to override empty paths Caused by the initial fix of https://issues.jenkins-ci.org/browse/JENKINS-20560 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java
            src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java
            src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java
            http://jenkins-ci.org/commit/customtools-plugin/6c81ebbc162d9ccfaba9750d977a68c9f5dacc0e
            Log:
            Merge pull request #13 from synopsys-arc-oss/JENKINS_20560_FIX

            [FIXED JENKINS-20560] - Custom-tools should not override global paths in...

            Compare: https://github.com/jenkinsci/customtools-plugin/compare/5d9a150ffd10...6c81ebbc162d

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapper.java src/main/java/com/synopsys/arc/jenkinsci/plugins/customtools/PathsList.java src/test/java/com/cloudbees/jenkins/plugins/customtools/CustomToolInstallWrapperTest.java http://jenkins-ci.org/commit/customtools-plugin/6c81ebbc162d9ccfaba9750d977a68c9f5dacc0e Log: Merge pull request #13 from synopsys-arc-oss/JENKINS_20560_FIX [FIXED JENKINS-20560] - Custom-tools should not override global paths in... Compare: https://github.com/jenkinsci/customtools-plugin/compare/5d9a150ffd10...6c81ebbc162d

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: