Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20597

Jenkins asks for confirmation before leaving edited 'View Configuration' page

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • ci.jenkins-ci.org 1.539-SNAPSHOT (rc-11/11/2013 15:37 GMT-kohsuke)

      JENKINS-19835 adds a confirmation dialog before navigating away from an edited config page.

      This makes no sense at all when the user doesn't have Configure permission, only Extended Read ('View Configuration' link).

          [JENKINS-20597] Jenkins asks for confirmation before leaving edited 'View Configuration' page

          Daniel Beck added a comment -

          Daniel Beck added a comment - Fix is part of PR 1175 at https://github.com/jenkinsci/jenkins/pull/1175

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/hudson/model/Run/configure.jelly
          http://jenkins-ci.org/commit/jenkins/ee64eb920cee5af9f430cfcdfd341714549960ce
          Log:
          [FIXED JENKINS-20597] Only ask when user can change

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly http://jenkins-ci.org/commit/jenkins/ee64eb920cee5af9f430cfcdfd341714549960ce Log: [FIXED JENKINS-20597] Only ask when user can change

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/resources/hudson/logging/LogRecorder/configure.jelly
          core/src/main/resources/hudson/model/Computer/configure.jelly
          core/src/main/resources/hudson/model/ComputerSet/_new.jelly
          core/src/main/resources/hudson/model/ComputerSet/configure.jelly
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/hudson/model/Run/configure.jelly
          core/src/main/resources/hudson/model/User/configure.jelly
          core/src/main/resources/hudson/model/View/configure.jelly
          core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly
          core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
          core/src/main/resources/jenkins/model/Jenkins/configure.jelly
          core/src/main/resources/lib/form/confirm.js
          http://jenkins-ci.org/commit/jenkins/fc471153db957be8d06d2fea63306e8b2f060462
          Log:
          Merge pull request #1175 from daniel-beck/JENKINS-21720-2

          [FIXED JENKINS-20597 JENKINS-21720] Improved config confirmation.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/resources/hudson/logging/LogRecorder/configure.jelly core/src/main/resources/hudson/model/Computer/configure.jelly core/src/main/resources/hudson/model/ComputerSet/_new.jelly core/src/main/resources/hudson/model/ComputerSet/configure.jelly core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly core/src/main/resources/hudson/model/User/configure.jelly core/src/main/resources/hudson/model/View/configure.jelly core/src/main/resources/hudson/model/labels/LabelAtom/configure.jelly core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/jenkins/model/Jenkins/configure.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/fc471153db957be8d06d2fea63306e8b2f060462 Log: Merge pull request #1175 from daniel-beck/ JENKINS-21720 -2 [FIXED JENKINS-20597 JENKINS-21720] Improved config confirmation.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3321
          [FIXED JENKINS-20597] Only ask when user can change (Revision ee64eb920cee5af9f430cfcdfd341714549960ce)

          Result = SUCCESS
          daniel-beck : ee64eb920cee5af9f430cfcdfd341714549960ce
          Files :

          • core/src/main/resources/hudson/model/Run/configure.jelly
          • core/src/main/resources/hudson/model/Job/configure.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3321 [FIXED JENKINS-20597] Only ask when user can change (Revision ee64eb920cee5af9f430cfcdfd341714549960ce) Result = SUCCESS daniel-beck : ee64eb920cee5af9f430cfcdfd341714549960ce Files : core/src/main/resources/hudson/model/Run/configure.jelly core/src/main/resources/hudson/model/Job/configure.jelly

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/hudson/model/Run/configure.jelly
          http://jenkins-ci.org/commit/jenkins/d244762721422283318c934d14cff128f7198b08
          Log:
          [FIXED JENKINS-20597] Only ask when user can change

          (cherry picked from commit ee64eb920cee5af9f430cfcdfd341714549960ce)

          Conflicts:
          core/src/main/resources/hudson/model/Run/configure.jelly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/hudson/model/Run/configure.jelly http://jenkins-ci.org/commit/jenkins/d244762721422283318c934d14cff128f7198b08 Log: [FIXED JENKINS-20597] Only ask when user can change (cherry picked from commit ee64eb920cee5af9f430cfcdfd341714549960ce) Conflicts: core/src/main/resources/hudson/model/Run/configure.jelly

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: