Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19835

Configuration page leave confirmation

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None

    Description

      Jenkins doesn't warn when a configuration page with changes made is closed. It is now common to see a modal window prompting whether the user actually intends to leave the page or prefers to stay.

      Attachments

        Issue Links

          is duplicated by

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-17618 "Changes not yet saved" message on Configuration screens

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20597 Jenkins asks for confirmation before leaving edited 'View Configuration' page

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-21720 Don't ask for confirmation when it doesn't make any sense

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            mcupak Miro Cupak added a comment -

            PR: https://github.com/jenkinsci/jenkins/pull/962

            mcupak Miro Cupak added a comment - PR: https://github.com/jenkinsci/jenkins/pull/962
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: mcupak
            Path:
            core/src/main/resources/hudson/model/Job/configure.jelly
            core/src/main/resources/lib/form/apply.jelly
            core/src/main/resources/lib/form/confirm.js
            http://jenkins-ci.org/commit/jenkins/4c21bcee27cb36e1a8b7d687663b445b2f336d81
            Log:
            JENKINS-19835 added page-leave confirmation on the configuration page

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: mcupak Path: core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/4c21bcee27cb36e1a8b7d687663b445b2f336d81 Log: JENKINS-19835 added page-leave confirmation on the configuration page
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/resources/hudson/model/Job/configure.jelly
            core/src/main/resources/lib/form/apply.jelly
            core/src/main/resources/lib/form/confirm.js
            http://jenkins-ci.org/commit/jenkins/d3bce1e2de9fc0db250a1b7326e8da763d8b98a2
            Log:
            [FIXED JENKINS-19835]

            Merged pull request #962.

            Compare: https://github.com/jenkinsci/jenkins/compare/a84d1bca7aa3...d3bce1e2de9f

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/d3bce1e2de9fc0db250a1b7326e8da763d8b98a2 Log: [FIXED JENKINS-19835] Merged pull request #962. Compare: https://github.com/jenkinsci/jenkins/compare/a84d1bca7aa3...d3bce1e2de9f
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2987
            JENKINS-19835 added page-leave confirmation on the configuration page (Revision 4c21bcee27cb36e1a8b7d687663b445b2f336d81)

            Result = SUCCESS
            kohsuke : 4c21bcee27cb36e1a8b7d687663b445b2f336d81
            Files :

            • core/src/main/resources/lib/form/confirm.js
            • core/src/main/resources/hudson/model/Job/configure.jelly
            • core/src/main/resources/lib/form/apply.jelly
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2987 JENKINS-19835 added page-leave confirmation on the configuration page (Revision 4c21bcee27cb36e1a8b7d687663b445b2f336d81) Result = SUCCESS kohsuke : 4c21bcee27cb36e1a8b7d687663b445b2f336d81 Files : core/src/main/resources/lib/form/confirm.js core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly
            danielbeck Daniel Beck added a comment -

            This change broke submitting the form using the keyboard (by pressing the return key).

            danielbeck Daniel Beck added a comment - This change broke submitting the form using the keyboard (by pressing the return key).

            People

              mcupak Miro Cupak
              mcupak Miro Cupak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: