• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Jenkins doesn't warn when a configuration page with changes made is closed. It is now common to see a modal window prompting whether the user actually intends to leave the page or prefers to stay.

          [JENKINS-19835] Configuration page leave confirmation

          Miro Cupak added a comment -

          Miro Cupak added a comment - PR: https://github.com/jenkinsci/jenkins/pull/962

          Code changed in jenkins
          User: mcupak
          Path:
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/lib/form/apply.jelly
          core/src/main/resources/lib/form/confirm.js
          http://jenkins-ci.org/commit/jenkins/4c21bcee27cb36e1a8b7d687663b445b2f336d81
          Log:
          JENKINS-19835 added page-leave confirmation on the configuration page

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: mcupak Path: core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/4c21bcee27cb36e1a8b7d687663b445b2f336d81 Log: JENKINS-19835 added page-leave confirmation on the configuration page

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/lib/form/apply.jelly
          core/src/main/resources/lib/form/confirm.js
          http://jenkins-ci.org/commit/jenkins/d3bce1e2de9fc0db250a1b7326e8da763d8b98a2
          Log:
          [FIXED JENKINS-19835]

          Merged pull request #962.

          Compare: https://github.com/jenkinsci/jenkins/compare/a84d1bca7aa3...d3bce1e2de9f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly core/src/main/resources/lib/form/confirm.js http://jenkins-ci.org/commit/jenkins/d3bce1e2de9fc0db250a1b7326e8da763d8b98a2 Log: [FIXED JENKINS-19835] Merged pull request #962. Compare: https://github.com/jenkinsci/jenkins/compare/a84d1bca7aa3...d3bce1e2de9f

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2987
          JENKINS-19835 added page-leave confirmation on the configuration page (Revision 4c21bcee27cb36e1a8b7d687663b445b2f336d81)

          Result = SUCCESS
          kohsuke : 4c21bcee27cb36e1a8b7d687663b445b2f336d81
          Files :

          • core/src/main/resources/lib/form/confirm.js
          • core/src/main/resources/hudson/model/Job/configure.jelly
          • core/src/main/resources/lib/form/apply.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #2987 JENKINS-19835 added page-leave confirmation on the configuration page (Revision 4c21bcee27cb36e1a8b7d687663b445b2f336d81) Result = SUCCESS kohsuke : 4c21bcee27cb36e1a8b7d687663b445b2f336d81 Files : core/src/main/resources/lib/form/confirm.js core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/apply.jelly

          Daniel Beck added a comment -

          This change broke submitting the form using the keyboard (by pressing the return key).

          Daniel Beck added a comment - This change broke submitting the form using the keyboard (by pressing the return key).

            mcupak Miro Cupak
            mcupak Miro Cupak
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: