• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Jenkins 1.509.4
      Jenkins 1.532.1 RC1
      Firefox 17.0.10 ESR

      The error screens shown for invalid configurations after pressing 'Apply' don't work.

      Steps to reproduce:
      0. Install Jenkins Enterprise with Cloudbees Template Plugin 4.1
      1. Create a job template
      3. Clear the 'name' attribute's ID field
      4. Press 'Apply'

      Expected result: Error message shown
      Actual result: Huge, empty dialog with title 'Error' shown (error screen seems to appear, but is immediately removed)

          [JENKINS-20772] 'Apply' error screens don't work

          Daniel Beck created issue -

          Daniel Beck added a comment -

          There are several issues about the errors that (don't) appear in response to some action (JENKINS-17401, JENKINS-13287, JENKINS-19037, possibly others) but none seem to cover the problem that the error screen is completely useless because it doesn't show the error (e.g. stacktrace).

          Daniel Beck added a comment - There are several issues about the errors that (don't) appear in response to some action ( JENKINS-17401 , JENKINS-13287 , JENKINS-19037 , possibly others) but none seem to cover the problem that the error screen is completely useless because it doesn't show the error (e.g. stacktrace).

          This is also an issue if you rename it to anything other than the original namen and click the apply button.

          Steven Christou added a comment - This is also an issue if you rename it to anything other than the original namen and click the apply button.
          Steven Christou made changes -
          Assignee New: Steven Christou [ schristou ]

          Daniel Beck added a comment -

          My apologies for the badly selected example. I tried to make it easy to reproduce, and failed to test what happens when pressing Save instead.

          Note that this is not about the exception with stacktrace presented when saving, but the fact that the dialog is completely useless as an error dialog.

          Daniel Beck added a comment - My apologies for the badly selected example. I tried to make it easy to reproduce, and failed to test what happens when pressing Save instead. Note that this is not about the exception with stacktrace presented when saving, but the fact that the dialog is completely useless as an error dialog.
          Daniel Beck made changes -
          Description Original: The error screens shown for invalid configurations after pressing 'Apply' don't work.

          Steps to reproduce:
          1. Create a freestyle job with a unique, valid name
          3. Clear the name in the config screen
          4. Press 'Apply'

          Expected result: Error message shown
          Actual result: Huge, empty dialog with title 'Error' shown (error screen seems to appear, but is immediately removed)
          New: The error screens shown for invalid configurations after pressing 'Apply' don't work.

          Steps to reproduce:
          0. Install Jenkins Enterprise with Cloudbees Template Plugin 4.1
          1. Create a job template
          3. Clear the 'name' attribute's ID field
          4. Press 'Apply'

          Expected result: Error message shown
          Actual result: Huge, empty dialog with title 'Error' shown (error screen seems to appear, but is immediately removed)

          Jesse Glick added a comment -

          By the way the actual exception in this case is fixed in the 4.2 release of the Templates plugin.

          Jesse Glick added a comment - By the way the actual exception in this case is fixed in the 4.2 release of the Templates plugin.
          Jesse Glick made changes -
          Assignee Original: Steven Christou [ schristou ] New: Kohsuke Kawaguchi [ kohsuke ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-17401 [ JENKINS-17401 ]

          Jesse Glick added a comment - - edited

          The originally reported issue is actually a bug in the Templates plugin, and very similar to JENKINS-17401. Jenkins is sending a redirect and the Apply handler does not expect this. The fix is just to send a warning in that case, not a redirect. Update: actually there seems to be no such redirect in the Templates plugin, so that issue probably really is what is reported here: failure to display a stack trace.

          The more general issue is that if an exception is actually thrown, you get a blank error dialog. This is trivially reproduced (in Chrome at least) by configuring a freestyle project, checking Build periodically, and typing some junk into the Schedule field. In apply.js, the error-handling code using responseDialog is triggered, but it does not work.

          Jesse Glick added a comment - - edited The originally reported issue is actually a bug in the Templates plugin, and very similar to JENKINS-17401 . Jenkins is sending a redirect and the Apply handler does not expect this. The fix is just to send a warning in that case, not a redirect. Update: actually there seems to be no such redirect in the Templates plugin, so that issue probably really is what is reported here: failure to display a stack trace. The more general issue is that if an exception is actually thrown, you get a blank error dialog. This is trivially reproduced (in Chrome at least) by configuring a freestyle project, checking Build periodically , and typing some junk into the Schedule field. In apply.js , the error-handling code using responseDialog is triggered, but it does not work.

            jglick Jesse Glick
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: