[JENKINS-21780] DirectoryBrowserSupport.buildChildPaths does quadratic number of calls to check whether entries are directories - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core
Labels:
- 1.532.3-rejected
- performance

Similar Issues:

Show

Description

From a thread dump when the workspace browser was timing out trying to show me a directory:

"Handling GET /job/.../ws/test/target/surefire-reports/ : ... / waiting for hudson.remoting.Channel@..." Id=... Group=main TIMED_WAITING on hudson.remoting.UserRequest@...
	at java.lang.Object.wait(Native Method)
	-  waiting on hudson.remoting.UserRequest@280e3332
	at hudson.remoting.Request.call(Request.java:146)
	at hudson.remoting.Channel.call(Channel.java:714)
	at hudson.FilePath.act(FilePath.java:905)
	at hudson.FilePath.act(FilePath.java:889)
	at hudson.FilePath.isDirectory(FilePath.java:1389)
	at jenkins.util.VirtualFile$2.isDirectory(VirtualFile.java:266)
	at hudson.model.DirectoryBrowserSupport$FileComparator.dirRank(DirectoryBrowserSupport.java:443)
	at hudson.model.DirectoryBrowserSupport$FileComparator.compare(DirectoryBrowserSupport.java:435)
	at hudson.model.DirectoryBrowserSupport$FileComparator.compare(DirectoryBrowserSupport.java:426)
	at java.util.TimSort.mergeHi(Unknown Source)
	at java.util.TimSort.mergeAt(Unknown Source)
	at java.util.TimSort.mergeCollapse(Unknown Source)
	at java.util.TimSort.sort(Unknown Source)
	at java.util.TimSort.sort(Unknown Source)
	at java.util.Arrays.sort(Unknown Source)
	at hudson.model.DirectoryBrowserSupport.buildChildPaths(DirectoryBrowserSupport.java:460)
	at hudson.model.DirectoryBrowserSupport.serveFile(DirectoryBrowserSupport.java:254)
	at hudson.model.DirectoryBrowserSupport.generateResponse(DirectoryBrowserSupport.java:123)

Attachments

Issue Links

is related to

JENKINS-22514 Zip generated from "all files in zip" contains the wrong slashes

Resolved

Activity

Ascending order - Click to sort in descending order

View 8 older comments

dogfood added a comment - 2014-02-27 02:52

Integrated in jenkins_main_trunk #3200
[FIXED JENKINS-21780] Revised fix to make cache work properly without introducing a new remote call to find hash codes. (Revision e51fdbbc0e74f14aceef9f4e9729fc33e300bbc3)
~~JENKINS-21780~~ Much more effective fix. (Revision 6fe5d6c6bab63998b11a3b987c57f59a928c965e)

Result = UNSTABLE
Jesse Glick : e51fdbbc0e74f14aceef9f4e9729fc33e300bbc3
Files :

changelog.html
core/src/main/java/hudson/model/DirectoryBrowserSupport.java

Jesse Glick : 6fe5d6c6bab63998b11a3b987c57f59a928c965e
Files :

core/src/main/java/jenkins/util/VirtualFile.java
core/src/main/java/hudson/model/DirectoryBrowserSupport.java

dogfood added a comment - 2014-02-27 02:52 Integrated in jenkins_main_trunk #3200 [FIXED JENKINS-21780] Revised fix to make cache work properly without introducing a new remote call to find hash codes. (Revision e51fdbbc0e74f14aceef9f4e9729fc33e300bbc3) JENKINS-21780 Much more effective fix. (Revision 6fe5d6c6bab63998b11a3b987c57f59a928c965e) Result = UNSTABLE Jesse Glick : e51fdbbc0e74f14aceef9f4e9729fc33e300bbc3 Files : changelog.html core/src/main/java/hudson/model/DirectoryBrowserSupport.java Jesse Glick : 6fe5d6c6bab63998b11a3b987c57f59a928c965e Files : core/src/main/java/jenkins/util/VirtualFile.java core/src/main/java/hudson/model/DirectoryBrowserSupport.java

Alex Ouzounis added a comment - 2014-03-04 20:32

Is this fix present in the latest version ?

We are also getting hit by it.

Alex Ouzounis added a comment - 2014-03-04 20:32 Is this fix present in the latest version ? We are also getting hit by it.

Daniel Beck added a comment - 2014-03-04 20:36

Alex Ouzounis: Try http://jenkins-ci.org/changelog ("upcoming changes" might be interesting)

Daniel Beck added a comment - 2014-03-04 20:36 Alex Ouzounis: Try http://jenkins-ci.org/changelog ("upcoming changes" might be interesting)

Alex Ouzounis added a comment - 2014-03-04 20:38

Aha!

Yes, indeed. Its part of 1.554

Thanks for the quick reply

Alex