Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22514

Zip generated from "all files in zip" contains the wrong slashes

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Windows Server 2008, Java 7u25

      The zip downloaded from "all files in zip" contains backwards slashes, which result in these becoming part of the filename when the zip is extracted (instead of becoming subdirectories.)

      Here is the output I get from unzip -t:

      Archive:  /Users/daniel/Downloads/functional-tests.zip
          testing: functional-tests/0095eaafc6104c20af6ec6f3cee22ba0\derby.log   OK
          testing: functional-tests/0095eaafc6104c20af6ec6f3cee22ba0\app.log   OK
          testing: functional-tests/0095eaafc6104c20af6ec6f3cee22ba0\stderr.log   OK
          testing: functional-tests/0095eaafc6104c20af6ec6f3cee22ba0\stdout.log   OK
          testing: functional-tests/06f5fd94c53849378657dff5682e6610\derby.log   OK
          testing: functional-tests/06f5fd94c53849378657dff5682e6610\app.log   OK
          testing: functional-tests/06f5fd94c53849378657dff5682e6610\stderr.log   OK
          testing: functional-tests/06f5fd94c53849378657dff5682e6610\stdout.log   OK
          testing: functional-tests/0869e783b162411fa8fadae3b28c98e2\app.log   OK
          testing: functional-tests/0869e783b162411fa8fadae3b28c98e2\stderr.log   OK
          testing: functional-tests/0869e783b162411fa8fadae3b28c98e2\stdout.log   OK
      

          [JENKINS-22514] Zip generated from "all files in zip" contains the wrong slashes

          Daniel Beck added a comment -

          Holger took over, so assigning the issue to him.

          Daniel Beck added a comment - Holger took over, so assigning the issue to him.

          Holger Voormann added a comment - - edited

          JENKINS-22514_Tests.zip: Detailed test results and scripts/jobs used.

          See pull request comment

          Holger Voormann added a comment - - edited JENKINS-22514_Tests.zip : Detailed test results and scripts/jobs used. See pull request comment

          @Daniel Could you please merge pull request #1408? I'm not a Jenkins committer.

          Holger Voormann added a comment - @Daniel Could you please merge pull request #1408 ? I'm not a Jenkins committer.

          Code changed in jenkins
          User: Holger Voormann
          Path:
          core/src/main/java/hudson/model/DirectoryBrowserSupport.java
          http://jenkins-ci.org/commit/jenkins/c56362aba30a3ae35312db3ca6222249b063e71d
          Log:
          [FIXED JENKINS-22514] In ZIP archives file separator must be '/'

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Holger Voormann Path: core/src/main/java/hudson/model/DirectoryBrowserSupport.java http://jenkins-ci.org/commit/jenkins/c56362aba30a3ae35312db3ca6222249b063e71d Log: [FIXED JENKINS-22514] In ZIP archives file separator must be '/'

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/DirectoryBrowserSupport.java
          http://jenkins-ci.org/commit/jenkins/fef47e124fb9826f1e1d8f740044496d7dede4af
          Log:
          Merge pull request #1408 from howlger/master

          [FIXED JENKINS-22514] In ZIP archives file separator must be '/'

          Compare: https://github.com/jenkinsci/jenkins/compare/e71d5e42c4cc...fef47e124fb9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/DirectoryBrowserSupport.java http://jenkins-ci.org/commit/jenkins/fef47e124fb9826f1e1d8f740044496d7dede4af Log: Merge pull request #1408 from howlger/master [FIXED JENKINS-22514] In ZIP archives file separator must be '/' Compare: https://github.com/jenkinsci/jenkins/compare/e71d5e42c4cc...fef47e124fb9

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3806
          [FIXED JENKINS-22514] In ZIP archives file separator must be '/' (Revision c56362aba30a3ae35312db3ca6222249b063e71d)

          Result = SUCCESS
          github : c56362aba30a3ae35312db3ca6222249b063e71d
          Files :

          • core/src/main/java/hudson/model/DirectoryBrowserSupport.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3806 [FIXED JENKINS-22514] In ZIP archives file separator must be '/' (Revision c56362aba30a3ae35312db3ca6222249b063e71d) Result = SUCCESS github : c56362aba30a3ae35312db3ca6222249b063e71d Files : core/src/main/java/hudson/model/DirectoryBrowserSupport.java

          The changelog says that the fix of this issue is included in 1.590. But this is wrong: see DirectoryBrowserSupport tagged with jenkins-1.590. Probably, this issue will be fixed with the upcoming version 1.591.

          Holger Voormann added a comment - The changelog says that the fix of this issue is included in 1.590 . But this is wrong: see DirectoryBrowserSupport tagged with jenkins-1.590 . Probably, this issue will be fixed with the upcoming version 1.591.

          steven sun added a comment - - edited

          i think this problem is still alive on 1.590. maybe something wrong when source merge.

          i use "all files in zip" function to aa.zip in Windows7, then unzip aa.zip on Linux.
          all subfolders are not idenfied. all files are unzip with the name "subfolde+filename".

          earnest hope fixed this issue.

          steven sun added a comment - - edited i think this problem is still alive on 1.590. maybe something wrong when source merge. i use "all files in zip" function to aa.zip in Windows7, then unzip aa.zip on Linux. all subfolders are not idenfied. all files are unzip with the name "subfolde+filename". earnest hope fixed this issue.

          Daniel Beck added a comment -

          sot007 Consider reading the preceding comment(s) before writing one of your own

          I moved the changelog entry to reflect reality.

          Daniel Beck added a comment - sot007 Consider reading the preceding comment(s) before writing one of your own I moved the changelog entry to reflect reality.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/6bf6e7f501ce2c27d99824936b92d3f9703856d6
          Log:
          JENKINS-22514 is only in 1.591

          Fixing 9162c3cbb742f13548d5513a26e5b6ef42d62480

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: changelog.html http://jenkins-ci.org/commit/jenkins/6bf6e7f501ce2c27d99824936b92d3f9703856d6 Log: JENKINS-22514 is only in 1.591 Fixing 9162c3cbb742f13548d5513a26e5b6ef42d62480

            howlger Holger Voormann
            trejkaz trejkaz
            Votes:
            3 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: