Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22311

Large number of build parameters for pending jobs (e.g.gerrit triggered job) can cause unwieldy build history

      If Gerrit triggers create a queue in the Pending Jobs column in the project page, it will insert build parameters/metadata about the trigger: GERRIT_EVENT_TYPE, GERRIT_EVENT_HASH, etc.

      If this metadata is long, it will distort the project page to be visually unusable.

      Would like a way to either turn of or truncate this display of Gerrit metadata.

          [JENKINS-22311] Large number of build parameters for pending jobs (e.g.gerrit triggered job) can cause unwieldy build history

          Eric Griswold created issue -
          rin_ne made changes -
          Assignee Original: rsandell [ rsandell ] New: Eric Griswold [ eric_griswold ]

          rin_ne added a comment -

          "metadata is long" means that a parameter has long value?
          If so, I think this is mainly jenkins issue.

          AFAIK, it is GERRIT_CHANGE_COMMIT_MESSAGE only. Because this is multi-line text, others are single-line.
          So StringParameterValue class should be replaced to TextParameterValue.

          But it would not be solved. ParameterValue which is extended by both StringParameterValue and
          TextParameterValue has 2 methods for description.
          In Javadoc, getShortDescription() requires one-line string as return value. I think this is truncation spec
          you mentioned.
          http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#getShortDescription()

          But, as of now, TextParameterValue which extends StringParameterValue does not have any overrided
          methods for getShortDescription().
          https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/TextParameterValue.java

          It means that TextParameterValue#getShortDescription returns the same value as StringParameterValue's one.

          So, unfortunately, it is hard to solve this issue only by plugin fixes.

          If "metadata is long" means a lot of parameters, it is also Jenkins issue.
          Jenkins does not have the way to reduce the display number of parameters from plugin side.

          rin_ne added a comment - "metadata is long" means that a parameter has long value? If so, I think this is mainly jenkins issue. AFAIK, it is GERRIT_CHANGE_COMMIT_MESSAGE only. Because this is multi-line text, others are single-line. So StringParameterValue class should be replaced to TextParameterValue. But it would not be solved. ParameterValue which is extended by both StringParameterValue and TextParameterValue has 2 methods for description. In Javadoc, getShortDescription() requires one-line string as return value. I think this is truncation spec you mentioned. http://javadoc.jenkins-ci.org/hudson/model/ParameterValue.html#getShortDescription( ) But, as of now, TextParameterValue which extends StringParameterValue does not have any overrided methods for getShortDescription(). https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/TextParameterValue.java It means that TextParameterValue#getShortDescription returns the same value as StringParameterValue's one. So, unfortunately, it is hard to solve this issue only by plugin fixes. If "metadata is long" means a lot of parameters, it is also Jenkins issue. Jenkins does not have the way to reduce the display number of parameters from plugin side.

          Eric Griswold added a comment -

          Here's a screenshot.

          Eric Griswold added a comment - Here's a screenshot.
          Eric Griswold made changes -
          Attachment New: eric.griswold-shot-window-0x1c25fe5.png [ 25606 ]
          Eric Griswold made changes -
          Component/s New: core [ 15593 ]
          Assignee Original: Eric Griswold [ eric_griswold ] New: rsandell [ rsandell ]

          rin_ne added a comment -

          From screenshot, this issue is not "long string in a parameter" but "too many parameters". Is it correct?

          If so, plugin does not have any solution to fix this.

          rin_ne added a comment - From screenshot, this issue is not "long string in a parameter" but "too many parameters". Is it correct? If so, plugin does not have any solution to fix this.
          rsandell made changes -
          Component/s Original: gerrit-trigger [ 15731 ]
          Assignee Original: rsandell [ rsandell ]

          Eric Griswold added a comment -

          Looks like either or both. I keep trying to find a way to send this to core development. If it gets redirected back to you, please let me know what I'm doing wrong.

          Eric Griswold added a comment - Looks like either or both. I keep trying to find a way to send this to core development. If it gets redirected back to you, please let me know what I'm doing wrong.

          any updates on the issue?

          It makes the queue overview almost impossible to manage.

          Aleksandra Fedorova added a comment - any updates on the issue? It makes the queue overview almost impossible to manage.

            danielbeck Daniel Beck
            eric_griswold Eric Griswold
            Votes:
            9 Vote for this issue
            Watchers:
            15 Start watching this issue

              Created:
              Updated:
              Resolved: