Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23151

codemirror-mode on f:textarea broken (was: Execute shell build step text not saved properly)

      When I create a simple project and add Execute shell task,
      after save, the task contents are empty.
      config.xml on the server is empty too:

      <hudson.tasks.Shell><command/></hudson.tasks.Shell>
      

      When editing the config a second time, the contents are saved properly.
      Each consecutive add of shell task requires a second edit.

      When using inheritance plugin, there is no way to workaround the bug, since each edit creates new revision, and all shell tasks are empty.

      I tested it on 1.563 and 1.564

          [JENKINS-23151] codemirror-mode on f:textarea broken (was: Execute shell build step text not saved properly)

          Szymon S created issue -

          I have the same problem (with Jenkins 1.563, on RHEL6, browser Chrome), not present in older releases (e.g. 1.540). If you click on "apply" in the configuration page, then on "save" it seems to work always, instead, by using directly the "save" button, textarea contents sometimes is lost.

          Donato Tagliabue added a comment - I have the same problem (with Jenkins 1.563, on RHEL6, browser Chrome), not present in older releases (e.g. 1.540). If you click on "apply" in the configuration page, then on "save" it seems to work always, instead, by using directly the "save" button, textarea contents sometimes is lost.
          Daniel Beck made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: build-pipeline [ 15962 ]
          Affects Version/s Original: current [ 10162 ]
          Description Original: When I create a simple project and add Execute shell task,
          after save, the task contents are empty.
          config.xml on the server is empty too:
          {code}
          <hudson.tasks.Shell><command/></hudson.tasks.Shell>
          {code}

          When editing the config a second time, the contents are saved properly.
          Each consecutive add of shell task requires a second edit.

          When using inheritance plugin, there is no way to workaround the bug, since each edit creates new revision, and all shell tasks are empty.

          I tested it on 1.563 and 1564
          New: When I create a simple project and add Execute shell task,
          after save, the task contents are empty.
          config.xml on the server is empty too:
          {code}
          <hudson.tasks.Shell><command/></hudson.tasks.Shell>
          {code}

          When editing the config a second time, the contents are saved properly.
          Each consecutive add of shell task requires a second edit.

          When using inheritance plugin, there is no way to workaround the bug, since each edit creates new revision, and all shell tasks are empty.

          I tested it on 1.563 and 1.564
          Summary Original: Execute shell window not saved properly New: Execute shell build step text not saved properly
          Daniel Beck made changes -
          Assignee New: Daniel Beck [ danielbeck ]

          Daniel Beck added a comment - - edited

          Introduced in 1.561, specifically this commit.

          Daniel Beck added a comment - - edited Introduced in 1.561, specifically this commit .
          Daniel Beck made changes -
          Assignee Original: Daniel Beck [ danielbeck ]

          Jesse Glick added a comment -

          Seems reproducible, but only the first time the build step is added. Apparently CodeMirror does not work properly with Jenkins forms. Not terribly surprising, since it does awful hacks—hiding the original text area and adding a new one.

          Jesse Glick added a comment - Seems reproducible, but only the first time the build step is added. Apparently CodeMirror does not work properly with Jenkins forms. Not terribly surprising, since it does awful hacks—hiding the original text area and adding a new one.
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-15604 [ JENKINS-15604 ]
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

            Unassigned Unassigned
            sobczyk Szymon S
            Votes:
            5 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: