• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Critical Critical
    • pipeline

        [JENKINS-28769] Enable syntax highlighting on workflow DSL

        Tom FENNELLY added a comment -

        Coremirror is a horrible thing in my experience. I really think we should look at using something like the ACE Editor. It's used by lots of online services including GitHub (for Gists etc) and it's open source.

        Tom FENNELLY added a comment - Coremirror is a horrible thing in my experience. I really think we should look at using something like the ACE Editor. It's used by lots of online services including GitHub (for Gists etc) and it's open source.

        Code changed in jenkins
        User: Jesse Glick
        Path:
        .gitignore
        CHANGES.md
        cps/gulpfile.js
        cps/package.json
        cps/pom.xml
        cps/src/main/js/samples.js
        cps/src/main/js/workflow-editor.js
        cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition/config.jelly
        cps/src/main/webapp/snippets/workflow.js
        http://jenkins-ci.org/commit/workflow-plugin/8cd644995d937656dabc8494aa2b2ad61202fc4a
        Log:
        [FIXED JENKINS-28769] Merging #234.

        Compare: https://github.com/jenkinsci/workflow-plugin/compare/fd3a15b5e53e...8cd644995d93

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: .gitignore CHANGES.md cps/gulpfile.js cps/package.json cps/pom.xml cps/src/main/js/samples.js cps/src/main/js/workflow-editor.js cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition/config.jelly cps/src/main/webapp/snippets/workflow.js http://jenkins-ci.org/commit/workflow-plugin/8cd644995d937656dabc8494aa2b2ad61202fc4a Log: [FIXED JENKINS-28769] Merging #234. Compare: https://github.com/jenkinsci/workflow-plugin/compare/fd3a15b5e53e...8cd644995d93

        Code changed in jenkins
        User: Jesse Glick
        Path:
        src/main/java/org/jenkinsci/test/acceptance/po/WorkflowJob.java
        http://jenkins-ci.org/commit/acceptance-test-harness/adfaf2e28061d7c3cd433d7cb2258d2fad06aeb2
        Log:
        JENKINS-28769 Allow job.script.set("script") to work with or without ACE.

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/test/acceptance/po/WorkflowJob.java http://jenkins-ci.org/commit/acceptance-test-harness/adfaf2e28061d7c3cd433d7cb2258d2fad06aeb2 Log: JENKINS-28769 Allow job.script.set("script") to work with or without ACE.

        Code changed in jenkins
        User: Oliver Gondža
        Path:
        docs/INVESTIGATION.md
        src/main/java/org/jenkinsci/test/acceptance/po/WorkflowJob.java
        http://jenkins-ci.org/commit/acceptance-test-harness/c65c98c7b9f25307bdb68c09729b7fc35d50e1ec
        Log:
        Merge pull request #57 from jglick/WorkflowJob-ACE-JENKINS-28769

        JENKINS-28769 Allow Workflow tests to run with or without ACE

        Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/10e1069d7365...c65c98c7b9f2

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: docs/INVESTIGATION.md src/main/java/org/jenkinsci/test/acceptance/po/WorkflowJob.java http://jenkins-ci.org/commit/acceptance-test-harness/c65c98c7b9f25307bdb68c09729b7fc35d50e1ec Log: Merge pull request #57 from jglick/WorkflowJob-ACE- JENKINS-28769 JENKINS-28769 Allow Workflow tests to run with or without ACE Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/10e1069d7365...c65c98c7b9f2

        Code changed in jenkins
        User: Jesse Glick
        Path:
        cps/gulpfile.js
        cps/package.json
        cps/pom.xml
        cps/src/main/js/samples.js
        cps/src/main/js/workflow-editor.js
        cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition/config.jelly
        cps/src/main/webapp/snippets/workflow.js
        http://jenkins-ci.org/commit/workflow-cps-plugin/5f224541837546412a563cc6dfbd41f3003bbe17
        Log:
        [FIXED JENKINS-28769] Merging #234.

        Originally-Committed-As: 8cd644995d937656dabc8494aa2b2ad61202fc4a

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/gulpfile.js cps/package.json cps/pom.xml cps/src/main/js/samples.js cps/src/main/js/workflow-editor.js cps/src/main/resources/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition/config.jelly cps/src/main/webapp/snippets/workflow.js http://jenkins-ci.org/commit/workflow-cps-plugin/5f224541837546412a563cc6dfbd41f3003bbe17 Log: [FIXED JENKINS-28769] Merging #234. Originally-Committed-As: 8cd644995d937656dabc8494aa2b2ad61202fc4a

          tfennelly Tom FENNELLY
          ndeloof Nicolas De Loof
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

            Created:
            Updated:
            Resolved: